Skip to content

fix(Web3TokenView): only enable WebView contents debugging in debug builds (refs #2323) #3439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jim-daf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(Web3TokenView): only enable WebView contents debugging in debug builds (refs #2323) #3439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/src/main/java/com/alphawallet/app/web3/Web3TokenView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,11 @@ private void init() {
webSettings.setLoadWithOverviewMode(true);
webSettings.setUserAgentString(webSettings.getUserAgentString()
+ "AlphaWallet(Platform=Android&AppVersion=" + BuildConfig.VERSION_NAME + ")");
WebView.setWebContentsDebuggingEnabled(true);
// CWE-489: Web3TokenView holds session JS for a wallet that signs
// transactions. Leaving WebView contents debuggable in release builds
// lets anyone with USB access attach chrome://inspect and read the
// page's DOM/JS. Restrict to debug builds only.
WebView.setWebContentsDebuggingEnabled(BuildConfig.DEBUG);
Comment on lines +126 to +130
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebView.setWebContentsDebuggingEnabled(...) is process-wide. Even though this call is now gated by BuildConfig.DEBUG, there is still an unconditional WebView.setWebContentsDebuggingEnabled(true) in app/src/main/java/com/alphawallet/app/web3/Web3View.java (around line 190) which is used by production layouts (e.g. fragment_webview.xml). That means release builds can still end up with WebView debugging enabled, defeating the security goal described in the comment. Consider gating/removing the other call sites as well (or centralizing this setting so it can’t be re-enabled in release).

Copilot uses AI. Check for mistakes.

if (WebViewFeature.isFeatureSupported(WebViewFeature.ALGORITHMIC_DARKENING))
{
Expand Down
Loading