Task/3 19 2026 json schema for filters extended edition (#1676)

* Save state post resolving conpilation bug :(

* Removing slide verify_params

* Adding some more json schema examples

* Adding a schema validator for flow filters

* Translating all filters in ascent_runtime_vtkh_filters to json schema format. Also adding additional validator constructs needed to complete this.

* Removing temporary helpers and cleaning up files

* Seed should be seeds

* adding a detail namespace to validator

* Converting over the expression filters

* converting another file

* Trying to add some support for expressions again

* Adding a way to pass our expression validator into the flow filter

* We have a valid expression checker!

* Integrating the expression checking into the vtkh number schemas :)

* Taking a pass at trying to get the JIT tests to pass

* Require that either field or topology be given for a threshold filter

* Converting more filters to new schema - tested

* Adding new template schemas to make further filter conversion possible

* Updating the param check and flow schema validator with additional capabilities

* Forgot to also add a type for integers

* Converting more filters to new schema - tested

* Converting more filters to new schema - tested

* rover filter schemas

* Adding dray filter schemas

* Adding schemas for rendering filters
(Also fixing a bug in the dray rendering filter :( )

* Last filter conversion over to json schema!!!

* cleaning up branch

Signed-off-by: Emily Howell <howell31@llnl.gov>

* Had AI generate an import check for optional that will work with c++11.

* Whopps. need to use it everywhere

* Cleaning up some errors

* Needed to add the pattern validation still

* Fixing adios2 error in CI

* Making sure that a compatable optional is used properly everywhere for backwards compatability to older versions of c++

* Fixing reflect filter

* Fixing spelling error

* Using refs to nodes instead of copying seperate nodes into tree

* Generalizing the expression checking to any format checking

* Applied formatting fixes

* Using refs to nodes instead of copying seperate nodes into tree for extended edition filters too

* const string ref vector

* removing the optional_params

* Removing print statement added for debugging

* Fixing the refrences in adios2 schema

* Formatting param check file

* Fixing typo

* Adding the minItem and maxItem array parameters to the array_schema helper

* Removing missed ignore schema in array schema conversion. By default, array schema elements are ignored unless a schema is provided.

* Adding small append fix to any of vecs. This was originally a change in the doc PR

* Removing s from schema

* Adding HDF5 example back

---------

Signed-off-by: Emily Howell <howell31@llnl.gov>

Author: emily-howell

src/libs/ascent/runtimes/expressions/ascent_expression_jit_filters.cpp

@@ -149,9 +149,7 @@ ExprJitFilter::declare_interface(Node &i)
   filters::string_schema(param_schema["properties/func"]);
   filters::string_schema(param_schema["properties/filter_name"]);
 
-  conduit::Node &inputs_schema = filters::array_schema(param_schema["properties/inputs"]);
-  inputs_schema["minItems"] = num_inputs;
-  inputs_schema["maxItems"] = num_inputs;
+  conduit::Node &inputs_schema = filters::array_schema(param_schema["properties/inputs"], conduit::Node(), num_inputs, num_inputs);
 
   param_schema["required"].append() = "func";
   param_schema["required"].append() = "filter_name";

src/libs/ascent/runtimes/flow_filters/ascent_runtime_adios2_filters.cpp

@@ -24,6 +24,7 @@
 //-----------------------------------------------------------------------------
 #include <ascent_runtime_utils.hpp>
 #include <ascent_string_utils.hpp>
+#include <ascent_runtime_param_check.hpp>
 #include <ascent_logging.hpp>
 #include <ascent_data_object.hpp>
 
@@ -114,43 +115,26 @@ ADIOS2::declare_interface(Node &i)
     i["type_name"]   = "adios2";
     i["port_names"].append() = "in";
     i["output_port"] = "false";
-}
 
-//-----------------------------------------------------------------------------
-bool
-ADIOS2::verify_params(const conduit::Node &params,
-                     conduit::Node &info)
-{
-  bool res = true;
-  if (!params.has_child("filename") ||
-      !params["filename"].dtype().is_string())
-  {
-    info["errors"].append() = "missing required entry 'filename'";
-    res = false;
-  }
+    // ----------- Define Param Schema -----------
+    conduit::Node &param_schema = i["param_schema"];
+    param_schema["type"] = "object";
 
-  if (!params.has_child("engine") ||
-      !params["engine"].dtype().is_string())
-  {
-    info["errors"].append() = "missing required entry 'engine'";
-    res = false;
-  }
+    string_schema(param_schema["properties/filename"]);
+    string_schema(param_schema["properties/engine"]);
 
-  std::string engineType = params["engine"].as_string();
-  if (engineType != "BPFile" && engineType != "SST")
-  {
-    info["errors"].append() = "unsupported engine type: " + engineType;
-    res = false;
-  }
+    conduit::Node &bpfile_schema = param_schema["oneOf"].append();
+    bpfile_schema["type"] = "object";
+    string_schema(bpfile_schema["properties/engine"]);
+    bpfile_schema["properties/engine/constraints/const"] = "BPFile";
 
-  std::string fileName = params["filename"].as_string();
-  if (engineType == "SST" && fileName.find("/") != std::string::npos )
-  {
-    info["errors"].append() = "filename with directory not supported for SST engine";
-    res = false;
-  }
+    conduit::Node &sst_schema = param_schema["oneOf"].append();
+    sst_schema["type"] = "object";
+    string_schema(sst_schema["properties/engine"]);
+    sst_schema["properties/engine/constraints/const"] = "SST";
 
-  return res;
+    conduit::Node &fname = string_schema(sst_schema["properties/filename"]);
+    fname["pattern"] = "^[^/]*$";
 }
 
 //-----------------------------------------------------------------------------

src/libs/ascent/runtimes/flow_filters/ascent_runtime_adios2_filters.hpp

@@ -52,8 +52,6 @@ class ADIOS2 : public ::flow::Filter
    ~ADIOS2();
 
     virtual void   declare_interface(conduit::Node &i);
-    virtual bool   verify_params(const conduit::Node &params,
-                                 conduit::Node &info);
     virtual void   execute();
 
 private:

src/libs/ascent/runtimes/flow_filters/ascent_runtime_babelflow_compose.cpp

@@ -42,23 +42,21 @@ void ascent::runtime::filters::BFlowCompose::declare_interface(conduit::Node &i)
   i["type_name"] = "bflow_comp";
   i["port_names"].append() = "in";
   i["output_port"] = "false";  // true -- means filter, false -- means extract
-}
-
-//-----------------------------------------------------------------------------
-
-bool ascent::runtime::filters::BFlowCompose::verify_params(const conduit::Node &params, conduit::Node &info)
-{
-  info.reset();
 
-  bool res = true;
+  // ----------- Define Param Schema -----------
+  conduit::Node &param_schema = i["param_schema"];
+  param_schema["type"] = "object";
 
-  res &= check_string("color_field", params, info, true);
-  res &= check_string("depth_field", params, info, true);
-  res &= check_string("image_prefix", params, info, true);
-  res &= check_numeric("compositing", params, info, true);
-  res &= check_numeric("fanin", params, info, false);
+  string_schema(param_schema["properties/color_field"]);
+  string_schema(param_schema["properties/depth_field"]);
+  string_schema(param_schema["properties/image_prefix"]);
+  number_schema(param_schema["properties/compositing"]);
+  number_schema(param_schema["properties/fanin"]);
 
-  return res;
+  param_schema["required"].append() = "color_field";
+  param_schema["required"].append() = "depth_field";
+  param_schema["required"].append() = "image_prefix";
+  param_schema["required"].append() = "compositing";
 }
 
 //-----------------------------------------------------------------------------

src/libs/ascent/runtimes/flow_filters/ascent_runtime_babelflow_filters.hpp

@@ -37,8 +37,6 @@ class BFlowPmt : public ::flow::Filter
     virtual ~BFlowPmt() {}
 
     virtual void   declare_interface(conduit::Node &i) override;
-    virtual bool   verify_params(const conduit::Node &params,
-                                 conduit::Node &info) override;
     virtual void   execute() override;
 };
 
@@ -53,8 +51,6 @@ class BFlowCompose : public ::flow::Filter
     virtual ~BFlowCompose() {}
 
     virtual void   declare_interface(conduit::Node &i) override;
-    virtual bool   verify_params(const conduit::Node &params,
-                                 conduit::Node &info) override;
     virtual void   execute() override;
 };
 
@@ -67,8 +63,6 @@ class BFlowIso : public ::flow::Filter
     virtual ~BFlowIso() {}
 
     virtual void   declare_interface(conduit::Node &i) override;
-    virtual bool   verify_params(const conduit::Node &params,
-                                 conduit::Node &info) override;
     virtual void   execute() override;
 };
 

src/libs/ascent/runtimes/flow_filters/ascent_runtime_babelflow_iso.cpp

@@ -530,25 +530,21 @@ void ascent::runtime::filters::BFlowIso::declare_interface(conduit::Node &i)
   i["type_name"] = "bflow_iso";
   i["port_names"].append() = "in";
   i["output_port"] = "false";  // true -- means filter, false -- means extract
-}
 
-//-----------------------------------------------------------------------------
+  // ----------- Define Param Schema -----------
+  conduit::Node &param_schema = i["param_schema"];
+  param_schema["type"] = "object";
 
-bool ascent::runtime::filters::BFlowIso::verify_params(const conduit::Node &params, conduit::Node &info) 
-{
-  info.reset();
+  string_schema(param_schema["properties/field"]);
+  number_schema(param_schema["properties/iso_values"]);
+  string_schema(param_schema["properties/image_name"]);
+  number_schema(param_schema["properties/radices"]);
+  number_schema(param_schema["properties/width"]);
+  number_schema(param_schema["properties/height"]);
 
-  bool res = true;
-
-  res &= check_string("field", params, info, true);
-  res &= check_numeric("iso_values", params, info, true);
-  res &= check_string("image_name", params, info, true);
-  res &= check_numeric("radices", params, info, false);
-  res &= check_numeric("width", params, info, false);
-  res &= check_numeric("height", params, info, false);
-  // res &= check_string("col_field", params, info, true);
-  
-  return res;
+  param_schema["required"].append() = "field";
+  param_schema["required"].append() = "iso_values";
+  param_schema["required"].append() = "image_name";
 }
 
 //-----------------------------------------------------------------------------

src/libs/ascent/runtimes/flow_filters/ascent_runtime_babelflow_pmt.cpp

@@ -1464,6 +1464,21 @@ void ascent::runtime::filters::BFlowPmt::declare_interface(conduit::Node &i)
   i["type_name"] = "bflow_pmt";
   i["port_names"].append() = "in";
   i["output_port"] = "true";  // true -- means filter, false -- means extract
+
+  // ----------- Define Param Schema -----------
+  conduit::Node &param_schema = i["param_schema"];
+  param_schema["type"] = "object";
+
+  string_schema(param_schema["properties/field"]);
+  number_schema(param_schema["properties/fanin"]);
+  number_schema(param_schema["properties/threshold"]);
+  number_schema(param_schema["properties/gen_segment"]);
+  number_schema(param_schema["properties/ugrid_select"]);
+
+  param_schema["required"].append() = "field";
+  param_schema["required"].append() = "fanin";
+  param_schema["required"].append() = "threshold";
+  param_schema["required"].append() = "gen_segment";
 }
 
 //-----------------------------------------------------------------------------
@@ -1847,20 +1862,3 @@ void ascent::runtime::filters::BFlowPmt::execute()
 
   set_output<DataObject>(d_input);
 }
-
-//-----------------------------------------------------------------------------
-
-bool ascent::runtime::filters::BFlowPmt::verify_params(const conduit::Node &params, conduit::Node &info) 
-{
-  info.reset();
-
-  bool res = true;
-
-  res &= check_string("field", params, info, true);
-  res &= check_numeric("fanin", params, info, true);
-  res &= check_numeric("threshold", params, info, true);
-  res &= check_numeric("gen_segment", params, info, true);
-  res &= check_numeric("ugrid_select", params, info, false);
-  
-  return res;
-}