update to use viskores 1.1.1 #1692
Open
nicolemarsaglia wants to merge 28 commits into
Open
Conversation
…r volume render (i.e. with control points)
…on_occlusion.patch old patch with second buffer. went with a more straightforward hack
Member
|
Something is different on windows with this new version, we hitting a linker limit: |
…b.com/Alpine-DAV/ascent into task/2026_04_09_update_viskores_1.1.0
Member
|
@nicolemarsaglia |
Contributor
Author
boo I will take a look! |
Contributor
Author
|
@cyrus fixed patch issue. now it's failing on the test i added a new baseline image for. I'll investigate more tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires a patch for viskores to fix a bug involving pseudocolor plots that are using control points and becoming volume renders, the annotation boundary would overwrite the data.
Viskores changed their depth buffer to track and advance the ray step/traversal and we need a depth buffer to keep track of the depth of the first hit of a ray.