-
Notifications
You must be signed in to change notification settings - Fork 77
Add topology as sample filter input #1728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nicolemarsaglia
wants to merge
10
commits into
develop
Choose a base branch
from
task/2026_05_19_sample_topology
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
60789a2
fix plane unit test
nicolemarsaglia a523e1d
add topology sampler
nicolemarsaglia 38dee00
edits and add comments
nicolemarsaglia 052be17
edits
nicolemarsaglia 22a1eec
Merge branch 'develop' into task/2026_05_19_sample_topology
nicolemarsaglia 1a8539e
spacing fixes
nicolemarsaglia 6d1441b
Merge branch 'task/2026_05_19_sample_topology' of https://github.com/…
nicolemarsaglia c6a52e4
Merge branch 'develop' into task/2026_05_19_sample_topology
nicolemarsaglia 3c27ed8
add baseline images for plane and sphere topology sample unit test. r…
nicolemarsaglia 11e4153
forgot baseline images
nicolemarsaglia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
src/docs/sphinx/Actions/examples/tout_sample_topology_plane_000100.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| #An example of using the sample filter to sample on a topology from the input dataset. | ||
|
|
||
| - | ||
| action: "add_pipelines" | ||
| pipelines: | ||
| pl1: | ||
| f1: | ||
| type: "sample" | ||
| params: | ||
| fields: | ||
| - "braid" | ||
| topology: "sample_plane" | ||
| invalid_value: -10.0 | ||
| - | ||
| action: "add_extracts" | ||
| extracts: | ||
| e1: | ||
| pipeline: "pl1" | ||
| type: "relay" | ||
| params: | ||
| protocol: "hdf5" | ||
| path: "/usr/WS1/nicolem/sadbox/ascent/scripts/build_ascent/build/ascent-checkout/tests/_output/tout_sample_topology_plane" |
22 changes: 22 additions & 0 deletions
22
src/docs/sphinx/Actions/examples/tout_sample_topology_sphere_000100.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| #An example of using the sample filter to sample on a sphere surface topology from the input dataset. | ||
|
|
||
| - | ||
| action: "add_pipelines" | ||
| pipelines: | ||
| pl1: | ||
| f1: | ||
| type: "sample" | ||
| params: | ||
| fields: | ||
| - "braid" | ||
| topology: "sample_sphere" | ||
| invalid_value: -10.0 | ||
| - | ||
| action: "add_extracts" | ||
| extracts: | ||
| e1: | ||
| pipeline: "pl1" | ||
| type: "relay" | ||
| params: | ||
| protocol: "hdf5" | ||
| path: "/usr/WS1/nicolem/sadbox/ascent/scripts/build_ascent/build/ascent-checkout/tests/_output/tout_sample_topology_sphere" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍