Nuxt UI migration#322
Draft
rschlossarek wants to merge 26 commits into
Draft
Conversation
Happy toasting everybody
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Comment on lines
+859
to
+861
| if (!wiederholungEdit.Person.HasValue) tutor = null; | ||
| else | ||
| tutor = await _userService.GetUserByIdAsync(wiederholungEdit.Person.Value); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since PrimeVue v5 is getting paid https://primeui.dev/nextchapter and v4 does not seem to be supported anymore (https://github.com/primefaces/primevue is archived) we will need to migrate to another frontend library.
We should probably be do this incrementally. This will be a migration of the core components and layout as well as the otium and profundum feedback modules.
@JohannHoepfner The profundum module should be migrated at a later time, maybe along with #283 or #284 as not to do immediately obsoleted work
For the same reason the dashboards will not be migrated in this pr (see #288 and #285)
We will also fix some ts errors with this pr as the double tsconfig ans jsconfig we currently use complicate the migration, so I intend to remove the jsconfig.