fix: always show check examples, filter tests from DAG properly

- Always show example patterns in "How" column (SELECT *, cartesian
  joins, ...) — even when findings exist, this shows value
- Filter test nodes from downstream in getDownstreamModels (check
  node ID prefix "test.") instead of relying on name heuristics
- Expand isTestNode to catch singular tests (assert_*, test_*)
- Fix test assertion for always-show examples

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: anandgupta42

dist/index.js

@@ -24384,7 +24384,9 @@ function buildQueryProfile(profiles) {
   return lines.join("\n");
 }
 function isTestNode(name) {
-  return /^(not_null|unique|accepted_values|relationships|dbt_utils|dbt_expectations)_/.test(name);
+  if (/^(not_null|unique|accepted_values|relationships|dbt_utils|dbt_expectations)_/.test(name)) return true;
+  if (/^(assert|test)_/.test(name)) return true;
+  return false;
 }
 function buildMermaidDAG(impact) {
   const filteredDownstream = impact.downstreamModels.filter((d) => !isTestNode(d));
@@ -27702,9 +27704,10 @@ function extractValidationSummary(output) {
     const findingsCount = result?.findings?.length ?? 0;
     if (meta) {
       const methodWithContext = check === "validate" && schemaResolved && output.files_checked > 0 ? `${meta.method} against ${output.files_checked} table schemas` : meta.method;
+      const methodDisplay = meta.examples.length > 0 ? `${methodWithContext}: ${meta.examples.join(", ")}` : methodWithContext;
       categories[check] = {
         label: meta.ruleCount > 0 ? `${meta.label} (${meta.ruleCount} rules)` : meta.label,
-        method: findingsCount === 0 && meta.examples.length > 0 ? `${methodWithContext}: ${meta.examples.join(", ")}, ...` : methodWithContext,
+        method: methodDisplay,
         rulesChecked: meta.ruleCount,
         findingsCount,
         passed: findingsCount === 0
@@ -28856,7 +28859,9 @@ function getDownstreamModels(modelIds, manifest) {
     for (const child of children) {
       if (!visited.has(child)) {
         visited.add(child);
-        downstream.push(child);
+        if (!child.startsWith("test.")) {
+          downstream.push(child);
+        }
         queue.push(child);
       }
     }

dist/index.js.map

@@ -189,12 +189,16 @@ export function extractValidationSummary(output: CheckOutput): ValidationSummary
           ? `${meta.method} against ${output.files_checked} table schemas`
           : meta.method;
 
+      // Always show example patterns in the "How" column — this demonstrates
+      // what we checked even when everything passes
+      const methodDisplay =
+        meta.examples.length > 0
+          ? `${methodWithContext}: ${meta.examples.join(", ")}`
+          : methodWithContext;
+
       categories[check] = {
         label: meta.ruleCount > 0 ? `${meta.label} (${meta.ruleCount} rules)` : meta.label,
-        method:
-          findingsCount === 0 && meta.examples.length > 0
-            ? `${methodWithContext}: ${meta.examples.join(", ")}, ...`
-            : methodWithContext,
+        method: methodDisplay,
         rulesChecked: meta.ruleCount,
         findingsCount,
         passed: findingsCount === 0,

src/analysis/cli-check.ts

@@ -171,8 +171,12 @@ export function getDownstreamModels(modelIds: string[], manifest: DBTManifest):
     for (const child of children) {
       if (!visited.has(child)) {
         visited.add(child);
-        downstream.push(child);
-        queue.push(child);
+        // Only include models, snapshots, and analyses — not tests
+        // dbt node IDs follow the format: resource_type.project.name
+        if (!child.startsWith("test.")) {
+          downstream.push(child);
+        }
+        queue.push(child); // Still traverse through tests to find models beyond them
       }
     }
   }

src/context/dbt.ts

@@ -367,7 +367,11 @@ export function buildQueryProfile(profiles: QueryProfile[]): string {
  * accepted_values_model_col__val1__val2, relationships_model_col__ref_other_
  */
 function isTestNode(name: string): boolean {
-  return /^(not_null|unique|accepted_values|relationships|dbt_utils|dbt_expectations)_/.test(name);
+  // Standard dbt generic tests
+  if (/^(not_null|unique|accepted_values|relationships|dbt_utils|dbt_expectations)_/.test(name)) return true;
+  // Singular tests (typically start with "assert_" or "test_")
+  if (/^(assert|test)_/.test(name)) return true;
+  return false;
 }
 
 /**

src/reporting/comment.ts

@@ -552,8 +552,8 @@ describe("extractValidationSummary", () => {
 
     expect(summary.categories.lint.passed).toBe(false);
     expect(summary.categories.lint.findingsCount).toBe(2);
-    // When findings exist, method should NOT include examples
-    expect(summary.categories.lint.method).toBe("AST analysis");
+    // Examples are always shown to demonstrate what was checked
+    expect(summary.categories.lint.method).toContain("AST analysis");
   });
 
   it("includes schema resolution info for validate category", () => {