fix: [AI-5975] guard finding arrays with Array.isArray for defensive safety

If a dispatcher returns a non-array for `errors`, `violations`, `issues`,
or `changes`, the `?? []` fallback handles null/undefined but not other
types. `Array.isArray` prevents `.map()` from throwing on unexpected payloads.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: suryaiyer95

packages/opencode/src/altimate/tools/altimate-core-correct.ts

@@ -22,7 +22,8 @@ export const AltimateCoreCorrectTool = Tool.define("altimate_core_correct", {
       const data = (result.data ?? {}) as Record<string, any>
       const error = result.error ?? data.error ?? extractCorrectErrors(data)
       // altimate_change start — sql quality findings for telemetry
-      const findings: Telemetry.Finding[] = (data.changes ?? []).map(() => ({
+      const changes = Array.isArray(data.changes) ? data.changes : []
+      const findings: Telemetry.Finding[] = changes.map(() => ({
         category: "correction_applied",
       }))
       // altimate_change end

packages/opencode/src/altimate/tools/altimate-core-policy.ts

@@ -24,7 +24,8 @@ export const AltimateCorePolicyTool = Tool.define("altimate_core_policy", {
       const data = (result.data ?? {}) as Record<string, any>
       const error = result.error ?? data.error
       // altimate_change start — sql quality findings for telemetry
-      const findings: Telemetry.Finding[] = (data.violations ?? []).map((v: any) => ({
+      const violations = Array.isArray(data.violations) ? data.violations : []
+      const findings: Telemetry.Finding[] = violations.map((v: any) => ({
         category: v.rule ?? "policy_violation",
       }))
       // altimate_change end

packages/opencode/src/altimate/tools/altimate-core-semantics.ts

@@ -28,7 +28,8 @@ export const AltimateCoreSemanticsTool = Tool.define("altimate_core_semantics",
       const error = result.error ?? data.error ?? extractSemanticsErrors(data)
       const hasError = Boolean(error)
       // altimate_change start — sql quality findings for telemetry
-      const findings: Telemetry.Finding[] = (data.issues ?? []).map(() => ({
+      const issues = Array.isArray(data.issues) ? data.issues : []
+      const findings: Telemetry.Finding[] = issues.map(() => ({
         category: "semantic_issue",
       }))
       // altimate_change end

packages/opencode/src/altimate/tools/altimate-core-validate.ts

@@ -27,7 +27,8 @@ export const AltimateCoreValidateTool = Tool.define("altimate_core_validate", {
       const data = (result.data ?? {}) as Record<string, any>
       const error = result.error ?? data.error ?? extractValidationErrors(data)
       // altimate_change start — sql quality findings for telemetry
-      const findings: Telemetry.Finding[] = (data.errors ?? []).map((err: any) => ({
+      const errors = Array.isArray(data.errors) ? data.errors : []
+      const findings: Telemetry.Finding[] = errors.map((err: any) => ({
         category: classifyValidationError(err.message ?? ""),
       }))
       // altimate_change end