Skip to content

Commit 2e784dd

Browse files
anandgupta42claude
andcommitted
fix: address CodeRabbit review — Nivo description + marker guard
- Correct Nivo `Responsive*` behavior: `ResizeObserver` does re-fire when container becomes visible, not "never re-fires on show" - Add `altimate_change` marker around `installedVersion` banner line Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 3879ef8 commit 2e784dd

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

.opencode/skills/data-viz/references/component-guide.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ activateTab('overview'); // init the default visible tab on page load
422422
Library-specific notes:
423423
- **Chart.js**: canvas reads as `0×0` inside `display:none` — bars/lines never appear
424424
- **Recharts `ResponsiveContainer`**: reads `clientWidth = 0` — chart collapses to nothing
425-
- **Nivo `Responsive*`**: uses `ResizeObserver` — fires once at `0×0`, never re-fires on show
425+
- **Nivo `Responsive*`**: uses `ResizeObserver` via `useMeasure`/`useDimensions` in `@nivo/core` — initially measures `0×0` when hidden and skips rendering; re-measures and re-renders correctly when container becomes visible, but the initial blank frame can cause a flash
426426
- **React conditional rendering**: prefer `visibility:hidden` + `position:absolute` over toggling `display:none` if you want charts to stay mounted and pre-rendered
427427

428428
---

packages/opencode/src/cli/welcome.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,9 @@ export function showWelcomeBannerIfNeeded(): void {
6767
const reset = "\x1b[0m"
6868
const bold = "\x1b[1m"
6969

70+
// altimate_change start — use installedVersion (from marker) instead of currentVersion for accurate banner
7071
const v = `altimate-code v${installedVersion} installed`
72+
// altimate_change end
7173
const lines = [
7274
"",
7375
" Get started:",

0 commit comments

Comments
 (0)