fix: sql_analyze reports "unknown error" for successful analyses (AI-5975) (#426)

sql.analyze returned success:false when it found lint/semantic/safety
issues, causing telemetry to log ~4,000 false "unknown error" failures
per day. Finding issues IS a successful analysis.

- Change success flag to true when analysis completes without exceptions
- Surface actual error messages to metadata.error so telemetry can
  distinguish real failures from successful analyses

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: anandgupta42 <93243293+anandgupta42@users.noreply.github.com>

Author: 3 people

packages/opencode/src/altimate/native/sql/register.ts

@@ -75,7 +75,7 @@ register("sql.analyze", async (params) => {
     }
 
     return {
-      success: issues.length === 0,
+      success: true,
       issues,
       issue_count: issues.length,
       confidence: "high",

packages/opencode/src/altimate/tools/sql-analyze.ts

@@ -22,19 +22,20 @@ export const SqlAnalyzeTool = Tool.define("sql_analyze", {
       })
 
       return {
-        title: `Analyze: ${result.success ? `${result.issue_count} issue${result.issue_count !== 1 ? "s" : ""}` : "PARSE ERROR"} [${result.confidence}]`,
+        title: `Analyze: ${result.error ? "PARSE ERROR" : `${result.issue_count} issue${result.issue_count !== 1 ? "s" : ""}`} [${result.confidence}]`,
         metadata: {
           success: result.success,
           issueCount: result.issue_count,
           confidence: result.confidence,
+          ...(result.error && { error: result.error }),
         },
         output: formatAnalysis(result),
       }
     } catch (e) {
       const msg = e instanceof Error ? e.message : String(e)
       return {
         title: "Analyze: ERROR",
-        metadata: { success: false, issueCount: 0, confidence: "unknown" },
+        metadata: { success: false, issueCount: 0, confidence: "unknown", error: msg },
         output: `Failed to analyze SQL: ${msg}\n\nCheck your connection configuration and try again.`,
       }
     }