fix: address new Sentry findings — regex m flag and off-by-one budget check

1. formatTrainingEntry regex: remove multiline `m` flag that could
   match user content mid-string (memory/prompt.ts:82)

2. Memory block budget check: change `<` to `<=` so blocks that fit
   exactly into remaining budget are included (memory/prompt.ts:204)

3 prior Sentry findings already fixed in earlier commits:
   - projectDir cache (Map keyed by Instance.directory)
   - injectTrainingOnly header-only return (itemCount guard)
   - orphaned section headers (first-entry pre-check)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: anandgupta42

packages/opencode/.github/meta/commit.txt

@@ -1,10 +1,16 @@
-fix: CI failure + new Sentry finding — orphaned headers and agent test
+fix: address multi-model code review findings
 
-1. Agent test: add researcher + trainer to "all disabled" test so it
-   correctly expects "no primary visible agent" when ALL agents are off
+Fixes from 6-model consensus review (Claude + GPT + Gemini + Kimi + MiniMax + GLM-5):
 
-2. Orphaned section headers: add pre-check that at least one entry fits
-   before adding section header in both injectTrainingOnly and inject
-   memory section (prevents header-only output inflating budget reports)
+1. training_remove: add name validation regex matching training_save
+   (Gemini finding — prevents path traversal via malformed names)
+
+2. training_save: improve name transform to strip ALL non-alphanumeric
+   chars, not just whitespace (Gemini finding — "don't-use-float!"
+   now becomes "don-t-use-float" instead of failing regex)
+
+3. incrementApplied: replace silent `.catch(() => {})` with warning
+   log (Kimi + GLM-5 consensus — fire-and-forget is by design but
+   failures should be visible in logs for debugging)
 
 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

packages/opencode/src/memory/prompt.ts

@@ -79,7 +79,7 @@ export namespace MemoryPrompt {
     const meta = parseTrainingMeta(block.content)
     const appliedStr = meta && meta.applied > 0 ? ` (applied ${meta.applied}x)` : ""
     // Strip the training metadata comment from content for display
-    const content = block.content.replace(/^<!--\s*training\n[\s\S]*?-->\n*/m, "").trim()
+    const content = block.content.replace(/^<!--\s*training\n[\s\S]*?-->\n*/, "").trim()
     const name = block.id.split("/").slice(2).join("/") || block.id
     return `#### ${name}${appliedStr}\n${content}`
   }
@@ -201,7 +201,7 @@ export namespace MemoryPrompt {
     if (memoryBlocks.length > 0) {
       const memHeader = "\n### Memory\n"
       const firstMemFormatted = formatBlock(memoryBlocks[0].block)
-      if (used + memHeader.length + firstMemFormatted.length + 2 < budget) {
+      if (used + memHeader.length + firstMemFormatted.length + 2 <= budget) {
         result += memHeader
         used += memHeader.length