fix: address code review findings in feedback-submit tool

- Fix misleading error: `gh auth status` catch now returns `gh_auth_check_failed`
  instead of `gh_not_installed` (gh IS installed at that point)
- Fix fragile version check: use `startsWith("gh version")` instead of
  `includes("not found")` for cross-platform correctness
- Add `trim().min(1)` validation to `title` and `description` zod schemas
  to reject empty/whitespace-only inputs
- Check `issueResult.exitCode !== 0` before stdout URL check on issue creation
- Restore `Bun.$` in `afterAll` to prevent mock leaking across test files
- Remove trailing `$ARGUMENTS` from end of feedback.txt template (duplicated
  from Step 1 pre-fill logic; could confuse model)
- Add 8 new tests: empty/whitespace validation, `gh_auth_check_failed` path,
  non-zero exitCode with stdout scenario, and updated "not found" test name

Author: anandgupta42

packages/opencode/src/altimate/tools/feedback-submit.ts

@@ -19,11 +19,11 @@ export const FeedbackSubmitTool = Tool.define("feedback_submit", {
     "Creates an issue with appropriate labels and metadata. " +
     "Requires the `gh` CLI to be installed and authenticated.",
   parameters: z.object({
-    title: z.string().describe("A concise title for the feedback issue"),
+    title: z.string().trim().min(1).describe("A concise title for the feedback issue"),
     category: z
       .enum(["bug", "feature", "improvement", "ux"])
       .describe("The category of feedback: bug, feature, improvement, or ux"),
-    description: z.string().describe("Detailed description of the feedback"),
+    description: z.string().trim().min(1).describe("Detailed description of the feedback"),
     include_context: z
       .boolean()
       .optional()
@@ -50,7 +50,7 @@ export const FeedbackSubmitTool = Tool.define("feedback_submit", {
       // ENOENT — gh binary not found on PATH
       return ghNotInstalled
     }
-    if (!ghVersion || ghVersion.includes("not found")) {
+    if (!ghVersion.trim().startsWith("gh version")) {
       return ghNotInstalled
     }
 
@@ -59,7 +59,13 @@ export const FeedbackSubmitTool = Tool.define("feedback_submit", {
     try {
       authStatus = await Bun.$`gh auth status`.quiet().nothrow()
     } catch {
-      return ghNotInstalled
+      return {
+        title: "Feedback submission failed",
+        metadata: { error: "gh_auth_check_failed", issueUrl: "" },
+        output:
+          "Failed to verify `gh` authentication status. Please check your installation with:\n" +
+          "  `gh auth status`",
+      }
     }
     if (authStatus.exitCode !== 0) {
       return {
@@ -114,7 +120,7 @@ export const FeedbackSubmitTool = Tool.define("feedback_submit", {
     const stdout = issueResult.stdout.toString().trim()
     const stderr = issueResult.stderr.toString().trim()
 
-    if (!stdout || !stdout.includes("github.com")) {
+    if (issueResult.exitCode !== 0 || !stdout || !stdout.includes("github.com")) {
       const errorDetail = stderr || stdout || "No output from gh CLI"
       return {
         title: "Feedback submission failed",

packages/opencode/src/command/template/feedback.txt

@@ -40,5 +40,3 @@ Ask the user to confirm. If they confirm, call the `feedback_submit` tool with:
 Step 4 — Show result:
 
 After submission, display the created GitHub issue URL to the user so they can track it. Thank them for the feedback.
-
-$ARGUMENTS

packages/opencode/test/tool/feedback-submit.test.ts

@@ -1,4 +1,4 @@
-import { describe, expect, test, beforeEach } from "bun:test"
+import { describe, expect, test, beforeEach, afterAll } from "bun:test"
 import Bun from "bun"
 
 // ---------------------------------------------------------------------------
@@ -33,6 +33,11 @@ function pushShellThrow() {
 // replacing it here means dynamically imported modules will pick up our mock.
 // ---------------------------------------------------------------------------
 
+const originalBunShell = Bun.$
+afterAll(() => {
+  Bun.$ = originalBunShell
+})
+
 Bun.$ = function mockedShell(strings: TemplateStringsArray, ...values: any[]) {
   const parts: string[] = []
   strings.forEach((s, i) => {
@@ -155,6 +160,46 @@ describe("tool.feedback_submit", () => {
       }
     })
 
+    test("rejects empty title", async () => {
+      const tool = await FeedbackSubmitTool.init()
+      const result = tool.parameters.safeParse({
+        title: "",
+        category: "bug",
+        description: "test",
+      })
+      expect(result.success).toBe(false)
+    })
+
+    test("rejects whitespace-only title", async () => {
+      const tool = await FeedbackSubmitTool.init()
+      const result = tool.parameters.safeParse({
+        title: "   ",
+        category: "bug",
+        description: "test",
+      })
+      expect(result.success).toBe(false)
+    })
+
+    test("rejects empty description", async () => {
+      const tool = await FeedbackSubmitTool.init()
+      const result = tool.parameters.safeParse({
+        title: "Test",
+        category: "bug",
+        description: "",
+      })
+      expect(result.success).toBe(false)
+    })
+
+    test("rejects whitespace-only description", async () => {
+      const tool = await FeedbackSubmitTool.init()
+      const result = tool.parameters.safeParse({
+        title: "Test",
+        category: "bug",
+        description: "   ",
+      })
+      expect(result.success).toBe(false)
+    })
+
     test("rejects missing title", async () => {
       const tool = await FeedbackSubmitTool.init()
       const result = tool.parameters.safeParse({
@@ -240,7 +285,7 @@ describe("tool.feedback_submit", () => {
       expect(result.output).toContain("gh auth login")
     })
 
-    test("returns error when gh --version output contains 'not found'", async () => {
+    test("returns error when gh --version output does not start with 'gh version'", async () => {
       const tool = await FeedbackSubmitTool.init()
 
       pushShellResult("command not found: gh")
@@ -280,6 +325,35 @@ describe("tool.feedback_submit", () => {
     })
   })
 
+  // -------------------------------------------------------------------------
+  // gh auth status throws
+  // -------------------------------------------------------------------------
+
+  describe("gh auth status throws", () => {
+    test("returns gh_auth_check_failed (not gh_not_installed) when auth check throws", async () => {
+      const tool = await FeedbackSubmitTool.init()
+
+      // gh --version succeeds
+      pushShellResult("gh version 2.40.0")
+      // gh auth status throws
+      pushShellThrow()
+
+      const result = await tool.execute(
+        {
+          title: "Test",
+          category: "bug" as const,
+          description: "test",
+          include_context: false,
+        },
+        ctx,
+      )
+
+      expect(result.title).toBe("Feedback submission failed")
+      expect(result.metadata.error).toBe("gh_auth_check_failed")
+      expect(result.output).toContain("gh auth status")
+    })
+  })
+
   // -------------------------------------------------------------------------
   // gh CLI not authenticated
   // -------------------------------------------------------------------------
@@ -392,6 +466,28 @@ describe("tool.feedback_submit", () => {
       expect(result.metadata.error).toBe("issue_creation_failed")
     })
 
+    test("returns failure when issue creation has non-zero exitCode even with stdout", async () => {
+      const tool = await FeedbackSubmitTool.init()
+
+      pushShellResult("gh version 2.40.0")
+      pushShellResult("Logged in", 0)
+      // gh issue create exits non-zero (e.g. label doesn't exist) with partial output
+      shellResults.push({ text: "https://github.com/AltimateAI/altimate-code/issues/1", exitCode: 1 })
+
+      const result = await tool.execute(
+        {
+          title: "Test",
+          category: "bug" as const,
+          description: "test",
+          include_context: false,
+        },
+        ctx,
+      )
+
+      expect(result.title).toBe("Feedback submission failed")
+      expect(result.metadata.error).toBe("issue_creation_failed")
+    })
+
     test("returns failure when issue creation throws", async () => {
       const tool = await FeedbackSubmitTool.init()