refactor: [AI-5975] remove hardcoded dialect: "snowflake" from core tools

- Remove `dialect` from metadata in 8 altimate-core/impact tools that don't
  accept a dialect parameter (it was always hardcoded to "snowflake")
- Make `dialect` optional in `sql_quality` telemetry event type
- Only emit `dialect` when the tool actually provides it (sql-analyze,
  sql-optimize, schema-diff still do via `args.dialect`)
- Tracked as #455 for adding proper dialect parameter support later

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: suryaiyer95

packages/opencode/src/altimate/telemetry/index.ts

@@ -416,7 +416,7 @@ export namespace Telemetry {
         /** JSON-encoded Record<string, number> — count per issue category */
         by_category: string
         has_schema: boolean
-        dialect: string
+        dialect?: string
         duration_ms: number
       }
     // altimate_change end

packages/opencode/src/altimate/tools/altimate-core-check.ts

@@ -41,15 +41,14 @@ export const AltimateCoreCheckTool = Tool.define("altimate_core_check", {
         metadata: {
           success: result.success,
           has_schema: hasSchema,
-          dialect: "snowflake",
           ...(error && { error }),
           ...(findings.length > 0 && { findings }),
         },
         output: formatCheck(data),
       }
     } catch (e) {
       const msg = e instanceof Error ? e.message : String(e)
-      return { title: "Check: ERROR", metadata: { success: false, has_schema: hasSchema, dialect: "snowflake", error: msg }, output: `Failed: ${msg}` }
+      return { title: "Check: ERROR", metadata: { success: false, has_schema: hasSchema, error: msg }, output: `Failed: ${msg}` }
     }
   },
 })

packages/opencode/src/altimate/tools/altimate-core-correct.ts

@@ -32,15 +32,14 @@ export const AltimateCoreCorrectTool = Tool.define("altimate_core_correct", {
           success: result.success,
           iterations: data.iterations,
           has_schema: hasSchema,
-          dialect: "snowflake",
           ...(error && { error }),
           ...(findings.length > 0 && { findings }),
         },
         output: formatCorrect(data),
       }
     } catch (e) {
       const msg = e instanceof Error ? e.message : String(e)
-      return { title: "Correct: ERROR", metadata: { success: false, iterations: 0, has_schema: hasSchema, dialect: "snowflake", error: msg }, output: `Failed: ${msg}` }
+      return { title: "Correct: ERROR", metadata: { success: false, iterations: 0, has_schema: hasSchema, error: msg }, output: `Failed: ${msg}` }
     }
   },
 })

packages/opencode/src/altimate/tools/altimate-core-equivalence.ts

@@ -16,7 +16,7 @@ export const AltimateCoreEquivalenceTool = Tool.define("altimate_core_equivalenc
     const hasSchema = !!(args.schema_path || (args.schema_context && Object.keys(args.schema_context).length > 0))
     if (!hasSchema) {
       const error = "No schema provided. Provide schema_context or schema_path so table/column references can be resolved."
-      return { title: "Equivalence: NO SCHEMA", metadata: { success: false, equivalent: false, has_schema: false, dialect: "snowflake", error }, output: `Error: ${error}` }
+      return { title: "Equivalence: NO SCHEMA", metadata: { success: false, equivalent: false, has_schema: false, error }, output: `Error: ${error}` }
     }
     try {
       const result = await Dispatcher.call("altimate_core.equivalence", {
@@ -44,15 +44,14 @@ export const AltimateCoreEquivalenceTool = Tool.define("altimate_core_equivalenc
           success: !isRealFailure,
           equivalent: data.equivalent,
           has_schema: hasSchema,
-          dialect: "snowflake",
           ...(error && { error }),
           ...(findings.length > 0 && { findings }),
         },
         output: formatEquivalence(data),
       }
     } catch (e) {
       const msg = e instanceof Error ? e.message : String(e)
-      return { title: "Equivalence: ERROR", metadata: { success: false, equivalent: false, has_schema: hasSchema, dialect: "snowflake", error: msg }, output: `Failed: ${msg}` }
+      return { title: "Equivalence: ERROR", metadata: { success: false, equivalent: false, has_schema: hasSchema, error: msg }, output: `Failed: ${msg}` }
     }
   },
 })

packages/opencode/src/altimate/tools/altimate-core-fix.ts

@@ -41,15 +41,14 @@ export const AltimateCoreFixTool = Tool.define("altimate_core_fix", {
           success,
           fixed: !!data.fixed_sql,
           has_schema: hasSchema,
-          dialect: "snowflake",
           ...(error && { error }),
           ...(findings.length > 0 && { findings }),
         },
         output: formatFix(data),
       }
     } catch (e) {
       const msg = e instanceof Error ? e.message : String(e)
-      return { title: "Fix: ERROR", metadata: { success: false, fixed: false, has_schema: hasSchema, dialect: "snowflake", error: msg }, output: `Failed: ${msg}` }
+      return { title: "Fix: ERROR", metadata: { success: false, fixed: false, has_schema: hasSchema, error: msg }, output: `Failed: ${msg}` }
     }
   },
 })

packages/opencode/src/altimate/tools/altimate-core-policy.ts

@@ -34,15 +34,14 @@ export const AltimateCorePolicyTool = Tool.define("altimate_core_policy", {
           success: true, // engine ran — violations are findings, not failures
           pass: data.pass,
           has_schema: hasSchema,
-          dialect: "snowflake",
           ...(error && { error }),
           ...(findings.length > 0 && { findings }),
         },
         output: formatPolicy(data),
       }
     } catch (e) {
       const msg = e instanceof Error ? e.message : String(e)
-      return { title: "Policy: ERROR", metadata: { success: false, pass: false, has_schema: hasSchema, dialect: "snowflake", error: msg }, output: `Failed: ${msg}` }
+      return { title: "Policy: ERROR", metadata: { success: false, pass: false, has_schema: hasSchema, error: msg }, output: `Failed: ${msg}` }
     }
   },
 })

packages/opencode/src/altimate/tools/altimate-core-semantics.ts

@@ -15,7 +15,7 @@ export const AltimateCoreSemanticsTool = Tool.define("altimate_core_semantics",
     const hasSchema = !!(args.schema_path || (args.schema_context && Object.keys(args.schema_context).length > 0))
     if (!hasSchema) {
       const error = "No schema provided. Provide schema_context or schema_path so table/column references can be resolved."
-      return { title: "Semantics: NO SCHEMA", metadata: { success: false, valid: false, issue_count: 0, has_schema: false, dialect: "snowflake", error }, output: `Error: ${error}` }
+      return { title: "Semantics: NO SCHEMA", metadata: { success: false, valid: false, issue_count: 0, has_schema: false, error }, output: `Error: ${error}` }
     }
     try {
       const result = await Dispatcher.call("altimate_core.semantics", {
@@ -39,15 +39,14 @@ export const AltimateCoreSemanticsTool = Tool.define("altimate_core_semantics",
           valid: data.valid,
           issue_count: issueCount,
           has_schema: hasSchema,
-          dialect: "snowflake",
           ...(error && { error }),
           ...(findings.length > 0 && { findings }),
         },
         output: formatSemantics(hasError ? { ...data, error } : data),
       }
     } catch (e) {
       const msg = e instanceof Error ? e.message : String(e)
-      return { title: "Semantics: ERROR", metadata: { success: false, valid: false, issue_count: 0, has_schema: hasSchema, dialect: "snowflake", error: msg }, output: `Failed: ${msg}` }
+      return { title: "Semantics: ERROR", metadata: { success: false, valid: false, issue_count: 0, has_schema: hasSchema, error: msg }, output: `Failed: ${msg}` }
     }
   },
 })

packages/opencode/src/altimate/tools/altimate-core-validate.ts

@@ -16,7 +16,7 @@ export const AltimateCoreValidateTool = Tool.define("altimate_core_validate", {
     const noSchema = !hasSchema
     if (noSchema) {
       const error = "No schema provided. Provide schema_context or schema_path so table/column references can be resolved."
-      return { title: "Validate: NO SCHEMA", metadata: { success: false, valid: false, has_schema: false, dialect: "snowflake", error }, output: `Error: ${error}` }
+      return { title: "Validate: NO SCHEMA", metadata: { success: false, valid: false, has_schema: false, error }, output: `Error: ${error}` }
     }
     try {
       const result = await Dispatcher.call("altimate_core.validate", {
@@ -37,15 +37,14 @@ export const AltimateCoreValidateTool = Tool.define("altimate_core_validate", {
           success: true, // engine ran — validation errors are findings, not failures
           valid: data.valid,
           has_schema: hasSchema,
-          dialect: "snowflake",
           ...(error && { error }),
           ...(findings.length > 0 && { findings }),
         },
         output: formatValidate(data),
       }
     } catch (e) {
       const msg = e instanceof Error ? e.message : String(e)
-      return { title: "Validate: ERROR", metadata: { success: false, valid: false, has_schema: hasSchema, dialect: "snowflake", error: msg }, output: `Failed: ${msg}` }
+      return { title: "Validate: ERROR", metadata: { success: false, valid: false, has_schema: hasSchema, error: msg }, output: `Failed: ${msg}` }
     }
   },
 })

packages/opencode/src/altimate/tools/impact-analysis.ts

@@ -152,7 +152,6 @@ export const ImpactAnalysisTool = Tool.define("impact_analysis", {
           test_count: affectedTestCount,
           column_impact: columnImpact.length,
           has_schema: false,
-          dialect: args.dialect,
           ...(findings.length > 0 && { findings }),
         },
         output,
@@ -161,7 +160,7 @@ export const ImpactAnalysisTool = Tool.define("impact_analysis", {
       const msg = e instanceof Error ? e.message : String(e)
       return {
         title: "Impact: ERROR",
-        metadata: { success: false, has_schema: false, dialect: args.dialect, error: msg },
+        metadata: { success: false, has_schema: false, error: msg },
         output: `Failed to analyze impact: ${msg}\n\nEnsure the dbt manifest exists (run \`dbt compile\`) and the dispatcher is running.`,
       }
     }

packages/opencode/src/tool/tool.ts

@@ -172,7 +172,7 @@ export namespace Tool {
                 finding_count: findings.length,
                 by_category: JSON.stringify(by_category),
                 has_schema: result.metadata?.has_schema ?? false,
-                dialect: (result.metadata?.dialect as string) ?? "unknown",
+                ...(result.metadata?.dialect && { dialect: result.metadata.dialect as string }),
                 duration_ms: durationMs,
               })
             }