Skip to content

Commit a0c1918

Browse files
anandgupta42claude
andcommitted
test: address CodeRabbit review feedback
- `dbt-helpers.test.ts`: use `toBe` (reference equality) for symlink cache test - `status.test.ts`: add presence assertion before relative-path loop - `project-scan.test.ts`: add `connection_string` masking assertion for `clickhouse+http/https` schemes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 7fb5fca commit a0c1918

3 files changed

Lines changed: 3 additions & 1 deletion

File tree

packages/opencode/test/altimate/dbt-helpers.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ describe("loadRawManifest", () => {
354354

355355
const viaReal = loadRawManifest(realPath)
356356
const viaSym = loadRawManifest(symPath)
357-
expect(viaSym).toEqual(viaReal)
357+
expect(viaSym).toBe(viaReal)
358358
expect(viaSym.nodes.sym).toBe(true)
359359
})
360360
})

packages/opencode/test/file/status.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ describe("File.status()", () => {
112112
directory: tmp.path,
113113
fn: async () => {
114114
const changed = await File.status()
115+
expect(changed.length).toBeGreaterThan(0)
115116
for (const file of changed) {
116117
// All paths should be relative, not absolute
117118
expect(path.isAbsolute(file.path)).toBe(false)

packages/opencode/test/tool/project-scan.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -557,6 +557,7 @@ describe("detectEnvVars", () => {
557557
expect(ch).toBeDefined()
558558
expect(ch!.signal).toBe("DATABASE_URL")
559559
expect(ch!.type).toBe("clickhouse")
560+
expect(ch!.config.connection_string).toBe("***")
560561
}
561562
})
562563

0 commit comments

Comments
 (0)