fix: upgrade notification silently skipped in multiple scenarios (#389)

* fix: upgrade notification silently skipped in multiple scenarios

The upgrade indicator was never shown when:
- `autoupdate` was `false` or `OPENCODE_DISABLE_AUTOUPDATE` was set
- Install method was `"unknown"` or `"yarn"`
- Auto-upgrade failed (error swallowed by `.catch(() => {})`)

Additionally, there was no guard against downgrading canary/preview users
to an older stable release.

Changes:
- Always publish `UpdateAvailable` event so the indicator and toast appear
- Add `semver.gte()` guard to prevent downgrades
- Add `log.warn()` for `latest()` fetch failures and auto-upgrade errors
- Handle `yarn` install method explicitly (detected but not auto-upgradeable)
- Add 34 tests covering every decision path in `upgrade()`
- Update docs: clarify `autoupdate` config values, add upgrade indicator note

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: pre-existing typecheck errors in `training-import.test.ts`

- `readFile` mock return type mismatch (string vs Buffer)
- `count` mock missing `context` and `rule` keys

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: wire up `ALTIMATE_CLI_DISABLE_AUTOUPDATE` env var using `altTruthy`

The documented env var `ALTIMATE_CLI_DISABLE_AUTOUPDATE` was not functional —
`flag.ts` only read the legacy `OPENCODE_DISABLE_AUTOUPDATE`. Updated to use
`altTruthy()` pattern matching other flags in the codebase.

Found during multi-model code review (GPT 5.2 Codex, Gemini 3.1 Pro).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: anandgupta42

docs/docs/assets/images/upgrade-indicator-shown.png

@@ -44,7 +44,7 @@ Configuration is loaded from multiple sources, with later sources overriding ear
 | `default_agent` | `string` | Default agent to use on startup |
 | `logLevel` | `string` | Log level: `DEBUG`, `INFO`, `WARN`, `ERROR` |
 | `share` | `string` | Session sharing: `"manual"`, `"auto"`, `"disabled"` |
-| `autoupdate` | `boolean \| "notify"` | Auto-update behavior |
+| `autoupdate` | `boolean \| "notify"` | Auto-update behavior: `true` (default) auto-upgrades, `"notify"` shows an indicator without upgrading, `false` disables auto-upgrade but still shows the update indicator |
 | `provider` | `object` | Provider configurations (see [Providers](providers.md)) |
 | `mcp` | `object` | MCP server configurations (see [MCP Servers](mcp-servers.md)) |
 | `formatter` | `object \| false` | Formatter settings (see [Formatters](formatters.md)) |

docs/docs/assets/images/upgrade-no-indicator.png

@@ -104,14 +104,23 @@ Disable auto-update if it causes problems:
 export ALTIMATE_CLI_DISABLE_AUTOUPDATE=true
 ```
 
-Or set to notification only:
+Or set to notification only in your config:
 
 ```json
 {
   "autoupdate": "notify"
 }
 ```
 
+Both options still show an upgrade indicator in the footer when a new version is available. To upgrade manually, run:
+
+```bash
+altimate upgrade
+```
+
+!!! note
+    When an update is available, you'll see `↑ <version> update available · altimate upgrade` in the bottom-right corner of the TUI.
+
 ### Context Too Large
 
 If conversations hit context limits:

docs/docs/configure/config.md

@@ -68,7 +68,7 @@ Configuration can be controlled via environment variables:
 
 | Variable                               | Description                          |
 | -------------------------------------- | ------------------------------------ |
-| `ALTIMATE_CLI_DISABLE_AUTOUPDATE`      | Disable automatic updates            |
+| `ALTIMATE_CLI_DISABLE_AUTOUPDATE`      | Disable automatic updates (still shows upgrade indicator) |
 | `ALTIMATE_CLI_DISABLE_LSP_DOWNLOAD`    | Don't auto-download LSP servers      |
 | `ALTIMATE_CLI_DISABLE_AUTOCOMPACT`     | Disable automatic context compaction |
 | `ALTIMATE_CLI_DISABLE_DEFAULT_PLUGINS` | Skip loading default plugins         |

docs/docs/reference/troubleshooting.md

@@ -2,24 +2,55 @@ import { Bus } from "@/bus"
 import { Config } from "@/config/config"
 import { Flag } from "@/flag/flag"
 import { Installation } from "@/installation"
+// altimate_change start — robust upgrade notification
+import semver from "semver"
+import { Log } from "@/util/log"
+
+const log = Log.create({ service: "upgrade" })
 
 export async function upgrade() {
   const config = await Config.global()
   const method = await Installation.method()
-  const latest = await Installation.latest(method).catch(() => {})
+  const latest = await Installation.latest(method).catch((err) => {
+    log.warn("failed to fetch latest version", { error: String(err), method })
+    return undefined
+  })
   if (!latest) return
   if (Installation.VERSION === latest) return
 
+  // Prevent downgrade: if current version is already >= latest, skip
+  if (
+    Installation.VERSION !== "local" &&
+    semver.valid(Installation.VERSION) &&
+    semver.valid(latest) &&
+    semver.gte(Installation.VERSION, latest)
+  ) {
+    return
+  }
+
+  const notify = () => Bus.publish(Installation.Event.UpdateAvailable, { version: latest })
+
+  // Always notify when update is available, regardless of autoupdate setting
   if (config.autoupdate === false || Flag.OPENCODE_DISABLE_AUTOUPDATE) {
+    await notify()
     return
   }
   if (config.autoupdate === "notify") {
-    await Bus.publish(Installation.Event.UpdateAvailable, { version: latest })
+    await notify()
+    return
+  }
+
+  // Can't auto-upgrade for unknown or unsupported methods — notify instead
+  if (method === "unknown" || method === "yarn") {
+    await notify()
     return
   }
 
-  if (method === "unknown") return
   await Installation.upgrade(method, latest)
     .then(() => Bus.publish(Installation.Event.Updated, { version: latest }))
-    .catch(() => {})
+    .catch(async (err) => {
+      log.warn("auto-upgrade failed, notifying instead", { error: String(err), method, target: latest })
+      await notify()
+    })
 }
+// altimate_change end

docs/docs/usage/cli.md

@@ -28,7 +28,9 @@ export namespace Flag {
   export declare const OPENCODE_TUI_CONFIG: string | undefined
   export declare const OPENCODE_CONFIG_DIR: string | undefined
   export const OPENCODE_CONFIG_CONTENT = process.env["OPENCODE_CONFIG_CONTENT"]
-  export const OPENCODE_DISABLE_AUTOUPDATE = truthy("OPENCODE_DISABLE_AUTOUPDATE")
+  // altimate_change start — support ALTIMATE_CLI_DISABLE_AUTOUPDATE env var (documented name)
+  export const OPENCODE_DISABLE_AUTOUPDATE = altTruthy("ALTIMATE_CLI_DISABLE_AUTOUPDATE", "OPENCODE_DISABLE_AUTOUPDATE")
+  // altimate_change end
   export const OPENCODE_DISABLE_PRUNE = truthy("OPENCODE_DISABLE_PRUNE")
   // altimate_change start - global opt-out for Altimate Memory
   export const ALTIMATE_DISABLE_MEMORY = altTruthy("ALTIMATE_DISABLE_MEMORY", "OPENCODE_DISABLE_MEMORY")

packages/opencode/src/cli/upgrade.ts

@@ -56,6 +56,8 @@ function setupMocks(opts: {
     context: opts.currentCount ?? 0,
     rule: opts.currentCount ?? 0,
     pattern: opts.currentCount ?? 0,
+    context: opts.currentCount ?? 0,
+    rule: opts.currentCount ?? 0,
   }))
   saveSpy = spyOn(TrainingStore, "save").mockImplementation(async () => {
     if (opts.saveShouldFail) throw new Error("store write failed")