fix: address CodeRabbit review — explicit find pattern, Windows path.delimiter, binary names

- Use `*altimate-code-linux-x64/bin/altimate` in pre-publish find pattern
  for clarity (old pattern worked but was ambiguous)
- Use `path.delimiter` instead of hardcoded `:` for NODE_PATH in both
  `pre-release-check.ts` and `smoke-test-binary.test.ts`
- Handle Windows `altimate.exe` binary name in `searchDist()` functions

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: anandgupta42

.github/workflows/release.yml

@@ -192,7 +192,7 @@ jobs:
       # compile-time checks miss (e.g. missing NAPI externals like v0.5.10).
       - name: Pre-publish smoke test
         run: |
-          BINARY=$(find packages/opencode/dist -path '*/linux-x64/*/altimate' -type f | head -1)
+          BINARY=$(find packages/opencode/dist -path '*altimate-code-linux-x64/bin/altimate' -type f | head -1)
           if [ -z "$BINARY" ]; then
             echo "::error::No linux-x64 binary found in artifacts — cannot verify release"
             exit 1

packages/opencode/script/pre-release-check.ts

@@ -85,13 +85,16 @@ if (buildResult.status !== 0) {
   // Find the binary — walk recursively for scoped packages (@altimateai/...)
   const distDir = path.join(pkgDir, "dist")
   let binaryPath: string | undefined
+  const binaryNames = process.platform === "win32" ? ["altimate.exe", "altimate"] : ["altimate"]
   function searchDist(dir: string): string | undefined {
     if (!fs.existsSync(dir)) return undefined
     for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
       if (!entry.isDirectory()) continue
       const sub = path.join(dir, entry.name)
-      const candidate = path.join(sub, "bin", "altimate")
-      if (fs.existsSync(candidate)) return candidate
+      for (const name of binaryNames) {
+        const candidate = path.join(sub, "bin", name)
+        if (fs.existsSync(candidate)) return candidate
+      }
       const nested = searchDist(sub)
       if (nested) return nested
     }
@@ -121,7 +124,7 @@ if (buildResult.status !== 0) {
       timeout: 15_000,
       env: {
         ...process.env,
-        NODE_PATH: nodePaths.join(":"),
+        NODE_PATH: nodePaths.join(path.delimiter),
         OPENCODE_DISABLE_TELEMETRY: "1",
       },
     })

packages/opencode/test/install/smoke-test-binary.test.ts

@@ -26,12 +26,15 @@ function findLocalBinary(): string | undefined {
   if (!fs.existsSync(distDir)) return undefined
 
   // Walk dist/ recursively — binary packages may be scoped (@altimateai/...)
+  const binaryNames = process.platform === "win32" ? ["altimate.exe", "altimate"] : ["altimate"]
   function search(dir: string): string | undefined {
     for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
       if (!entry.isDirectory()) continue
       const sub = path.join(dir, entry.name)
-      const binPath = path.join(sub, "bin", "altimate")
-      if (fs.existsSync(binPath)) return binPath
+      for (const name of binaryNames) {
+        const binPath = path.join(sub, "bin", name)
+        if (fs.existsSync(binPath)) return binPath
+      }
       // Recurse one level for scoped packages (e.g. @altimateai/)
       const nested = search(sub)
       if (nested) return nested
@@ -55,7 +58,7 @@ function resolveNodePath(): string {
     if (parent === current) break
     current = parent
   }
-  return paths.join(":")
+  return paths.join(path.delimiter)
 }
 
 describe("compiled binary smoke test", () => {