fix: remove dead accepted/rejected fields, add training tips, expand limitations

Gaps found by simulation team:

1. Remove `accepted`/`rejected` counters from TrainingBlockMeta — they were
   never incremented anywhere in the codebase (dead code since inception)
2. Add 5 training discoverability tips to TUI tips (was 0 mentions in 152 tips)
3. Expand limitations section in docs with honest, complete list:
   context budget, 20/kind limit, no approval workflow, SQL-focused,
   git discipline required

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: anandgupta42

docs/docs/data-engineering/training/index.md

@@ -146,10 +146,13 @@ Training doesn't replace CLAUDE.md. They complement each other:
 
 ## Limitations
 
-- **Not a linter.** Training is advisory — the agent follows it, but it's not enforced at build time. For critical rules, also add dbt tests.
-- **Not an audit trail.** No approval workflows or change tracking beyond git history.
-- **Not automatic.** The agent proposes, you confirm. This is intentional.
-- **SQL-focused scanning.** The `/teach` skill works best with SQL/dbt files. Python patterns must be taught manually.
+- **Advisory, not enforced.** Training guides the agent, but it's not a hard gate. For critical rules, also add dbt tests or sqlfluff rules that block CI.
+- **No approval workflow.** Anyone with repo access can save training to project scope. Use code review on `.altimate-code/memory/` changes for governance.
+- **No audit trail** beyond git history. Training doesn't track who saved what — use `git blame` on the training files.
+- **Context budget.** Training competes for context space. Under pressure, least-relevant entries are excluded. Run `/training-status` to see what's included.
+- **20 entries per kind.** Hard limit. Consolidate related rules into one entry rather than saving many small ones.
+- **SQL-focused file analysis.** The `/teach` skill works best with SQL/dbt files. Python, PySpark, and other patterns must be taught manually via conversation.
+- **Team sync requires git discipline.** Training saves to disk but doesn't auto-commit. Commit `.altimate-code/memory/` changes to share with your team.
 
 ## Quick Reference
 

packages/opencode/.github/meta/commit.txt

@@ -0,0 +1,22 @@
+refactor: cut training_scan and training_validate, simplify docs
+
+Research from 8 independent evaluations + SkillsBench (7,308 test runs)
+found that compact focused context beats comprehensive docs by 20pp.
+The training system's value is in correction capture (2-sec saves) and
+team propagation (git sync) — not in regex scanning or keyword grep.
+
+Removed:
+- training_scan (255 lines) — regex pattern counting, not discovery
+- training_validate (315 lines) — keyword grep, not validation
+
+Simplified:
+- trainer.txt: removed scan/validate workflows, focused on guided
+  teaching and curation
+- agent-modes.md: updated trainer section with correction-focused example
+- training docs: complete rewrite with new pitch:
+  "Correct the agent once. It remembers forever. Your team inherits it."
+  Backed by SkillsBench research showing compact > comprehensive.
+
+Net: -753 lines. 152 tests pass.
+
+Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

packages/opencode/src/altimate/training/store.ts

@@ -43,8 +43,6 @@ export namespace TrainingStore {
       kind: input.kind,
       source: input.source,
       applied: prevMeta?.applied ?? 0,
-      accepted: prevMeta?.accepted ?? 0,
-      rejected: prevMeta?.rejected ?? 0,
     }
 
     const enriched = embedTrainingMeta(input.content, meta)
@@ -144,8 +142,6 @@ export namespace TrainingStore {
     const meta = parseTrainingMeta(block.content) ?? {
       kind,
       applied: 0,
-      accepted: 0,
-      rejected: 0,
     }
     return {
       id: block.id,

packages/opencode/src/altimate/training/types.ts

@@ -14,8 +14,6 @@ export const TrainingBlockMeta = z.object({
   kind: TrainingKind,
   source: z.string().optional(),
   applied: z.number().int().min(0).default(0),
-  accepted: z.number().int().min(0).default(0),
-  rejected: z.number().int().min(0).default(0),
 })
 export type TrainingBlockMeta = z.infer<typeof TrainingBlockMeta>
 
@@ -62,8 +60,6 @@ export function embedTrainingMeta(content: string, meta: TrainingBlockMeta): str
     `kind: ${meta.kind}`,
     ...(meta.source ? [`source: ${meta.source}`] : []),
     `applied: ${meta.applied}`,
-    `accepted: ${meta.accepted}`,
-    `rejected: ${meta.rejected}`,
     "-->",
   ].join("\n")
   // Strip existing training meta block if present

packages/opencode/src/cli/cmd/tui/component/tips.tsx

@@ -149,4 +149,11 @@ const TIPS = [
   "Run {highlight}/help{/highlight} or {highlight}Ctrl+X H{/highlight} to show the help dialog",
   "Use {highlight}/rename{/highlight} to rename the current session",
   "Press {highlight}Ctrl+Z{/highlight} to suspend the terminal and return to your shell",
+  // altimate_change start - training discoverability tips
+  "Correct me once and I'll remember forever — say {highlight}yes{/highlight} when I ask to save a correction",
+  "Use {highlight}/teach @file.sql{/highlight} to teach me patterns from your code",
+  "Use {highlight}/train @docs/style-guide.md{/highlight} to load team standards from documentation",
+  "Use {highlight}/training-status{/highlight} to see what your team has taught me",
+  "Switch to {highlight}trainer{/highlight} mode to systematically teach me about your project",
+  // altimate_change end
 ]

packages/opencode/test/training/tools.test.ts

@@ -106,29 +106,26 @@ describe("training meta roundtrip through content", () => {
     expect(parsed!.kind).toBe("pattern")
     expect(parsed!.source).toBe("stg_orders.sql")
     expect(parsed!.applied).toBe(5)
-    expect(parsed!.accepted).toBe(3)
-    expect(parsed!.rejected).toBe(1)
   })
 
   test("preserves content after embedding meta", () => {
     const content = "Rule: Use NUMERIC(18,2)\n\nDetails:\n- For all *_amount columns"
-    const meta: TrainingBlockMeta = { kind: "rule", applied: 0, accepted: 0, rejected: 0 }
+    const meta: TrainingBlockMeta = { kind: "rule", applied: 0 }
     const embedded = embedTrainingMeta(content, meta)
     expect(embedded).toContain("Rule: Use NUMERIC(18,2)")
     expect(embedded).toContain("- For all *_amount columns")
   })
 
   test("replaces existing meta on re-embed", () => {
-    const meta1: TrainingBlockMeta = { kind: "pattern", applied: 1, accepted: 0, rejected: 0 }
-    const meta2: TrainingBlockMeta = { kind: "pattern", applied: 10, accepted: 8, rejected: 2 }
+    const meta1: TrainingBlockMeta = { kind: "pattern", applied: 1 }
+    const meta2: TrainingBlockMeta = { kind: "pattern", applied: 10 }
     const content = "Pattern content"
 
     const embedded1 = embedTrainingMeta(content, meta1)
     expect(parseTrainingMeta(embedded1)!.applied).toBe(1)
 
     const embedded2 = embedTrainingMeta(embedded1, meta2)
     expect(parseTrainingMeta(embedded2)!.applied).toBe(10)
-    expect(parseTrainingMeta(embedded2)!.accepted).toBe(8)
 
     // Should not have duplicate meta blocks
     const metaBlocks = embedded2.match(/<!-- training/g)
@@ -137,7 +134,7 @@ describe("training meta roundtrip through content", () => {
 
   test("handles content with special characters", () => {
     const content = "Use `{{ source('schema', 'table') }}` macro\n<!-- not training -->"
-    const meta: TrainingBlockMeta = { kind: "pattern", applied: 0, accepted: 0, rejected: 0 }
+    const meta: TrainingBlockMeta = { kind: "pattern", applied: 0 }
     const embedded = embedTrainingMeta(content, meta)
     expect(embedded).toContain("{{ source('schema', 'table') }}")
     expect(embedded).toContain("<!-- not training -->")

packages/opencode/test/training/types.test.ts

@@ -107,16 +107,12 @@ describe("embedTrainingMeta", () => {
       kind: "pattern",
       source: "stg_orders.sql",
       applied: 3,
-      accepted: 2,
-      rejected: 1,
     }
     const result = embedTrainingMeta("Pattern content here", meta)
     expect(result).toContain("<!-- training")
     expect(result).toContain("kind: pattern")
     expect(result).toContain("source: stg_orders.sql")
     expect(result).toContain("applied: 3")
-    expect(result).toContain("accepted: 2")
-    expect(result).toContain("rejected: 1")
     expect(result).toContain("-->")
     expect(result).toContain("Pattern content here")
   })
@@ -125,20 +121,16 @@ describe("embedTrainingMeta", () => {
     const meta: TrainingBlockMeta = {
       kind: "rule",
       applied: 0,
-      accepted: 0,
-      rejected: 0,
     }
     const result = embedTrainingMeta("Rule content", meta)
     expect(result).not.toContain("source:")
   })
 
   test("replaces existing meta block", () => {
-    const existing = "<!-- training\nkind: pattern\napplied: 1\naccepted: 0\nrejected: 0\n-->\nOld content"
+    const existing = "<!-- training\nkind: pattern\napplied: 1\n-->\nOld content"
     const meta: TrainingBlockMeta = {
       kind: "pattern",
       applied: 5,
-      accepted: 3,
-      rejected: 0,
     }
     const result = embedTrainingMeta(existing, meta)
     expect(result).toContain("applied: 5")
@@ -150,22 +142,20 @@ describe("embedTrainingMeta", () => {
 
 describe("parseTrainingMeta", () => {
   test("parses embedded meta", () => {
-    const content = "<!-- training\nkind: pattern\nsource: stg_orders.sql\napplied: 3\naccepted: 2\nrejected: 1\n-->\nPattern content"
+    const content = "<!-- training\nkind: pattern\nsource: stg_orders.sql\napplied: 3\n-->\nPattern content"
     const meta = parseTrainingMeta(content)
     expect(meta).toBeDefined()
     expect(meta!.kind).toBe("pattern")
     expect(meta!.source).toBe("stg_orders.sql")
     expect(meta!.applied).toBe(3)
-    expect(meta!.accepted).toBe(2)
-    expect(meta!.rejected).toBe(1)
   })
 
   test("returns undefined for content without meta", () => {
     expect(parseTrainingMeta("Just plain content")).toBeUndefined()
   })
 
   test("handles meta without source", () => {
-    const content = "<!-- training\nkind: rule\napplied: 0\naccepted: 0\nrejected: 0\n-->\nRule"
+    const content = "<!-- training\nkind: rule\napplied: 0\n-->\nRule"
     const meta = parseTrainingMeta(content)
     expect(meta).toBeDefined()
     expect(meta!.kind).toBe("rule")
@@ -177,17 +167,13 @@ describe("parseTrainingMeta", () => {
       kind: "standard",
       source: "docs/style-guide.md",
       applied: 7,
-      accepted: 5,
-      rejected: 2,
     }
     const embedded = embedTrainingMeta("Test content", original)
     const parsed = parseTrainingMeta(embedded)
     expect(parsed).toBeDefined()
     expect(parsed!.kind).toBe(original.kind)
     expect(parsed!.source).toBe(original.source)
     expect(parsed!.applied).toBe(original.applied)
-    expect(parsed!.accepted).toBe(original.accepted)
-    expect(parsed!.rejected).toBe(original.rejected)
   })
 })