fix: address Sentry review findings — 7 bugs fixed

1. stripTrainingMeta/parseTrainingMeta regex: remove multiline `m` flag
   that could match user content starting with `<!-- training` mid-string
   (types.ts, store.ts)

2. training_save content limit: reduce from 2500 to 1800 chars to account
   for ~200 char metadata overhead against MemoryStore's 2048 char limit
   (training-save.ts)

3. injectTrainingOnly: change `break` to `continue` so budget-exceeding
   section headers skip to next kind instead of stopping all injection
   (memory/prompt.ts)

4. injectTrainingOnly: track itemCount and return empty string when no
   items injected (was returning header-only string, inflating budget
   reports) (memory/prompt.ts)

5. projectDir cache: replace module-level singleton with Map keyed by
   Instance.directory to prevent stale paths when AsyncLocalStorage
   context changes across concurrent requests (memory/store.ts)

6. budgetUsage side effect: already fixed — delegates to injectTrainingOnly
   which is read-only (no applied count increment). Sentry comments were
   against pre-refactor code.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: anandgupta42

docs/docs/data-engineering/training/index.md

@@ -177,7 +177,7 @@ Training doesn't replace CLAUDE.md. They complement each other:
 | Limit | Value |
 |---|---|
 | Max entries per kind | 20 |
-| Max content per entry | 2,500 characters |
+| Max content per entry | 1,800 characters |
 | Training kinds | 6 |
 | Scopes | 2 (global = personal, project = team) |
 

packages/opencode/src/altimate/tools/training-save.ts

@@ -43,8 +43,8 @@ export const TrainingSaveTool = Tool.define("training_save", {
     content: z
       .string()
       .min(1)
-      .max(2500)
-      .describe("The knowledge to save. Be specific and actionable. Use markdown for structure. Max 2500 chars."),
+      .max(1800)
+      .describe("The knowledge to save. Be specific and actionable. Use markdown for structure. Max 1800 chars."),
     scope: z
       .enum(["global", "project"])
       .default("project")

packages/opencode/src/altimate/training/store.ts

@@ -164,5 +164,5 @@ export namespace TrainingStore {
 }
 
 function stripTrainingMeta(content: string): string {
-  return content.replace(/^<!--\s*training\n[\s\S]*?-->\n*/m, "").trim()
+  return content.replace(/^<!--\s*training\n[\s\S]*?-->\n*/, "").trim()
 }

packages/opencode/src/altimate/training/types.ts

@@ -39,7 +39,7 @@ export function trainingKind(block: { tags: string[] }): TrainingKind | undefine
 
 export function parseTrainingMeta(content: string): TrainingBlockMeta | undefined {
   // Training blocks store structured metadata in the first YAML-like section
-  const match = content.match(/^<!--\s*training\n([\s\S]*?)\n-->/m)
+  const match = content.match(/^<!--\s*training\n([\s\S]*?)\n-->/)
   if (!match) return undefined
   const meta: Record<string, unknown> = {}
   for (const line of match[1].split("\n")) {
@@ -63,6 +63,6 @@ export function embedTrainingMeta(content: string, meta: TrainingBlockMeta): str
     "-->",
   ].join("\n")
   // Strip existing training meta block if present
-  const stripped = content.replace(/^<!--\s*training\n[\s\S]*?-->\n*/m, "")
+  const stripped = content.replace(/^<!--\s*training\n[\s\S]*?-->\n*/, "")
   return header + "\n" + stripped
 }

packages/opencode/src/memory/prompt.ts

@@ -253,6 +253,7 @@ export namespace MemoryPrompt {
     const header = "## Teammate Training\n\nYou have been trained on the following knowledge by your team. Apply it consistently.\n"
     let result = header
     let used = header.length
+    let itemCount = 0
 
     const byKind = new Map<TrainingKind, MemoryBlock[]>()
     for (const block of training) {
@@ -269,7 +270,7 @@ export namespace MemoryPrompt {
 
       const section = KIND_HEADERS[kind]
       const sectionHeader = `\n### ${section.header}\n_${section.instruction}_\n`
-      if (used + sectionHeader.length > budget) break
+      if (used + sectionHeader.length > budget) continue
       result += sectionHeader
       used += sectionHeader.length
 
@@ -285,9 +286,10 @@ export namespace MemoryPrompt {
         if (used + needed > budget) break
         result += "\n" + formatted + "\n"
         used += needed
+        itemCount++
       }
     }
 
-    return result
+    return itemCount > 0 ? result : ""
   }
 }

packages/opencode/src/memory/store.ts

@@ -14,20 +14,24 @@ function globalDir(): string {
 }
 
 // altimate_change start - use .altimate-code (primary) with .opencode (fallback)
-let _cachedProjectDir: string | undefined
+// Cache keyed by Instance.directory to avoid stale paths when context changes
+const _projectDirCache = new Map<string, string>()
 function projectDir(): string {
-  if (_cachedProjectDir) return _cachedProjectDir
-  const primary = path.join(Instance.directory, ".altimate-code", "memory")
-  const fallback = path.join(Instance.directory, ".opencode", "memory")
-  // Use .altimate-code if it exists, fall back to .opencode, default to .altimate-code for new projects
-  if (fsSync.existsSync(path.join(Instance.directory, ".altimate-code"))) {
-    _cachedProjectDir = primary
-  } else if (fsSync.existsSync(path.join(Instance.directory, ".opencode"))) {
-    _cachedProjectDir = fallback
+  const dir = Instance.directory
+  const cached = _projectDirCache.get(dir)
+  if (cached) return cached
+  const primary = path.join(dir, ".altimate-code", "memory")
+  const fallback = path.join(dir, ".opencode", "memory")
+  let result: string
+  if (fsSync.existsSync(path.join(dir, ".altimate-code"))) {
+    result = primary
+  } else if (fsSync.existsSync(path.join(dir, ".opencode"))) {
+    result = fallback
   } else {
-    _cachedProjectDir = primary
+    result = primary
   }
-  return _cachedProjectDir
+  _projectDirCache.set(dir, result)
+  return result
 }
 // altimate_change end