Commit ecc7001
fix: address v0.8.6 release-review findings
Five-persona pre-release review of #886 (session traces in headless serve).
No P0/HOLD; these are the actionable polish items:
- trace-consumer.ts (flush): finalize sessions concurrently (Promise.allSettled)
instead of sequentially. Each endTrace() can wait on an HttpExporter (5s
timeout), so a sequential loop over N sessions could exceed a container's
shutdown grace period and be SIGKILL'd mid-write. Now bounded to the slowest
single trace.
- trace-consumer.ts (reconnect): log the in-process stream reconnect at debug,
not warn — it's automatic and not user-actionable, and warn-per-backoff
spiked log aggregators during an outage.
- serve.ts: comment clarifying that subscribeTraceConsumer's `directory` is the
SDK workspace context, not the trace output dir (flagged by 4 reviewers).
- docs: ide.md now lists session tracing as an IDE feature; trace.md crash-
recovery notes that `serve` (not just `run`) finalizes traces on shutdown.
Deferred (filed): #915 (container trace persistence), #916 (serve trace-dir
startup log).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent ed1eecd commit ecc7001
4 files changed
Lines changed: 21 additions & 6 deletions
File tree
- docs/docs
- configure
- usage
- packages/opencode/src
- altimate/observability
- cli/cmd
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
325 | 325 | | |
326 | 326 | | |
327 | 327 | | |
328 | | - | |
| 328 | + | |
329 | 329 | | |
330 | 330 | | |
331 | 331 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
| |||
Lines changed: 15 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
309 | 309 | | |
310 | 310 | | |
311 | 311 | | |
312 | | - | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
313 | 321 | | |
314 | | - | |
315 | | - | |
316 | | - | |
| 322 | + | |
317 | 323 | | |
318 | 324 | | |
319 | 325 | | |
| |||
410 | 416 | | |
411 | 417 | | |
412 | 418 | | |
413 | | - | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
414 | 424 | | |
415 | 425 | | |
416 | 426 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
32 | 36 | | |
33 | 37 | | |
34 | 38 | | |
| |||
0 commit comments