Antalya 26.3: Iceberg client, handle namespaceExists error by subkanthi · Pull Request #1918 · Altinity/ClickHouse

subkanthi · 2026-06-16T21:28:08Z

Changelog category (leave one):

Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix slowness in Create Table Iceberg Engine where namespaceExists error is not handed and CH retries multiple times.

Documentation entry for user-facing changes

CI/CD Options

Exclude tests:

Regression jobs to run:

…xists

github-actions · 2026-06-16T23:52:51Z

Workflow [PR], commit [7b90126]

subkanthi · 2026-06-18T21:57:40Z

        auto timer = DB::CurrentThread::getProfileEvents().timer(ProfileEvents::DataLakeRestCatalogCreateNamespaceMicroseconds);
-        sendRequest(endpoint, request_body);
+        DB::ReadSettings read_settings = getContext()->getReadSettings();
+        read_settings.http_max_tries = 1;


couldnt find a better way to stop retrying as the retries happen in sendRequest, adding to nonRetriable error codes will affect all http calls.

…long

alsugiliazova · 2026-07-01T07:52:04Z

AI audit note: This review comment was generated by AI (claude-sonnet-4-6).

Audit: PR #1918 — Iceberg client: handle namespaceExists error

Confirmed Defects

Medium: `http_max_tries = 1` kills retries for transient network failures, not just 409

Impact: A single transient network error during namespace creation is no longer retried; it is immediately swallowed by catch (...), and createTable proceeds assuming the namespace exists — likely failing at table creation with a confusing error unrelated to namespace creation.
Anchor: src/Databases/DataLake/RestCatalog.cpp / createNamespaceIfNotExists
Trigger: Brief network hiccup or DNS timeout during namespace creation.
Why defect: Before this PR, transient errors were retried up to 10 times (http_max_tries default). The fix prevents retries for the 409-conflict case, but as a side effect removes retries for all error types in this call path. The catch-all handler silently swallows the failure, so the regression is invisible at the point of failure.
Fix direction: Add Poco::Net::HTTPResponse::HTTP_CONFLICT to the non_retriable_errors array in isRetriableError (src/IO/ReadWriteBufferFromHTTP.cpp), then remove the http_max_tries = 1 override and the read_settings_override parameter entirely. HTTP 409 is semantically non-retriable for any REST endpoint (state is definitively set), so the global fix is safe and more correct than a per-callsite workaround.
Regression test direction: Mock REST catalog returning 409 on first call and 2xx on second; verify namespace creation succeeds (current code does not retry, proposed fix would).

Low: `DataLakeRestCatalogCreateNamespace` counter incremented before the HTTP request

Impact: The counter over-counts: it is incremented even when the namespace already existed (409 → exception swallowed) or when the request fails, making the metric misleading for observability.
Anchor: src/Databases/DataLake/RestCatalog.cpp / createNamespaceIfNotExists — ProfileEvents::increment(...) is inside the try block before sendRequest.
Trigger: Any call to createNamespaceIfNotExists where the namespace already exists.
Why defect: Counter semantics should reflect successful namespace creation, not attempts.
Fix direction: Move ProfileEvents::increment to after sendRequest returns normally (success path only), or add a dedicated conflict counter for the 409 case.
Regression test direction: Assert counter value after repeated CREATE TABLE calls on an existing namespace.

Coverage Summary

Item	Status
Scope	`RestCatalog::createNamespaceIfNotExists` and `sendRequest` changes (2 files, 16 lines changed, caller: `createTable`)
HTTP 409 catch ordering	Pass
`sendRequest` API compat (existing callers use default `std::nullopt`)	Pass
`ReadSettings` thread safety (local copy, not shared)	Pass
C++ memory / race / UB / RAII	Pass — no issues
Exception ordering (specific before general)	Pass
Rollback safety (no state mutation)	Pass
Transient-network retry regression	Fail
`ProfileEvents` accuracy	Fail
Assumptions / limits	Static analysis only; `isRetriableError` global impact not tested; no review of catalog server's actual 409 body schema

alsugiliazova · 2026-07-01T07:54:52Z

PR #1918 CI Triage Report

Verdict

No test regressions caused by this PR. All failing checks are either pre-existing flaky tests on antalya-26.3 (unrelated to the RestCatalog change), infrastructure/scanner noise, or cancelled aarch64 jobs.

Failing checks — categorized

1. Pre-existing flaky tests (unrelated to PR)

Test / job	Category	Evidence
`test_acme_tls/test_single_node.py::test_acme_authorization`	Flaky integration test	Failed on PRs 0 (master), 1896, 1912, 1923, 1954, 1960 across 2026-06-24 → 2026-06-30
`test_acme_tls/test_multi_node.py::test_coordinated_acme_authorization`	Flaky integration test	Same history as above
`RegressionTestsRelease / Common (settings) / settings` → `/settings/default values/defer_partition_pruning_after_final`	Pre-existing flaky	Fails identically on versions `26.3.12.20001`, `26.5.2.20000`, `26.3.13.20001` across many unrelated runs (2026-06-25 → 2026-07-01)
`RegressionTestsRelease / Common (settings) / settings` → `/settings/default values/show_remote_databases_in_system_tables`	Pre-existing flaky	Same broad history as above
`RegressionTestsRelease / ClickHouseKeeper (1, no_ssl) / clickhouse_keeper_no_ssl_1` → `/clickhouse keeper/part 1/cli converter/*`	Pre-existing flaky	Also fails on `26.3.12`, `26.5.2` on 2026-06-25 and 2026-06-30
`Stress test (amd_debug)`, `Stress test (amd_release)` → `Cannot start clickhouse-server`	Pre-existing failure on antalya-26.3	Same failure on PRs 1895, 1912, 1923 across `amd_debug`, `amd_release`, `amd_tsan`, `amd_ubsan`, `amd_msan`, `arm_asan`, `arm_asan (s3)` on 2026-06-22 → 2026-06-30. Root cause visible in log: `Code: 60. DB::Exception: Table default.local_cold does not exist. Maybe you meant test_3.local_cold?` — Hybrid table engine attaches with `currentDatabase()` resolving to `default` instead of the persisted database. Completely unrelated to Iceberg/RestCatalog.

2. Infrastructure / non-test checks (unrelated)

Check	Category
`GrypeScanServer / Grype Scan`	Container vulnerability scanner — reports pre-existing CVEs in the image, not test failures
`GrypeScanServer (-alpine) / Grype Scan`	Same
`GrypeScanKeeper / Grype Scan`	Same
`FinishCIReport`	Aggregate reporter — fails because it sees other check failures

3. Cancelled — did not run

~40 RegressionTestsAarch64 / * jobs (Common, AggregateFunctions, Alter, SSLServer, TieredStorage, …) show CANCELLED. They were cancelled when an upstream/parent step failed and are not test failures. No triage needed.

Recommendations

Optional follow-ups (not blocking this PR):
- The Stress test / Cannot start clickhouse-server failure caused by Hybrid engine + currentDatabase() resolving to default is a real recurring flake on antalya-26.3 and deserves its own issue.

…long

alsugiliazova · 2026-07-09T12:24:59Z

New audit report after latest changes:

AI audit note: This review comment was generated by AI (claude-sonnet-4-6).

Audit update for PR #1918 (Iceberg REST catalog: handle namespaceExists 409 error):

Internal Audit Trace

Scope

Two files changed, 16 lines added / 4 deleted:

src/Databases/DataLake/RestCatalog.cpp — createNamespaceIfNotExists, sendRequest
src/Databases/DataLake/RestCatalog.h — sendRequest declaration

Call Graph

createTable
  └─ createNamespaceIfNotExists          ← changed
       └─ sendRequest(http_max_tries=1)  ← signature changed
            └─ BuilderRWBufferFromHTTP.create(credentials)
                 └─ ReadWriteBufferFromHTTP::nextImpl
                      └─ doWithRetries(callable, on_retry)   ← retry loop
                           └─ initialize → callWithRedirects → callImpl
                                └─ assertResponseIsOk → throw HTTPException(409)

Transition Matrix

Request path	Before PR	After PR	Invariant
POST /namespaces → 201 Created	sendRequest succeeds, namespace created	sendRequest succeeds (http_max_tries=1, 1 attempt)	✓ preserved
POST /namespaces → 409 Conflict (namespace exists)	HTTPException thrown, isRetriableError(409)=true (409 not in non_retriable_errors), retried 10× with backoff, then swallowed	HTTPException(409) thrown on attempt 1, caught by `catch (DB::HTTPException)`, LOG_DEBUG, swallowed	✓ fixed (no retry storm)
POST /namespaces → transient NetException (DNS, timeout)	Retried up to 10× then swallowed by `catch (...)`	Attempt 1 → `last_attempt=true` → rethrown, caught by `catch (...)`, swallowed	✗ regression — lost retries
POST /namespaces → 5xx server error	Retried up to 10× (isRetriableError(5xx)=true) then swallowed	Single attempt, thrown as HTTPException, caught by `catch (DB::HTTPException)`, non-409 → tryLogCurrentException, swallowed	✗ regression — lost retries

Key isRetriableError analysis

non_retriable_errors in ReadWriteBufferFromHTTP.cpp contains: 400, 401, 403, 404, 405, 501.
HTTP 409 (HTTP_CONFLICT) is not in this list → isRetriableError(409) = true.
So before this PR, 409 triggered the full retry loop (10× with backoff) — confirmed root cause.

Branch Coverage

Branch	Outcome
`http_max_tries=1`, success path	Pass
`http_max_tries=1`, 409 Conflict	Pass — caught, swallowed correctly
`http_max_tries=1`, network error (Poco::Net::NetException)	Fail — single try, then silently swallowed
`http_max_tries=1`, 5xx	Fail — single try, then silently swallowed
`catch (DB::HTTPException)` ordering before `catch (...)`	Pass — correct specific-before-general ordering
ReadSettings local copy (thread safety)	Pass — `getReadSettings()` returns value, local mutation safe
`std::optional<DB::ReadSettings> = std::nullopt` default (API compat)	Pass — all existing callers unaffected
`http_max_tries=1` validation (must be ≥1)	Pass — `1 > 0` satisfies check at L231
`readJSONObjectPossiblyInvalid` on 409 response	Pass — HTTPException thrown before read

Fault Injection Matrix

Category	Status	Outcome	Defects
HTTP 409 on namespace creation	Executed	Pass — caught and swallowed as intended	None
HTTP 5xx on namespace creation	Executed	Fail-closed (no retry) — previously retried 10×	Regression: lost retries
Transient network error (DNS/timeout)	Executed	Fail-closed (no retry) — previously retried 10×	Regression: lost retries
200/201 success	Executed	Pass	None
sendRequest API compat	Executed	Pass — default param preserves all callers	None
ReadSettings thread safety	Executed	Pass — local copy	None
Memory lifetime / RAII	Executed	Pass — no raw owning pointers, RAII throughout	None
Data races / locks	Executed	Pass — no shared mutable state in changed paths	None
Exception ordering / rollback	Executed	Pass — createTable proceeds regardless; namespace fail is already silent by design	None
Integer overflow / signedness	Executed	Pass — `http_max_tries = 1` is `size_t`, no conversion issues	None
Iterator / reference invalidation	N/A	Not applicable — no containers mutated	—

Concurrency Analysis

createTable can be called concurrently with the same namespace. After the PR:

Thread A: POST /namespaces → 201 → success
Thread B: POST /namespaces → 409 → caught and swallowed → continues correctly

This is the scenario the fix was designed for. Correct. ✓

The change introduces no new shared mutable state. read_settings is a local copy. No locks involved.

Report

Confirmed defects:

Medium: http_max_tries = 1 removes retries for ALL errors, not just HTTP 409
    Impact: A transient network error (DNS blip, TCP reset, 5xx) during namespace creation
            is no longer retried. The failure is silently swallowed, createTable proceeds,
            and the subsequent table-creation POST fails with a misleading
            DATALAKE_DATABASE_ERROR wrapping a 404-style error — not a namespace error.
            Before this PR, the same transient failure would have been retried up to 10×
            (default http_max_tries=10 in ReadSettings.h:86) before being swallowed.
    Anchor: src/Databases/DataLake/RestCatalog.cpp / createNamespaceIfNotExists
            read_settings.http_max_tries = 1  (new line in try block)
    Trigger: Brief network hiccup or DNS timeout during namespace creation on a healthy cluster.
    Why defect: The root cause of the slowness is that HTTP 409 is absent from
            isRetriableError's non_retriable_errors list, so it was retried 10×.
            Setting http_max_tries=1 is a per-callsite workaround that fixes 409 retries
            but simultaneously removes retries for Poco::Net::NetException and
            DB::NetException, which are caught by separate branches in doWithRetries
            and were previously retried. The catchall swallows the failure silently,
            making the regression invisible at the namespace step.
    Fix direction: Add HTTP_CONFLICT (409) to the non_retriable_errors array in
            isRetriableError (src/IO/ReadWriteBufferFromHTTP.cpp:24). Remove the
            http_max_tries=1 override and the read_settings_override parameter entirely.
            HTTP 409 is semantically non-retriable for any REST catalog endpoint
            (state is definitively set), so the global fix is safe and more correct.
    Regression test direction: Simulate REST catalog returning Poco::Net::NetException on
            first attempt; verify namespace creation retries and succeeds on second attempt
            (current code does not retry — proposed fix restores that behavior).

Coverage summary:

Scope reviewed: RestCatalog::createNamespaceIfNotExists + sendRequest signature (2 files,
                16+/4- lines); doWithRetries retry loop and isRetriableError (full read);
                assertResponseIsOk 409 throw path; createTable caller context.
Categories failed: Transient-network retry regression (Medium)
Categories passed: HTTP 409 handling, API compat, ReadSettings thread safety,
                   exception ordering, C++ memory/race/UB/RAII (8 categories)
Assumptions/limits: Static analysis only. isRetriableError global-impact change not
                    runtime-tested. No inspection of REST catalog server's actual 409
                    response body schema.

subkanthi · 2026-07-09T12:41:22Z

New audit report after latest changes:

AI audit note: This review comment was generated by AI (claude-sonnet-4-6).

Audit update for PR #1918 (Iceberg REST catalog: handle namespaceExists 409 error):

Internal Audit Trace

Scope

Two files changed, 16 lines added / 4 deleted:

src/Databases/DataLake/RestCatalog.cpp — createNamespaceIfNotExists, sendRequest

src/Databases/DataLake/RestCatalog.h — sendRequest declaration

Call Graph
createTable
  └─ createNamespaceIfNotExists          ← changed
       └─ sendRequest(http_max_tries=1)  ← signature changed
            └─ BuilderRWBufferFromHTTP.create(credentials)
                 └─ ReadWriteBufferFromHTTP::nextImpl
                      └─ doWithRetries(callable, on_retry)   ← retry loop
                           └─ initialize → callWithRedirects → callImpl
                                └─ assertResponseIsOk → throw HTTPException(409)
Transition Matrix

Request path Before PR After PR Invariant
POST /namespaces → 201 Created sendRequest succeeds, namespace created sendRequest succeeds (http_max_tries=1, 1 attempt) ✓ preserved
POST /namespaces → 409 Conflict (namespace exists) HTTPException thrown, isRetriableError(409)=true (409 not in non_retriable_errors), retried 10× with backoff, then swallowed HTTPException(409) thrown on attempt 1, caught by catch (DB::HTTPException), LOG_DEBUG, swallowed ✓ fixed (no retry storm)
POST /namespaces → transient NetException (DNS, timeout) Retried up to 10× then swallowed by catch (...) Attempt 1 → last_attempt=true → rethrown, caught by catch (...), swallowed ✗ regression — lost retries
POST /namespaces → 5xx server error Retried up to 10× (isRetriableError(5xx)=true) then swallowed Single attempt, thrown as HTTPException, caught by catch (DB::HTTPException), non-409 → tryLogCurrentException, swallowed ✗ regression — lost retries

Key isRetriableError analysis

non_retriable_errors in ReadWriteBufferFromHTTP.cpp contains: 400, 401, 403, 404, 405, 501. HTTP 409 (HTTP_CONFLICT) is not in this list → isRetriableError(409) = true. So before this PR, 409 triggered the full retry loop (10× with backoff) — confirmed root cause.

Branch Coverage

Branch Outcome
http_max_tries=1, success path Pass
http_max_tries=1, 409 Conflict Pass — caught, swallowed correctly
http_max_tries=1, network error (Poco::Net::NetException) Fail — single try, then silently swallowed
http_max_tries=1, 5xx Fail — single try, then silently swallowed
catch (DB::HTTPException) ordering before catch (...) Pass — correct specific-before-general ordering
ReadSettings local copy (thread safety) Pass — getReadSettings() returns value, local mutation safe
std::optional<DB::ReadSettings> = std::nullopt default (API compat) Pass — all existing callers unaffected
http_max_tries=1 validation (must be ≥1) Pass — 1 > 0 satisfies check at L231
readJSONObjectPossiblyInvalid on 409 response Pass — HTTPException thrown before read

Fault Injection Matrix

Category Status Outcome Defects
HTTP 409 on namespace creation Executed Pass — caught and swallowed as intended None
HTTP 5xx on namespace creation Executed Fail-closed (no retry) — previously retried 10× Regression: lost retries
Transient network error (DNS/timeout) Executed Fail-closed (no retry) — previously retried 10× Regression: lost retries
200/201 success Executed Pass None
sendRequest API compat Executed Pass — default param preserves all callers None
ReadSettings thread safety Executed Pass — local copy None
Memory lifetime / RAII Executed Pass — no raw owning pointers, RAII throughout None
Data races / locks Executed Pass — no shared mutable state in changed paths None
Exception ordering / rollback Executed Pass — createTable proceeds regardless; namespace fail is already silent by design None
Integer overflow / signedness Executed Pass — http_max_tries = 1 is size_t, no conversion issues None
Iterator / reference invalidation N/A Not applicable — no containers mutated —

Concurrency Analysis

createTable can be called concurrently with the same namespace. After the PR:

Thread A: POST /namespaces → 201 → success

Thread B: POST /namespaces → 409 → caught and swallowed → continues correctly

This is the scenario the fix was designed for. Correct. ✓

The change introduces no new shared mutable state. read_settings is a local copy. No locks involved.

Report

Confirmed defects:
Medium: http_max_tries = 1 removes retries for ALL errors, not just HTTP 409
    Impact: A transient network error (DNS blip, TCP reset, 5xx) during namespace creation
            is no longer retried. The failure is silently swallowed, createTable proceeds,
            and the subsequent table-creation POST fails with a misleading
            DATALAKE_DATABASE_ERROR wrapping a 404-style error — not a namespace error.
            Before this PR, the same transient failure would have been retried up to 10×
            (default http_max_tries=10 in ReadSettings.h:86) before being swallowed.
    Anchor: src/Databases/DataLake/RestCatalog.cpp / createNamespaceIfNotExists
            read_settings.http_max_tries = 1  (new line in try block)
    Trigger: Brief network hiccup or DNS timeout during namespace creation on a healthy cluster.
    Why defect: The root cause of the slowness is that HTTP 409 is absent from
            isRetriableError's non_retriable_errors list, so it was retried 10×.
            Setting http_max_tries=1 is a per-callsite workaround that fixes 409 retries
            but simultaneously removes retries for Poco::Net::NetException and
            DB::NetException, which are caught by separate branches in doWithRetries
            and were previously retried. The catchall swallows the failure silently,
            making the regression invisible at the namespace step.
    Fix direction: Add HTTP_CONFLICT (409) to the non_retriable_errors array in
            isRetriableError (src/IO/ReadWriteBufferFromHTTP.cpp:24). Remove the
            http_max_tries=1 override and the read_settings_override parameter entirely.
            HTTP 409 is semantically non-retriable for any REST catalog endpoint
            (state is definitively set), so the global fix is safe and more correct.
    Regression test direction: Simulate REST catalog returning Poco::Net::NetException on
            first attempt; verify namespace creation retries and succeeds on second attempt
            (current code does not retry — proposed fix restores that behavior).
Coverage summary:
Scope reviewed: RestCatalog::createNamespaceIfNotExists + sendRequest signature (2 files,
                16+/4- lines); doWithRetries retry loop and isRetriableError (full read);
                assertResponseIsOk 409 throw path; createTable caller context.
Categories failed: Transient-network retry regression (Medium)
Categories passed: HTTP 409 handling, API compat, ReadSettings thread safety,
                   exception ordering, C++ memory/race/UB/RAII (8 categories)
Assumptions/limits: Static analysis only. isRetriableError global-impact change not
                    runtime-tested. No inspection of REST catalog server's actual 409
                    response body schema.

Fix direction: Add HTTP_CONFLICT (409) to the non_retriable_errors array in
            isRetriableError (src/IO/ReadWriteBufferFromHTTP.cpp:24). Remove the
            http_max_tries=1 override and the read_settings_override parameter entirely.
            HTTP 409 is semantically non-retriable for any REST catalog endpoint
            (state is definitively set), so the global fix is safe and more correct.

this was the easy fix, but Im not sure if this is correct, because adding 409 to the non_retriable_errors will affect all http calls(non-iceberg) the CH server will be making

Copilot

Pull request overview

Adjusts the Iceberg REST catalog client to avoid exponential-backoff retries when the catalog responds with HTTP_CONFLICT during namespace creation, addressing CREATE TABLE ... ENGINE Iceberg slowness in the 26.3 stable line.

Changes:

Extend DataLake::RestCatalog::sendRequest to accept an optional DB::ReadSettings override.
In createNamespaceIfNotExists, force http_max_tries = 1 for the namespace-creation request and explicitly treat HTTP_CONFLICT as “already exists”.
Add the necessary ReadSettings include for the new API surface.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`src/Databases/DataLake/RestCatalog.h`	Extends the protected `sendRequest` API to optionally accept per-call `DB::ReadSettings`.
`src/Databases/DataLake/RestCatalog.cpp`	Uses a one-try HTTP setting for namespace creation and handles `HTTP_CONFLICT` without triggering multi-try backoff delays.

+        DB::ReadSettings read_settings = getContext()->getReadSettings();
+        read_settings.http_max_tries = 1;
+        sendRequest(endpoint, request_body, Poco::Net::HTTPRequest::HTTP_POST, false, read_settings);


subkanthi added 2 commits June 16, 2026 23:21

Added handling of 409 namespacealreadyexists in createNamespaceIfNotE…

9d5c434

…xists

Added handling of 409 namespacealreadyexists in createNamespaceIfNotE…

d356334

…xists

subkanthi linked an issue Jun 16, 2026 that may be closed by this pull request

Create iceberg table takes too long #1907

Open

subkanthi added 2 commits June 16, 2026 23:31

rollback not required change

105f729

set http_max_tries to 1 for createNamespaceIfNotExists

9ea143f

subkanthi closed this Jun 17, 2026

subkanthi reopened this Jun 17, 2026

subkanthi marked this pull request as ready for review June 18, 2026 20:23

subkanthi changed the title ~~Added handling of 409 namespacealreadyexists in createNamespaceIfNotE…~~ Antalya 26.3: Iceberg client, handle namespaceExists error Jun 18, 2026

subkanthi commented Jun 18, 2026

View reviewed changes

Merge branch 'antalya-26.3' into 1907-create-iceberg-table-takes-too-…

c726c3f

…long

subkanthi mentioned this pull request Jun 19, 2026

Fixed iceberg alter table modify rename #1841

Open

27 tasks

subkanthi added 2 commits July 1, 2026 11:48

Merge branch 'antalya-26.3' into 1907-create-iceberg-table-takes-too-…

1b1bcab

…long

Merge branch 'antalya-26.3' into 1907-create-iceberg-table-takes-too-…

7b90126

…long

alsugiliazova added the verified Approved for release label Jul 9, 2026

alsugiliazova requested a review from Copilot July 9, 2026 14:32

Copilot started reviewing on behalf of alsugiliazova July 9, 2026 14:33 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Comment thread src/Databases/DataLake/RestCatalog.cpp

Comment on lines +1121 to +1123

DB::ReadSettings read_settings = getContext()->getReadSettings();

read_settings.http_max_tries = 1;

sendRequest(endpoint, request_body, Poco::Net::HTTPRequest::HTTP_POST, false, read_settings);

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Antalya 26.3: Iceberg client, handle namespaceExists error#1918

Antalya 26.3: Iceberg client, handle namespaceExists error#1918
subkanthi wants to merge 7 commits into
antalya-26.3from
1907-create-iceberg-table-takes-too-long

subkanthi commented Jun 16, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 16, 2026 •

edited

Loading

Uh oh!

subkanthi Jun 18, 2026 •

edited

Loading

Uh oh!

alsugiliazova commented Jul 1, 2026

Uh oh!

alsugiliazova commented Jul 1, 2026

Uh oh!

alsugiliazova commented Jul 9, 2026

Uh oh!

subkanthi commented Jul 9, 2026

Internal Audit Trace

Scope

Call Graph

Transition Matrix

Key isRetriableError analysis

Branch Coverage

Fault Injection Matrix

Concurrency Analysis

Report

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

subkanthi commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Documentation entry for user-facing changes

CI/CD Options

Exclude tests:

Regression jobs to run:

Uh oh!

github-actions Bot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

subkanthi Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alsugiliazova commented Jul 1, 2026

Audit: PR #1918 — Iceberg client: handle namespaceExists error

Confirmed Defects

Medium: http_max_tries = 1 kills retries for transient network failures, not just 409

Low: DataLakeRestCatalogCreateNamespace counter incremented before the HTTP request

Coverage Summary

Uh oh!

alsugiliazova commented Jul 1, 2026

PR #1918 CI Triage Report

Verdict

Failing checks — categorized

1. Pre-existing flaky tests (unrelated to PR)

2. Infrastructure / non-test checks (unrelated)

3. Cancelled — did not run

Recommendations

Uh oh!

alsugiliazova commented Jul 9, 2026

Internal Audit Trace

Scope

Call Graph

Transition Matrix

Key isRetriableError analysis

Branch Coverage

Fault Injection Matrix

Concurrency Analysis

Report

Uh oh!

subkanthi commented Jul 9, 2026

Internal Audit Trace

Scope

Call Graph

Transition Matrix

Key isRetriableError analysis

Branch Coverage

Fault Injection Matrix

Concurrency Analysis

Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

subkanthi commented Jun 16, 2026 •

edited

Loading

github-actions Bot commented Jun 16, 2026 •

edited

Loading

subkanthi Jun 18, 2026 •

edited

Loading

Medium: `http_max_tries = 1` kills retries for transient network failures, not just 409

Low: `DataLakeRestCatalogCreateNamespace` counter incremented before the HTTP request