Stable 25.8: stabilize Stress test (JOIN chain + concat nullability LOGICAL_ERRORs)#2019
Open
CarlosFelipeOR wants to merge 7 commits into
Open
Stable 25.8: stabilize Stress test (JOIN chain + concat nullability LOGICAL_ERRORs)#2019CarlosFelipeOR wants to merge 7 commits into
CarlosFelipeOR wants to merge 7 commits into
Conversation
CarlosFelipeOR
added
stable
cicd
CarlosFelipeOR
changed the title
CarlosFelipeOR
changed the title
The cherry-pick of ClickHouse#97316 onto antalya-25.8 had a manual conflict resolution that lost two parts of the upstream version of should_disable_parallel_replicas(): * the n-way CROSS JOIN branch (sets is_cross_join = true and consumes it next to is_full_join / is_global_join) * the explicit fallback for RIGHT JOIN with a distributed/remote right-side table (consumes is_right_join_with_remote_table) Without these reads the two variables were "set but not used", which fast-test catches as -Werror,-Wunused-but-set-variable / -Wunused-variable. Restore them verbatim from upstream/master. Co-authored-by: Cursor <cursoragent@cursor.com> (cherry picked from commit 8d40b8f)
MyroTk
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of :
Includes a follow-up fix to address issues introduced during conflict resolution and align the implementation with upstream.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Backport upstream fixes for LOGICAL_ERROR in queries with parallel replicas and multiple JOINs (LEFT/INNER...RIGHT, RIGHT...RIGHT, n-way with GLOBAL/FULL) (ClickHouse#86895, ClickHouse#87178, ClickHouse#97316 by @devcrafter)
CI/CD Options
Exclude tests:
Regression jobs to run: