Skip to content

Stable 25.8: stabilize Stress test (JOIN chain + concat nullability LOGICAL_ERRORs)#2019

Open
CarlosFelipeOR wants to merge 7 commits into
stable-25.8from
ci/fix-stress-test
Open

Stable 25.8: stabilize Stress test (JOIN chain + concat nullability LOGICAL_ERRORs)#2019
CarlosFelipeOR wants to merge 7 commits into
stable-25.8from
ci/fix-stress-test

Merge branch 'stable-25.8' into ci/fix-stress-test

fb8a546
Select commit
Loading
Failed to load commit list.
DCO-2 / DCO required action Jul 10, 2026 in 2s

Check failed

There are 5 commits incorrectly signed off, the check did not pass.

Summary


Sha Message Pass or fail reason
🔴 98a8d1b Disable join_use_nulls for 03716_multiple_joins_us... Sign-off not found
🟢 836cd8e Merge branch 'stable-25.8' into ci/fix-stress-test Skipped: sign-off not required in merge commit
🔴 5222edc Merge pull request ClickHouse#86895 from ClickHouse/fix-pr-j... Sign-off not found
🔴 c232242 Merge pull request ClickHouse#87178 from ClickHouse/fix-pr-j... Sign-off not found
🔴 aab506e Merge pull request ClickHouse#97316 from ClickHouse/pr-fix-r... Sign-off not found
🔴 339cce8 Fix unused variables left by 97316 conflict resolu... Sign-off not found
🟢 fb8a546 Merge branch 'stable-25.8' into ci/fix-stress-test Skipped: sign-off not required in merge commit

Errors details

Sign-off not found

No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.

To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

How to fix missing or invalid sign-offs

Option 1: add remediation commit

Option 2: fix commits without sign-off

Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

Warning

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~7 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin ci/fix-stress-test