Antalya 26.6 - Fix PostgreSQL server_version to be numeric-only (unblock Npgsql clients)#2034
Open
CarlosFelipeOR wants to merge 1 commit into
Open
Antalya 26.6 - Fix PostgreSQL server_version to be numeric-only (unblock Npgsql clients)#2034CarlosFelipeOR wants to merge 1 commit into
CarlosFelipeOR wants to merge 1 commit into
Conversation
…unblocking Npgsql clients Signed-off-by: CarlosFelipeOR <carlosfelipeor@gmail.com>
mkmkme
reviewed
Jul 10, 2026
| message_transport->send(PostgreSQLProtocol::Messaging::ParameterStatus("client_encoding", "UTF8")); | ||
|
|
||
| message_transport->send(PostgreSQLProtocol::Messaging::ParameterStatus("server_version", VERSION_STRING)); | ||
| /// VERSION_STRING may carry a non-numeric flavour suffix (e.g. ".altinityantalya") that .NET's System.Version.Parse rejects; keep only the leading numeric portion. |
Collaborator
There was a problem hiding this comment.
This should work, but this looks hackish.
What I'd do instead is:
- Provide a new helper
toStringNumericOnly()toClickHouseVersion.handClickHouseVersion.cpp(should to the same astoString()but ignore the suffix - Change the code here to look something like this
ClickHouseVersion server_version(VERSION_STRING);
message_transport->send(PostgreSQLProtocol::Messaging::ParameterStatus("server_version", server_version.toStringNumericOnly()))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2033
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Advertise only the numeric portion of the version in the PostgreSQL wire protocol's
server_versionparameter, so Npgsql-based .NET clients can connect to Altinity builds.Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: