Skip to content

fix(alert,toast,collapse): Correct open/close api#1285

Merged
MarkoOleksiyenko merged 2 commits into
AmadeusITGroup:mainfrom
MarkoOleksiyenko:promise
Feb 12, 2026
Merged

fix(alert,toast,collapse): Correct open/close api#1285
MarkoOleksiyenko merged 2 commits into
AmadeusITGroup:mainfrom
MarkoOleksiyenko:promise

Conversation

@MarkoOleksiyenko
Copy link
Copy Markdown
Contributor

@MarkoOleksiyenko MarkoOleksiyenko commented Feb 11, 2026

Updates the return type of the api (open/close) of alert, toast and collapse to Promise

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.89%. Comparing base (63f5310) to head (3ec0ab7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1285   +/-   ##
=======================================
  Coverage   90.89%   90.89%           
=======================================
  Files         118      118           
  Lines        3459     3459           
  Branches      554      554           
=======================================
  Hits         3144     3144           
  Misses        204      204           
  Partials      111      111           
Flag Coverage Δ
e2e 81.79% <ø> (ø)
unit 87.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MarkoOleksiyenko MarkoOleksiyenko marked this pull request as ready for review February 11, 2026 16:46
@MarkoOleksiyenko MarkoOleksiyenko merged commit f966268 into AmadeusITGroup:main Feb 12, 2026
16 checks passed
@MarkoOleksiyenko MarkoOleksiyenko deleted the promise branch February 12, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants