ci(e2e): implement comprehensive cross-platform E2E testing infrastructure#40
Draft
wherka-ama wants to merge 1 commit into
Draft
ci(e2e): implement comprehensive cross-platform E2E testing infrastructure#40wherka-ama wants to merge 1 commit into
wherka-ama wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 54.29% 54.66% +0.36%
==========================================
Files 27 27
Lines 3514 3635 +121
==========================================
+ Hits 1908 1987 +79
- Misses 1447 1485 +38
- Partials 159 163 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
997b2f4 to
e3a0911
Compare
…cture Adds end-to-end testing for all released artifacts across multiple platforms: Platform Coverage: - Linux AMD64/ARM64 binaries - Fedora AMD64/ARM64 RPM packages - Ubuntu AMD64/ARM64 DEB packages - macOS AMD64 (macos-15-intel) and ARM64 (macos-latest) binaries - Windows AMD64 (windows-latest) and ARM64 (windows-11-arm) binaries Key Fixes: - Skip Unix permission checks on Windows (ACL-based permissions) - Fix credential helper path formatting for Windows batch wrapper - Update RPM/DEB download patterns with wildcards for release numbers Infrastructure: - E2E workflow with prerelease gate pattern - Package-specific test jobs with container isolation - nfpm.yaml for .deb/.rpm packaging - Updated Makefile with packaging targets Closes AmadeusITGroup#39
e3a0911 to
70bb99e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements comprehensive cross-platform end-to-end (E2E) testing infrastructure to validate all released artifacts before promotion to latest. This PR addresses the need for automated testing across multiple OS/architecture combinations to ensure release quality.
Key Objectives:
Closes #39
Type of Change
Please delete options that are not relevant:
Changes Made
E2E Workflow (
.github/workflows/e2e.yml)Code Fixes
cmd/setup.go: Skip Unix permission checks on Windows (Windows uses ACLs, not Unix mode bits)cmd/gitconfig.go: Convert backslashes to forward slashes in Windows credential helper batch wrapper paths (prevents shell interpretation issues)Build & Packaging
nfpm.yaml: New nfpm configuration for building .deb and .rpm packagesMakefile: Added packaging targets (package,package-deb,package-rpm).gitignore: Added packaging artifact patterns.github/workflows/release.yml: Updated to trigger E2E workflow after prerelease uploadE2E Test Infrastructure
test/e2e/helpers_test.go: Added Windows temp dir helper for credential wrapper teststest/e2e/suite_test.go: Updated test configuration for multi-platform supporttest/e2e/auth_test.go: Enhanced authentication tests with proper binary path handlingtest/e2e/gitops_test.go: Streamlined Git operations teststest/e2e/install_test.go: Fixed install path verification for packaged binariesTesting
Please describe the tests that you ran to verify your changes:
go test ./...go build -o gh-app-auth .Test Configuration
E2E Test Results:
All 10 platform jobs must pass before release promotion:
Security Considerations
If this PR involves security-related changes:
Notes:
E2E_APP_ID,E2E_PRIVATE_KEY_B64,E2E_GITHUB_TOKEN)secrets.HashToken()for debug output)Documentation
Notes:
Checklist
ci(e2e): implement comprehensive cross-platform E2E testing)Breaking Changes
If this is a breaking change, please describe the impact and migration path for existing users:
None - This PR only adds CI/CD infrastructure and does not change any user-facing functionality.
Additional Notes
Known Limitations
windows-11-arm) is in public previewmacos-15-intel) are deprecated as of Dec 2025, migration to ARM64 recommended for futureFuture Work