Skip to content

feat: provide default value for enableLogging #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxokorokov merged 1 commit into from
Sep 2, 2025
Merged

feat: provide default value for enableLogging #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demos/app-angular/src/app/app.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { enableLogging } from '@amadeus-it-group/microfrontends';
export const appConfig: ApplicationConfig = {
providers: [
provideAppInitializer(() => {
enableLogging(true);
enableLogging();
}),
provideZonelessChangeDetection(),
provideRouter(routes, withHashLocation()),
Expand Down
2 changes: 1 addition & 1 deletion packages/core/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ Simple logging can be enabled via `enableLogging()` method. It will log all mess
```ts
import { enableLogging } from '@amadeus-it-group/microfrontends';

enableLogging(true);
enableLogging();
```

### Information about the network
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ let LOGGING_ENABLED = false;
* If true, tracing information to help debugging will be logged in the console
* @param enabled
*/
export function enableLogging(enabled: boolean) {
export function enableLogging(enabled = true) {
LOGGING_ENABLED = enabled;
}

Expand Down