Skip to content

feat: ama mfe message nav new version#4192

Merged
mrednic-1A merged 1 commit into
mainfrom
feat/ama-mfe-message-nav
May 11, 2026
Merged

feat: ama mfe message nav new version#4192
mrednic-1A merged 1 commit into
mainfrom
feat/ama-mfe-message-nav

Conversation

@mrednic-1A
Copy link
Copy Markdown
Contributor

Proposed change

Related issues

- No issue associated -

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Apr 30, 2026

View your CI Pipeline Execution ↗ for commit d997eb4

Command Status Duration Result
nx run-many --target=test-e2e ✅ Succeeded <1s View ↗
nx affected --target=test --coverage --configur... ✅ Succeeded <1s View ↗
nx run ama-sdk-schematics:build-swagger ✅ Succeeded 6s View ↗
nx run-many --tui=false --target=build --projec... ✅ Succeeded 1s View ↗
nx run-many --target=documentation ✅ Succeeded 2s View ↗
nx run-many --target=build,build-swagger ✅ Succeeded 29s View ↗
nx affected --target=lint --configuration ci ✅ Succeeded <1s View ↗
nx affected --target=package-github-action ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-11 12:25:09 UTC

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

❌ Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.59%. Comparing base (915f05b) to head (ba19198).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tils/src/navigation/navigation-consumer-service.ts 83.33% 0 Missing and 1 partial ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nx-cloud[bot]

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@nx-cloud nx-cloud Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ The fix was rejected

We removed the unnecessary string quotes around the 1.1 property key in NavigationConsumerService.supportedVersions, fixing the @stylistic/quote-props ESLint error introduced by the PR. The numeric key 1.1 does not require quoting, and the same unquoted style is already used for the equivalent key in RoutingService. This single-character change brings the file into compliance without altering any runtime behaviour.

Warning

We could not verify this fix.

Suggested Fix changes
diff --git a/packages/@ama-mfe/ng-utils/src/navigation/navigation-consumer-service.ts b/packages/@ama-mfe/ng-utils/src/navigation/navigation-consumer-service.ts
index cb2291daf..95465efcc 100644
--- a/packages/@ama-mfe/ng-utils/src/navigation/navigation-consumer-service.ts
+++ b/packages/@ama-mfe/ng-utils/src/navigation/navigation-consumer-service.ts
@@ -71,7 +71,7 @@ export class NavigationConsumerService implements MessageConsumer<NavigationMess
      * so the host router reproduces the original history semantics.
      * @param message message to consume
      */
-    '1.1': (message: RoutedMessage<NavigationV1_1>) => {
+    1.1: (message: RoutedMessage<NavigationV1_1>) => {
       const channelId = message.from || undefined;
       this.requestedUrl.next({ url: message.payload.url, channelId });
       this.navigate(message.payload.url, message.payload.extras);

View interactive diff ↗



🎓 Learn more about Self-Healing CI on nx.dev

@mrednic-1A mrednic-1A force-pushed the feat/ama-mfe-message-nav branch from 996089e to 591c8db Compare May 4, 2026 10:33
@mrednic-1A mrednic-1A marked this pull request as ready for review May 4, 2026 11:57
@mrednic-1A mrednic-1A requested a review from a team as a code owner May 4, 2026 11:57
Comment thread packages/@ama-mfe/ng-utils/src/navigation/navigation-consumer-service.ts Outdated
Comment thread packages/@ama-mfe/ng-utils/src/navigation/routing-service.ts
@mrednic-1A mrednic-1A force-pushed the feat/ama-mfe-message-nav branch from 591c8db to eb7a96e Compare May 4, 2026 14:26
Comment thread packages/@ama-mfe/messages/src/messages/navigation/navigation-versions.ts Outdated
Comment thread packages/@ama-mfe/ng-utils/src/managers/consumer-manager-service.ts Outdated
@mrednic-1A mrednic-1A changed the title Feat/ama mfe message nav feat: ama mfe message nav May 4, 2026
@mrednic-1A mrednic-1A changed the title feat: ama mfe message nav feat: ama mfe message nav new version May 4, 2026
@mrednic-1A mrednic-1A force-pushed the feat/ama-mfe-message-nav branch 2 times, most recently from fc8bb6d to afe6fdb Compare May 5, 2026 13:29
Comment thread packages/@ama-mfe/messages/src/messages/core.ts Outdated
Comment thread packages/@ama-mfe/ng-utils/src/managers/consumer-manager-service.ts Outdated
Comment thread packages/@ama-mfe/ng-utils/src/managers/consumer-manager-service.ts Outdated
Comment thread packages/@ama-mfe/ng-utils/src/managers/consumer-manager-service.ts Outdated
Comment thread packages/@ama-mfe/ng-utils/src/managers/consumer-manager-service.ts Outdated
@mrednic-1A mrednic-1A force-pushed the feat/ama-mfe-message-nav branch 2 times, most recently from f3c404d to 9656603 Compare May 7, 2026 14:12
@mrednic-1A mrednic-1A force-pushed the feat/ama-mfe-message-nav branch from 9656603 to d997eb4 Compare May 11, 2026 12:09
@mrednic-1A mrednic-1A enabled auto-merge May 11, 2026 12:09
@mrednic-1A mrednic-1A added this pull request to the merge queue May 11, 2026
@mrednic-1A mrednic-1A removed this pull request from the merge queue due to a manual request May 11, 2026
@mrednic-1A mrednic-1A force-pushed the feat/ama-mfe-message-nav branch from d997eb4 to ba19198 Compare May 11, 2026 12:18
@mrednic-1A mrednic-1A enabled auto-merge May 11, 2026 12:18
@mrednic-1A mrednic-1A added this pull request to the merge queue May 11, 2026
Merged via the queue into main with commit c86faae May 11, 2026
31 checks passed
@mrednic-1A mrednic-1A deleted the feat/ama-mfe-message-nav branch May 11, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants