feat: ama mfe message nav new version#4192
Conversation
|
View your CI Pipeline Execution ↗ for commit d997eb4
☁️ Nx Cloud last updated this comment at |
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
❌ The fix was rejected
We removed the unnecessary string quotes around the 1.1 property key in NavigationConsumerService.supportedVersions, fixing the @stylistic/quote-props ESLint error introduced by the PR. The numeric key 1.1 does not require quoting, and the same unquoted style is already used for the equivalent key in RoutingService. This single-character change brings the file into compliance without altering any runtime behaviour.
Warning
❌ We could not verify this fix.
Suggested Fix changes
diff --git a/packages/@ama-mfe/ng-utils/src/navigation/navigation-consumer-service.ts b/packages/@ama-mfe/ng-utils/src/navigation/navigation-consumer-service.ts
index cb2291daf..95465efcc 100644
--- a/packages/@ama-mfe/ng-utils/src/navigation/navigation-consumer-service.ts
+++ b/packages/@ama-mfe/ng-utils/src/navigation/navigation-consumer-service.ts
@@ -71,7 +71,7 @@ export class NavigationConsumerService implements MessageConsumer<NavigationMess
* so the host router reproduces the original history semantics.
* @param message message to consume
*/
- '1.1': (message: RoutedMessage<NavigationV1_1>) => {
+ 1.1: (message: RoutedMessage<NavigationV1_1>) => {
const channelId = message.from || undefined;
this.requestedUrl.next({ url: message.payload.url, channelId });
this.navigate(message.payload.url, message.payload.extras);
🎓 Learn more about Self-Healing CI on nx.dev
996089e to
591c8db
Compare
591c8db to
eb7a96e
Compare
fc8bb6d to
afe6fdb
Compare
f3c404d to
9656603
Compare
9656603 to
d997eb4
Compare
d997eb4 to
ba19198
Compare
Proposed change
Related issues
- No issue associated -