chore: clean remaining ruff/mypy findings and enforce lint in CI#10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the lint/type cleanup and adds enforcement.
threshold_policy and evaluate; float64 cast on rounded risk
scores). mypy now reports 0 errors.
with # noqa: E402 on app.py's post-sys.path imports, and convert
4 SIM108 if/else blocks to ternaries.
lintjob running ruff, black --check, and mypy.Verified locally (clean env, linters only):
(md5 match) and threshold_policy.md is byte-identical, confirming
the string-split and astype edits are no-ops at runtime.
Note: the SHAP-path SIM108 edits run only at runtime/CI (shap not
installed locally); they are equivalent ternary rewrites and both
files compile.