perf: iterate reason codes via to_dict('records') instead of iterrows#13
Merged
AmirhosseinHonardoust merged 1 commit intoJun 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add_reason_codes iterated rows with DataFrame.iterrows(), which builds
a pandas Series per row, and reason_codes_for_row then re-wrapped each
row in pd.Series. Both are unnecessary: the logic only uses row.get(),
which dicts support directly.
now accepts a Series or any mapping unchanged.
No behavior change (O(n) before and after; this is a constant-factor
speedup, not an algorithmic fix).
Verified locally:
rows of the scored test set; full scored CSV byte-identical (md5
unchanged).