Don't delete PCR4 from maps.#81
Merged
Merged
Conversation
So far, the code would delete PCR4 from the given maps. That worked because we have been ignoring PCR4 but it's a dirty hack. This PR changes `Equal` to not modify the given maps.
There was a problem hiding this comment.
Pull request overview
This PR updates PCR map equality checking in internal/enclave so that PCR.Equal no longer mutates its input maps while continuing to ignore PCR4 (which is runtime-dependent).
Changes:
- Reworked
PCR.Equalto ignore PCR4 without deleting keys from either map. - Added a small helper (
pcrLen) to compare map sizes while excluding PCR4. - Updated/expanded unit tests to cover PCR4 being present on only one side.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/enclave/pcr.go | Stops mutating input PCR maps in Equal by skipping PCR4 during comparison and length checks. |
| internal/enclave/pcr_test.go | Updates equality test cases to reflect PCR4 being ignored even when only present in one map. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, the code would delete PCR4 from the given maps. That worked because we have been ignoring PCR4 but it's a dirty hack. This PR changes
Equalto not modify the given maps.