Skip to content

Commit 2e07164

Browse files
fix: correct decorator order for deprecated _advance_pointer property and update tests to use public API
1 parent 92b8f7b commit 2e07164

2 files changed

Lines changed: 8 additions & 9 deletions

File tree

src/amrita_sense/runtime/workflow.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -407,12 +407,11 @@ async def run_step_by(self) -> AsyncGenerator[Any, None]:
407407
self._ret_addr_stack.clear()
408408
self._pointer.clear()
409409
self._jump_marked = False
410-
410+
@property
411411
@deprecated(
412412
"Method of `_advance_pointer` is now `advance_pointer`, this compile method will be removed in `v0.3.0`",
413413
category=DeprecationWarning,
414414
)
415-
@property
416415
def _advance_pointer(self):
417416
return self.advance_pointer
418417

tests/test_runtime.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ def simple_node():
197197
interpreter = WorkflowInterpreter(rendered)
198198
interpreter._pointer = PointerVector([0])
199199

200-
assert interpreter._advance_pointer()
200+
assert interpreter.advance_pointer()
201201
assert interpreter._pointer == PointerVector([1, 0])
202202

203203
def test_advance_pointer_backtrack_to_nested_sibling(self):
@@ -211,7 +211,7 @@ def simple_node():
211211
interpreter = WorkflowInterpreter(rendered)
212212
interpreter._pointer = PointerVector([0, 0])
213213

214-
assert interpreter._advance_pointer()
214+
assert interpreter.advance_pointer()
215215
assert interpreter._pointer == PointerVector([1, 0])
216216

217217
@pytest.mark.asyncio
@@ -279,10 +279,10 @@ def simple_node():
279279

280280
interpreter = WorkflowInterpreter(NodeCompose(simple_node).render())
281281
interpreter._pointer = PointerVector()
282-
assert not interpreter._advance_pointer()
282+
assert not interpreter.advance_pointer()
283283

284284
interpreter._pointer = PointerVector([0, 0])
285-
assert not interpreter._advance_pointer()
285+
assert not interpreter.advance_pointer()
286286

287287
def test_advance_pointer_nested_and_backtrack(self):
288288
@NodeDecorator()
@@ -293,11 +293,11 @@ def simple_node():
293293
interpreter = WorkflowInterpreter(rendered)
294294

295295
interpreter._pointer = PointerVector([0])
296-
assert interpreter._advance_pointer()
296+
assert interpreter.advance_pointer()
297297
assert interpreter._pointer == PointerVector([0, 0])
298298

299299
interpreter._pointer = PointerVector([0, 0])
300-
assert interpreter._advance_pointer()
300+
assert interpreter.advance_pointer()
301301
assert interpreter._pointer == PointerVector([1])
302302

303303
def test_advance_pointer_backtrack_from_nested_end(self):
@@ -309,4 +309,4 @@ def simple_node():
309309
interpreter = WorkflowInterpreter(rendered)
310310
interpreter._pointer = PointerVector([0, 0])
311311

312-
assert not interpreter._advance_pointer()
312+
assert not interpreter.advance_pointer()

0 commit comments

Comments
 (0)