Skip to content

Commit 0a7becc

Browse files
committed
Fix 3 CodeRabbit issues from PR review
- ship/SKILL.md: Add Edit, Write to allowed-tools so Phase 5 "Fix Selected Items" can actually modify files - pr-review/SKILL.md: Fix broken grep invocation where glob patterns after -- were treated as filenames instead of filtering stdin - README.md: Add `text` language tag to 3 unlabelled fenced code blocks (markdownlint MD040)
1 parent 80e7730 commit 0a7becc

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

.devcontainer/plugins/devs-marketplace/plugins/git-workflow/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Provides two slash commands for shipping code and reviewing pull requests.
1717

1818
### `/ship` Workflow
1919

20-
```
20+
```text
2121
/ship [optional commit message hint]
2222
2323
└─→ Gather context (git status, diff, branch, project rules)
@@ -38,7 +38,7 @@ Provides two slash commands for shipping code and reviewing pull requests.
3838

3939
### `/pr:review` Workflow
4040

41-
```
41+
```text
4242
/pr:review [PR number, URL, or omit for auto-detect]
4343
4444
└─→ Identify target PR (argument, auto-detect, or ask)
@@ -106,7 +106,7 @@ Use this plugin in any Claude Code setup:
106106

107107
## Plugin Structure
108108

109-
```
109+
```text
110110
git-workflow/
111111
├── .claude-plugin/
112112
│ └── plugin.json # Plugin metadata

.devcontainer/plugins/devs-marketplace/plugins/git-workflow/skills/pr-review/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ For each significant feature in the PR:
7878
```bash
7979
# Check for new dependencies (adapt patterns to project)
8080
gh pr diff $PR | grep -E '^\+.*"(dependencies|devDependencies)"' -A 50
81-
gh pr diff $PR | grep -E '^\+' -- "**/requirements*.txt" "**/package*.json" "**/Cargo.toml" "**/go.mod" "**/Gemfile" 2>/dev/null
81+
gh pr diff $PR | grep -E '^\+' | grep -E 'requirements.*\.txt|package.*\.json|Cargo\.toml|go\.mod|Gemfile'
8282
```
8383

8484
| Check | Look For |

.devcontainer/plugins/devs-marketplace/plugins/git-workflow/skills/ship/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
description: Review changes, commit with detailed message, push, and optionally create pull request
33
argument-hint: [commit message hint]
44
disable-model-invocation: true
5-
allowed-tools: Bash(gh:*), Bash(git:*), Read, Grep, Glob, AskUserQuestion
5+
allowed-tools: Bash(gh:*), Bash(git:*), Read, Grep, Glob, Edit, Write, AskUserQuestion
66
---
77

88
# /ship - Review, Commit, Push & Optional PR

0 commit comments

Comments
 (0)