Merge pull request #27 from AnExiledDev/fix/ccstatusline-deployment

Fix ccstatusline config not deploying after .claude location move

Author: AnExiledDev

.devcontainer/CHANGELOG.md

@@ -52,6 +52,23 @@
 
 ### Fixed
 
+#### CCStatusLine Deployment
+- **`CONFIG_SOURCE_DIR` deprecation guard** — `setup.sh` now detects stale `CONFIG_SOURCE_DIR=/workspaces/.claude` in `.env`, overrides to `$DEVCONTAINER_DIR/config`, and auto-comments the line on disk; the wrong path caused `setup-config.sh` to skip the file manifest entirely, leaving ccstatusline (and all manifest-based configs) undeployed
+- **System template directory permissions** — `install.sh` now chowns `/usr/local/share/ccstatusline/` to the target user so `setup-config.sh` can write the template file during post-start
+- **Silent copy failures** — `setup-config.sh` now reports warnings when file deployment fails instead of logging success after a failed `cp`
+
+#### Post-Integration Review Fixes
+- **skill-engine** — worktree skill definition uses weighted tuples (was plain strings, caused crash)
+- **dangerous-command-blocker** — fail closed on unexpected exceptions (was fail-open)
+- **ticket-workflow** — remove redundant `ValueError` from exception handlers
+- **workspace-scope-guard** — use maxsplit in variable assignment detection
+- **Shell scripts** — add executable bit to `check-setup.sh`, quote `PLUGIN_BLACKLIST` variable, add `set -uo pipefail` to tmux installer, replace deprecated `which` with `command -v`, normalize `&>` redirects in setup scripts
+- **Documentation** — update agent count to 21, skill count to 38, plugin count to 14 across all docs site pages
+- **Documentation** — add missing plugin pages for git-workflow and prompt-snippets
+- **Documentation** — add `cc-orc` and `dbr` to commands reference
+- **Documentation** — remove merge conflict marker from first-session.md
+- **Documentation** — update architecture.md directory tree with new plugins
+
 #### CodeRabbit Review Fixes
 - **`implementer.md`** — changed PostToolUse hook (fires every Edit) to Stop hook (fires once at task end) with 120s timeout; prevents redundant test runs during multi-file tasks
 - **`tester.md`** — increased Stop hook timeout from 30s to 120s to accommodate larger test suites

.devcontainer/connect-external-terminal.sh

@@ -49,7 +49,7 @@ echo "Found container: $CONTAINER_NAME ($CONTAINER_ID)"
 echo ""
 
 # Check if tmux is available in the container
-if ! docker exec "$CONTAINER_ID" which tmux >/dev/null 2>&1; then
+if ! docker exec "$CONTAINER_ID" command -v tmux >/dev/null 2>&1; then
 	echo "ERROR: tmux is not installed in the container."
 	echo "Rebuild the devcontainer to install the tmux feature."
 	exit 1

.devcontainer/features/ccstatusline/install.sh

@@ -77,6 +77,7 @@ echo "[ccstatusline] Widget config managed by file-manifest.json"
 # Create directories so wrapper doesn't fail before first post-start
 mkdir -p "${USER_HOME}/.config/ccstatusline"
 mkdir -p /usr/local/share/ccstatusline
+chown "${USERNAME}:${USERNAME}" /usr/local/share/ccstatusline
 chown "${USERNAME}:${USERNAME}" "${USER_HOME}/.config/ccstatusline" 2>/dev/null || true
 
 # Create session resume helper script for custom-command widget

.devcontainer/features/tmux/install.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 # SPDX-License-Identifier: GPL-3.0-only
 # Copyright (c) 2026 Marcus Krueger
-set -e
+set -euo pipefail
 
 VERSION="${VERSION:-latest}"
 

.devcontainer/plugins/devs-marketplace/plugins/dangerous-command-blocker/scripts/block-dangerous.py

@@ -127,9 +127,9 @@ def main():
         # Fail closed: can't parse means can't verify safety
         sys.exit(2)
     except Exception as e:
-        # Log error but don't block on hook failure
+        # Fail closed: unexpected errors should block, not allow
         print(f"Hook error: {e}", file=sys.stderr)
-        sys.exit(0)
+        sys.exit(2)
 
 
 if __name__ == "__main__":

.devcontainer/plugins/devs-marketplace/plugins/skill-engine/scripts/skill-suggester.py

@@ -546,18 +546,19 @@
     },
     "worktree": {
         "phrases": [
-            "create a worktree",
-            "work in a worktree",
-            "git worktree",
-            "worktree",
-            "parallel branches",
-            "isolate my work",
-            "clean up worktrees",
-            "list worktrees",
-            "set up a worktree",
-            "enter worktree",
+            ("create a worktree", 0.9),
+            ("work in a worktree", 0.8),
+            ("git worktree", 0.9),
+            ("worktree", 0.7),
+            ("parallel branches", 0.6),
+            ("isolate my work", 0.5),
+            ("clean up worktrees", 0.8),
+            ("list worktrees", 0.7),
+            ("set up a worktree", 0.8),
+            ("enter worktree", 0.8),
         ],
         "terms": ["worktree", "EnterWorktree", "WorktreeCreate"],
+        "priority": 5,
     },
 }
 

.devcontainer/plugins/devs-marketplace/plugins/ticket-workflow/scripts/ticket-linker.py

@@ -71,7 +71,7 @@ def fetch_ticket(number: int) -> str | None:
 
     try:
         data = json.loads(result.stdout)
-    except (json.JSONDecodeError, ValueError):
+    except json.JSONDecodeError:
         return None
 
     title = data.get("title", "(no title)")
@@ -103,7 +103,7 @@ def main():
 
     try:
         data = json.loads(raw)
-    except (json.JSONDecodeError, ValueError):
+    except json.JSONDecodeError:
         sys.exit(0)
 
     prompt = data.get("prompt", "")

.devcontainer/plugins/devs-marketplace/plugins/workspace-scope-guard/scripts/guard-workspace-scope.py

@@ -157,7 +157,7 @@ def extract_primary_command(command: str) -> str:
     while i < len(tokens):
         tok = tokens[i]
         # Skip inline variable assignments: VAR=value
-        if "=" in tok and not tok.startswith("-") and tok.split("=")[0].isidentifier():
+        if "=" in tok and not tok.startswith("-") and tok.split("=", 1)[0].isidentifier():
             i += 1
             continue
         # Skip sudo and its flags

.devcontainer/scripts/check-setup.sh

@@ -98,21 +98,30 @@ jq -r '.[] | [.src, .dest, (.destFilename // "__NONE__"), (.enabled // true | to
 		# Apply overwrite strategy
 		case "$overwrite" in
 		always)
-			cp "$src_path" "$dest_path"
-			log "Copied $src → $dest_path (always)"
+			if cp "$src_path" "$dest_path" 2>/dev/null; then
+				log "Copied $src → $dest_path (always)"
+			else
+				warn "Failed to copy $src → $dest_path (permission denied?)"
+			fi
 			;;
 		never)
 			if [ ! -f "$dest_path" ]; then
-				cp "$src_path" "$dest_path"
-				log "Copied $src → $dest_path (new)"
+				if cp "$src_path" "$dest_path" 2>/dev/null; then
+					log "Copied $src → $dest_path (new)"
+				else
+					warn "Failed to copy $src → $dest_path (permission denied?)"
+				fi
 			else
 				log "Skipping $src (exists, overwrite=never)"
 			fi
 			;;
 		if-changed | *)
 			if should_copy "$src_path" "$dest_path"; then
-				cp "$src_path" "$dest_path"
-				log "Copied $src → $dest_path (changed)"
+				if cp "$src_path" "$dest_path" 2>/dev/null; then
+					log "Copied $src → $dest_path (changed)"
+				else
+					warn "Failed to copy $src → $dest_path (permission denied?)"
+				fi
 			else
 				log "Skipping $src (unchanged)"
 			fi