Skip to content

Commit 20d1763

Browse files
committed
fix(container): resolve all biome lint errors in setup.js and test.js
1 parent 763231e commit 20d1763

2 files changed

Lines changed: 53 additions & 18 deletions

File tree

container/setup.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -591,7 +591,7 @@ function configApply() {
591591
);
592592
if (!destAllowed) {
593593
console.log(
594-
" Skip: " + entry.dest + " (destination outside allowed directories)",
594+
` Skip: ${entry.dest} (destination outside allowed directories)`,
595595
);
596596
skipped++;
597597
continue;
@@ -602,7 +602,7 @@ function configApply() {
602602
fs.mkdirSync(destDir, { recursive: true });
603603

604604
if (entry.overwrite === "never" && fs.existsSync(destPath)) {
605-
console.log(" Skip: " + filename + " (exists, overwrite=never)");
605+
console.log(` Skip: ${filename} (exists, overwrite=never)`);
606606
skipped++;
607607
continue;
608608
}
@@ -622,18 +622,18 @@ function configApply() {
622622
fs.existsSync(destPath) &&
623623
mergeSettingsFile(srcPath, destPath)
624624
) {
625-
console.log(" Deployed: " + entry.src + " → " + destPath + " (merged)");
625+
console.log(` Deployed: ${entry.src}${destPath} (merged)`);
626626
deployed++;
627627
} else {
628628
fs.copyFileSync(srcPath, destPath);
629-
console.log(" Deployed: " + entry.src + " → " + destPath);
629+
console.log(` Deployed: ${entry.src}${destPath}`);
630630
deployed++;
631631
}
632632
}
633633

634634
console.log("");
635635
console.log(
636-
"Config apply complete: " + deployed + " deployed, " + skipped + " skipped",
636+
`Config apply complete: ${deployed} deployed, ${skipped} skipped`,
637637
);
638638
}
639639

@@ -654,7 +654,7 @@ function mergeSettingsFile(srcPath, destPath) {
654654
}
655655
}
656656

657-
fs.writeFileSync(destPath, JSON.stringify(merged, null, 2) + "\n");
657+
fs.writeFileSync(destPath, `${JSON.stringify(merged, null, 2)}\n`);
658658
return true;
659659
} catch {
660660
return false;

container/test.js

Lines changed: 47 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,14 @@ assert(
124124
"package does not publish a .codeforge defaults tree",
125125
);
126126

127-
const scaffoldDir = fs.mkdtempSync(path.join(os.tmpdir(), "codeforge-scaffold-"));
127+
const scaffoldDir = fs.mkdtempSync(
128+
path.join(os.tmpdir(), "codeforge-scaffold-"),
129+
);
128130
ensureCodeforgeScaffold(scaffoldDir);
129-
assert(fs.existsSync(path.join(scaffoldDir, "README.md")), "scaffold writes README");
131+
assert(
132+
fs.existsSync(path.join(scaffoldDir, "README.md")),
133+
"scaffold writes README",
134+
);
130135
assert(
131136
fs.existsSync(path.join(scaffoldDir, ".markers")),
132137
"scaffold creates marker directory",
@@ -146,10 +151,19 @@ assert(
146151
"generateChecksums returns SHA-256 hex values",
147152
);
148153

149-
const generatorMarkerDir = fs.mkdtempSync(path.join(os.tmpdir(), "codeforge-marker-"));
154+
const generatorMarkerDir = fs.mkdtempSync(
155+
path.join(os.tmpdir(), "codeforge-marker-"),
156+
);
150157
execFileSync(
151158
process.execPath,
152-
[path.join(root, ".devcontainer", "scripts", "generate-settings-profiles.js")],
159+
[
160+
path.join(
161+
root,
162+
".devcontainer",
163+
"scripts",
164+
"generate-settings-profiles.js",
165+
),
166+
],
153167
{
154168
cwd: root,
155169
stdio: "inherit",
@@ -161,7 +175,9 @@ execFileSync(
161175
},
162176
);
163177

164-
const generatedDefault = readJson(path.join(generatedSettingsDir, "settings.json"));
178+
const generatedDefault = readJson(
179+
path.join(generatedSettingsDir, "settings.json"),
180+
);
165181
const generatedOpus46 = readJson(
166182
path.join(generatedSettingsDir, "settings-opus-46-200k.json"),
167183
);
@@ -194,12 +210,16 @@ for (const output of [
194210
);
195211
}
196212
assert(
197-
fs.existsSync(path.join(generatorMarkerDir, ".markers", "settings-generated-v3")),
213+
fs.existsSync(
214+
path.join(generatorMarkerDir, ".markers", "settings-generated-v3"),
215+
),
198216
"settings generator writes v3 marker",
199217
);
200218
fs.rmSync(generatorMarkerDir, { recursive: true, force: true });
201219

202-
const legacyProfileDir = fs.mkdtempSync(path.join(os.tmpdir(), "codeforge-legacy-profile-"));
220+
const legacyProfileDir = fs.mkdtempSync(
221+
path.join(os.tmpdir(), "codeforge-legacy-profile-"),
222+
);
203223
const legacyOverrideDir = path.join(
204224
legacyProfileDir,
205225
"claude",
@@ -209,7 +229,7 @@ const legacyOverrideDir = path.join(
209229
fs.mkdirSync(legacyOverrideDir, { recursive: true });
210230
fs.writeFileSync(
211231
path.join(legacyOverrideDir, "opus-46-200k.json"),
212-
JSON.stringify(
232+
`${JSON.stringify(
213233
{
214234
model: "claude-opus-4-6",
215235
autoCompactWindow: 200000,
@@ -220,11 +240,18 @@ fs.writeFileSync(
220240
},
221241
null,
222242
"\t",
223-
) + "\n",
243+
)}\n`,
224244
);
225245
execFileSync(
226246
process.execPath,
227-
[path.join(root, ".devcontainer", "scripts", "generate-settings-profiles.js")],
247+
[
248+
path.join(
249+
root,
250+
".devcontainer",
251+
"scripts",
252+
"generate-settings-profiles.js",
253+
),
254+
],
228255
{
229256
cwd: root,
230257
stdio: "inherit",
@@ -246,8 +273,12 @@ fs.rmSync(legacyProfileDir, { recursive: true, force: true });
246273

247274
const manifest = readJson(path.join(defaultsDir, "file-manifest.json"));
248275
assert(manifest.length > 0, "default manifest has entries");
249-
assert(manifest.every((entry) => entry.id), "default manifest entries have stable ids");
250276
assert(
277+
manifest.every((entry) => entry.id),
278+
"default manifest entries have stable ids",
279+
);
280+
assert(
281+
// biome-ignore lint/suspicious/noTemplateCurlyInString: literal env var placeholder
251282
manifest.find((entry) => entry.id === "claude.state")?.dest === "${HOME}",
252283
"Claude state deploys to home directory",
253284
);
@@ -256,6 +287,7 @@ const merged = mergeManifestEntries(manifest, [
256287
{
257288
id: "custom.example",
258289
src: "claude/system-prompts/main.md",
290+
// biome-ignore lint/suspicious/noTemplateCurlyInString: literal env var placeholder
259291
dest: "${CLAUDE_CONFIG_DIR}",
260292
overwrite: "if-changed",
261293
},
@@ -286,7 +318,10 @@ assert(
286318
"v3 migration script writes marker and report",
287319
);
288320

289-
const setupScript = fs.readFileSync(path.join(root, ".devcontainer", "scripts", "setup.sh"), "utf8");
321+
const setupScript = fs.readFileSync(
322+
path.join(root, ".devcontainer", "scripts", "setup.sh"),
323+
"utf8",
324+
);
290325
assert(
291326
setupScript.includes("setup-migrate-codeforge-v3.sh") &&
292327
setupScript.includes("ensure-settings-generated.sh"),

0 commit comments

Comments
 (0)