Skip to content

Commit 29007f5

Browse files
committed
Address CodeRabbit review feedback
- Use POSIX-compatible case/esac in /etc/profile.d/bun.sh (was bash-only [[]]) - Make changelog Bun entry user-focused (result over mechanism) - Comment out Rust in docs configuration.md example to match devcontainer.json
1 parent bc65519 commit 29007f5

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

.devcontainer/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
### Fixed
3131

3232
#### Bun
33-
- Bun PATH not available in non-interactive shells — added `/etc/profile.d/bun.sh` via postStart hook
33+
- Bun PATH not available in non-interactive shells — Bun is now accessible in all shell contexts
3434

3535
#### Session Context Plugin
3636
- **Commit reminder** no longer blocks Claude from stopping — switched from `decision: "block"` to advisory `systemMessage` wrapped in `<system-reminder>` tags

.devcontainer/scripts/setup.sh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -166,9 +166,10 @@ fi
166166
if [ -d "/home/vscode/.bun/bin" ] && [ ! -f /etc/profile.d/bun.sh ]; then
167167
sudo tee /etc/profile.d/bun.sh > /dev/null <<'BUNEOF'
168168
export BUN_INSTALL="/home/vscode/.bun"
169-
if [[ "${PATH}" != *"${BUN_INSTALL}/bin"* ]]; then
170-
export PATH="${BUN_INSTALL}/bin:${PATH}"
171-
fi
169+
case ":${PATH}:" in
170+
*:"${BUN_INSTALL}/bin":*) ;;
171+
*) export PATH="${BUN_INSTALL}/bin:${PATH}" ;;
172+
esac
172173
BUNEOF
173174
sudo chmod +x /etc/profile.d/bun.sh
174175
fi

docs/src/content/docs/customization/configuration.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ DevContainer features install runtimes and tools. CodeForge pins external featur
184184
{
185185
"features": {
186186
"ghcr.io/devcontainers/features/node:1.7.1": { "version": "lts" },
187-
"ghcr.io/devcontainers/features/rust:1.5.0": { "version": "latest" },
187+
// "ghcr.io/devcontainers/features/rust:1.5.0": { "version": "latest" }, // Opt-in
188188
"ghcr.io/anthropics/devcontainer-features/claude-code:1.0.5": {},
189189
"./features/ruff": { "version": "latest" },
190190
// "./features/ccms": {} // Currently disabled — replacement pending

0 commit comments

Comments
 (0)