Skip to content

Commit 50a1ba6

Browse files
committed
Address third-round review items
- documenter: distinguish blocking ambiguity (scope, audience, approval) from non-blocking ambiguity (unclear code → TODO: verify), resolving contradiction between MUST-stop protocol and continue-with-TODO rule - documenter: clarify that hand-written usage examples are encouraged while verbatim source reproduction is forbidden - security-auditor: explicitly state basic dependency scanning is included in comprehensive audits, improving routing clarity
1 parent 65bdb70 commit 50a1ba6

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

.devcontainer/plugins/devs-marketplace/plugins/agent-system/agents/documenter.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,14 @@ You are a subagent reporting to an orchestrator. You do NOT interact with the us
4949

5050
### When You Hit an Ambiguity
5151

52-
If you encounter ANY of these situations, you MUST stop and return:
53-
- Multiple valid ways to document or structure the content
52+
If you encounter correctness-affecting ambiguity, you MUST stop and return:
5453
- Unclear target audience for the documentation
55-
- Missing information about feature behavior or design decisions
5654
- Unclear spec scope (what's in vs. out)
5755
- Requirements that could be interpreted multiple ways
5856
- A decision about spec approval status that requires user input
5957

58+
For non-blocking ambiguity (e.g., unclear code behavior, multiple valid doc structures), document only what you can verify and flag gaps with `TODO: verify` — do not stop.
59+
6060
### How to Surface Questions
6161

6262
1. STOP working immediately — do not proceed with an assumption
@@ -329,7 +329,7 @@ Use direct, measured language. Avoid superlatives or unqualified claims.
329329
- **NEVER** modify source code logic, business rules, or application behavior — your edits to source files are limited exclusively to documentation comments (docstrings, JSDoc, `///` doc comments, inline `//` comments).
330330
- **NEVER** change function signatures, variable names, control flow, or any executable code.
331331
- **NEVER** document aspirational behavior — only verified, actual behavior.
332-
- **NEVER** reproduce source code, SQL schemas, or type definitions in documentation files — reference file paths instead. The code is the source of truth; copied snippets rot.
332+
- **NEVER** reproduce verbatim source code, SQL schemas, or type definitions in documentation files — reference file paths instead. The code is the source of truth; copied snippets rot. Hand-written usage examples (request/response pairs, CLI invocations, API calls) are encouraged — these illustrate behavior without duplicating implementation.
333333
- **NEVER** create documentation that will immediately go stale — link to source files.
334334
- **NEVER** write specs longer than ~300 lines — split by feature boundary.
335335
- **NEVER** upgrade `[assumed]` to `[user-approved]` without explicit user confirmation.

.devcontainer/plugins/devs-marketplace/plugins/agent-system/agents/security-auditor.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,10 @@ description: >-
88
"review auth security", "find hardcoded credentials", "OWASP review",
99
"security check", "code review for security", "check for injection",
1010
"review access control", or needs a security assessment of code patterns,
11-
auth flows, or input handling. Focuses primarily on CODE-LEVEL security.
12-
For dedicated dependency/package vulnerability analysis, prefer
13-
dependency-analyst.
11+
auth flows, or input handling. Focuses primarily on CODE-LEVEL security
12+
and includes basic dependency scanning as part of comprehensive audits.
13+
For dedicated dependency analysis or supply-chain investigations,
14+
prefer dependency-analyst.
1415
Reports findings with severity ratings and remediation guidance without
1516
modifying any files. Do not use for fixing vulnerabilities or
1617
implementing security changes — audit and reporting only.

0 commit comments

Comments
 (0)