Skip to content

Commit 65bdb70

Browse files
committed
Address second-round review items
- security-auditor: soften dependency boundary from "use X instead" to "prefer X" — agent still has A06 dependency tooling for surface-level checks, which doesn't conflict with a preference statement - dependency-analyst: add Ruby/Gem ecosystem to description (agent already supports Gemfile scanning) - documenter: add `bash` language identifier to fenced code block - generalist: refine Question Surfacing Protocol to distinguish correctness-affecting ambiguity (STOP) from minor ambiguity (proceed with documented assumption)
1 parent 3272a04 commit 65bdb70

File tree

4 files changed

+10
-7
lines changed

4 files changed

+10
-7
lines changed

.devcontainer/plugins/devs-marketplace/plugins/agent-system/agents/dependency-analyst.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ description: >-
88
packages", "audit dependencies", "check dependency health", "license check",
99
"are my dependencies up to date", "npm audit", "pip audit", "cargo audit",
1010
"supply chain risk", "check for CVEs", or needs any dependency analysis
11-
across Node.js, Python, Rust, or Go ecosystems. Focuses on PACKAGES and
11+
across Node.js, Python, Rust, Ruby, or Go ecosystems. Focuses on PACKAGES and
1212
their versions — for code-level security review (injection, auth, secrets),
1313
use security-auditor instead. Reports findings without modifying any files.
1414
Do not use for installing, upgrading, or modifying dependencies — analysis

.devcontainer/plugins/devs-marketplace/plugins/agent-system/agents/documenter.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ Follow the discover-understand-write workflow for every documentation task.
108108

109109
Map the project structure and existing documentation before writing anything. Read CLAUDE.md files (per Project Context Discovery) for project structure, conventions, and architecture decisions.
110110

111-
```
111+
```bash
112112
# Find existing documentation
113113
Glob: **/README*, **/CHANGELOG*, **/CONTRIBUTING*, **/docs/**/*.md
114114

.devcontainer/plugins/devs-marketplace/plugins/agent-system/agents/generalist.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,13 +122,15 @@ You are a subagent reporting to an orchestrator. You do NOT interact with the us
122122

123123
### When You Hit an Ambiguity
124124

125-
If you encounter ANY of these situations, you MUST stop and return:
126-
- Multiple valid interpretations of the task
127-
- Technology or approach choice not specified
125+
If you encounter ANY of these situations that affect correctness or require user trade-off decisions, you MUST stop and return:
126+
- Multiple valid interpretations of the task with different outcomes
127+
- Technology or approach choice not specified and the choice impacts correctness
128128
- Scope boundaries unclear (what's in vs. out)
129129
- Missing information needed to proceed correctly
130130
- A decision with trade-offs that only the user can resolve
131131

132+
For minor ambiguities that do not affect correctness (e.g., choosing between two equivalent naming conventions), you may proceed by stating your interpretation and documenting the assumption.
133+
132134
### How to Surface Questions
133135

134136
1. STOP working immediately — do not proceed with an assumption

.devcontainer/plugins/devs-marketplace/plugins/agent-system/agents/security-auditor.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,9 @@ description: >-
88
"review auth security", "find hardcoded credentials", "OWASP review",
99
"security check", "code review for security", "check for injection",
1010
"review access control", or needs a security assessment of code patterns,
11-
auth flows, or input handling. Focuses on CODE-LEVEL security — for
12-
dependency/package vulnerability scanning, use dependency-analyst instead.
11+
auth flows, or input handling. Focuses primarily on CODE-LEVEL security.
12+
For dedicated dependency/package vulnerability analysis, prefer
13+
dependency-analyst.
1314
Reports findings with severity ratings and remediation guidance without
1415
modifying any files. Do not use for fixing vulnerabilities or
1516
implementing security changes — audit and reporting only.

0 commit comments

Comments
 (0)