Skip to content

Commit e68327f

Browse files
committed
Fix 6 issues from CodeRabbit review
- chromaterm: username auto-detection fallback to root now works - biome: nvm.sh sourcing no longer aborts under set -u - setup.js: ccstatusline-settings.json added to DEFAULT_PRESERVE - docs: spec-writer moved to Read-Only agents table (matches definition) - guard-readonly-bash.py: docstring corrected (stderr, not JSON stdout) - git-forensics SKILL.md: misleading "blame" comment fixed
1 parent 2c26e3e commit e68327f

File tree

7 files changed

+15
-3
lines changed

7 files changed

+15
-3
lines changed

.devcontainer/CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,14 @@
22

33
## [v1.14.0] - 2026-02-24
44

5+
### Fixed (CodeRabbit review)
6+
- **chromaterm/install.sh** — username auto-detection now resets to empty before candidate loop, so `${USERNAME:-root}` fallback works correctly
7+
- **biome/install.sh** — nvm.sh sourcing wrapped in `set +u` / `set -u` to prevent unbound variable abort under `set -euo pipefail`
8+
- **setup.js**`ccstatusline-settings.json` added to DEFAULT_PRESERVE so user customizations survive `--force` package updates
9+
- **docs agent-system.md** — spec-writer moved from Full-Access to Read-Only agents table (matches its `permissionMode: plan` definition)
10+
- **guard-readonly-bash.py** — docstring corrected from "Returns JSON on stdout" to "Outputs block reason to stderr"
11+
- **git-forensics/SKILL.md** — misleading "Blame through renames" comment fixed to "Show patch history through renames"
12+
513
### Added
614

715
#### Nuclear Workspace Scope Enforcement

.devcontainer/features/biome/install.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@ echo "[biome] Version: ${VERSION}"
1414

1515
# Source NVM if available
1616
if [ -f /usr/local/share/nvm/nvm.sh ]; then
17+
set +u
1718
source /usr/local/share/nvm/nvm.sh
19+
set -u
1820
fi
1921

2022
# Validate npm is available

.devcontainer/features/chromaterm/install.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ echo "[chromaterm] Starting ChromaTerm2 installation..."
1919

2020
# ---------- USER ----------
2121
if [[ "${USERNAME}" == "auto" || "${USERNAME}" == "automatic" ]]; then
22+
USERNAME=""
2223
for u in vscode node codespace; do
2324
if id -u "$u" >/dev/null 2>&1; then
2425
USERNAME="$u"

.devcontainer/plugins/devs-marketplace/plugins/agent-system/scripts/guard-readonly-bash.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
(>, >>), eval/exec, inline scripting (python -c, node -e), and
1313
path/backslash prefix bypasses (/usr/bin/rm, \\rm).
1414
15-
Reads tool input from stdin (JSON). Returns JSON on stdout.
15+
Reads tool input from stdin (JSON). Outputs block reason to stderr.
1616
Exit 0: Command is safe (allowed)
1717
Exit 2: Command would modify state (blocked)
1818
"""

.devcontainer/plugins/devs-marketplace/plugins/skill-engine/skills/git-forensics/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ Track a file across renames. Without `--follow`, history stops at the rename:
105105
# Follow a file through renames
106106
git log --follow --oneline -- path/to/current_name.py
107107

108-
# Blame through renames
108+
# Show patch history through renames
109109
git log --follow -p -- path/to/file.py
110110
```
111111

docs/src/content/docs/plugins/agent-system.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ These agents investigate, analyze, and report — they never modify files.
122122
| **git-archaeologist** | Git history analysis, blame, bisect, forensics | Haiku | git-forensics |
123123
| **perf-profiler** | Performance profiling, bottleneck identification | Sonnet | performance-profiling |
124124
| **security-auditor** | Security audit, vulnerability assessment, OWASP checks | Sonnet | security-checklist |
125+
| **spec-writer** | Specification authoring and refinement | Opus | specification-writing |
125126

126127
### Full-Access Agents
127128

@@ -134,7 +135,6 @@ These agents can read and write files, run commands, and make changes to your co
134135
| **refactorer** | Behavior-preserving code transformations | Opus | Worktree | refactoring-patterns |
135136
| **doc-writer** | Documentation writing and maintenance | Opus | Worktree | documentation-patterns |
136137
| **migrator** | Code migration, framework upgrades | Opus | Worktree | migration-patterns |
137-
| **spec-writer** | Specification authoring and refinement | Opus | No | specification-writing |
138138
| **bash-exec** | Shell command execution and scripting | Sonnet | No ||
139139
| **statusline-config** | Statusline customization | Sonnet | No ||
140140

setup.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ const DEFAULT_PRESERVE = [
1010
"config/defaults/settings.json",
1111
"config/defaults/main-system-prompt.md",
1212
"config/defaults/keybindings.json",
13+
"config/defaults/ccstatusline-settings.json",
1314
"config/file-manifest.json",
1415
".codeforge-preserve",
1516
];

0 commit comments

Comments
 (0)