Fix pydantic lint issues (#64)

* Fix pydantic lint issues

* Remove support for python 3.8

* Fix linting

* Fix macos test stuck issue

* Debugging macos issue

Author: Ananto30

.github/workflows/codecov.yml

@@ -14,7 +14,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
     steps:
     - uses: actions/checkout@v4
     - name: Set up Python ${{ matrix.python-version }}

.github/workflows/lint.yml

@@ -11,6 +11,9 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: ["3.12"]
     steps:
     - uses: actions/checkout@v4
     - name: Set up Python ${{ matrix.python-version }}

Dockerfile.lint

@@ -0,0 +1,24 @@
+# syntax=docker/dockerfile:1
+FROM python:3.12-slim
+
+WORKDIR /app
+
+# Install system dependencies (if needed)
+RUN apt-get update && apt-get install -y \
+    build-essential \
+    && rm -rf /var/lib/apt/lists/*
+
+# Copy requirements
+COPY requirements.txt ./
+COPY requirements-lint.txt ./
+
+# Install Python dependencies
+RUN pip install --upgrade pip \
+    && pip install -r requirements.txt \
+    && pip install -r requirements-lint.txt
+
+# Copy the rest of the code
+COPY . .
+
+# Run tests (default command)
+CMD ["make", "lint"]

Dockerfile.test

@@ -0,0 +1,25 @@
+# syntax=docker/dockerfile:1
+FROM python:3.13-slim
+
+WORKDIR /app
+
+# Install system dependencies (if needed)
+RUN apt-get update && apt-get install -y \
+    build-essential \
+    && rm -rf /var/lib/apt/lists/*
+
+# Copy requirements
+COPY requirements.txt ./
+COPY tests/requirements.txt ./tests/
+
+# Install Python dependencies
+RUN pip install --upgrade pip \
+    && pip install -r requirements.txt \
+    && pip install -r tests/requirements.txt
+
+# Copy the rest of the code
+COPY zero zero
+COPY tests tests
+
+# Run tests (default command)
+CMD ["python3", "-m", "pytest", "tests", "--cov=zero", "--cov-report=term-missing", "--cov-config=.coveragerc", "-vv", "--durations=10", "--timeout=280"]

Makefile

@@ -9,18 +9,11 @@ setup:
 		)
 
 test:
-	python3 -m pytest tests --cov=zero --cov-report=term-missing --cov-config=.coveragerc -vv --durations=10 --timeout=280
+	python3 -m pytest tests --cov=zero --cov-report=term-missing --cov-config=.coveragerc -vv --durations=10 --timeout=280 -s --exitfirst
 
 docker-test:
-	docker build -t zero-test -f Dockerfile.test.py38 .
+	docker build -t zero-test -f Dockerfile.test .
 	docker run --rm zero-test
-	docker rmi zero-test
-	docker build -t zero-test -f Dockerfile.test.py39 .
-	docker run --rm zero-test
-	docker rmi zero-test
-	docker build -t zero-test -f Dockerfile.test.py310 .
-	docker run --rm zero-test
-	docker rmi zero-test
 
 format:
 	isort . --profile black -l 99
@@ -29,14 +22,18 @@ format:
 install-lint:
 	python -m pip install --upgrade pip
 	pip install -r requirements.txt  # needed for pytype
-	pip install black isort flake8 pylint pytype mypy pydantic>=2.0
+	pip install -r requirements-lint.txt
 
 lint:
 	flake8 ./zero
 	pylint ./zero
 	pytype ./zero
 	mypy ./zero
 
+docker-lint:
+	docker build -t zero-lint -f Dockerfile.lint .
+	docker run --rm zero-lint
+
 build-package:
 	pip install -U setuptools wheel
 	python3 setup.py sdist bdist_wheel

requirements-lint.txt

@@ -0,0 +1,7 @@
+black
+isort
+flake8
+pylint
+pytype
+mypy
+pydantic

setup.py

@@ -19,7 +19,7 @@
         "License :: OSI Approved :: MIT License",
         "Operating System :: OS Independent",
     ],
-    python_requires=">=3.8",
+    python_requires=">=3.9",
     package_dir={"": "."},
     install_requires=["pyzmq", "msgspec"],
     extras_require={

tests/conftest.py

@@ -0,0 +1,22 @@
+import subprocess  # nosec
+from multiprocessing import Process
+
+from tests.utils import kill_process, kill_subprocess, process_map
+
+
+def pytest_sessionfinish(session, exitstatus):
+    print("\n")
+    print("[PYTEST] Session is finishing, exitstatus:", exitstatus)
+
+    if process_map.values():
+        print(
+            f"[PYTEST] There are {len(process_map)} processes still running at the end of the session:"
+        )
+    for process in process_map.values():
+        print(f" - {process}")
+        if isinstance(process, subprocess.Popen):
+            kill_subprocess(process)
+            print(f"  alive: {process.poll() is None}")
+        elif isinstance(process, Process):
+            kill_process(process)
+            print(f"  alive: {process.is_alive()}")

tests/functional/multiple_servers/server2.py

@@ -6,11 +6,11 @@
 
 
 def echo(msg: str) -> str:
-    return client.call("echo", msg)  # type: ignore
+    return client.call("echo", msg)
 
 
 def hello() -> str:
-    return client.call("hello", None)  # type: ignore
+    return client.call("hello", None)
 
 
 async def async_echo(msg: str) -> str:

tests/functional/test_pydantic_v1.py

@@ -1,6 +1,7 @@
-import sys
 import importlib
+import sys
 from typing import Iterator
+
 import pytest
 
 
@@ -24,9 +25,6 @@ def test_module_with_pydantic_v1(patch_pydantic_to_v1: None) -> None:
 
     importlib.reload(generic)
 
-    # Now run assertions that rely on v1 behavior
-    assert not generic.IS_PYDANTIC_V2
-
     from pydantic import BaseModel
 
     class TestModel(BaseModel):