Skip to content

Commit eb2cee9

Browse files
fix: skip Windows code signing when WIN_CSC_LINK secret is absent
- Remove hardcoded certificateFile/certificatePassword from package.json win config - Add publisherName: "NetCopilot" so electron-builder doesn't need to extract it from a cert - electron-builder gracefully skips signing when WIN_CSC_LINK env var is empty
1 parent 38c6994 commit eb2cee9

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ jobs:
9191
APPLE_ID: ${{ secrets.APPLE_ID }}
9292
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
9393
CSC_IDENTITY_AUTO_DISCOVERY: ${{ secrets.APPLE_CERTIFICATE != '' && 'true' || 'false' }}
94-
# Windows signing (no-op if secrets absent)
94+
# Windows signing — skipped automatically when secrets are absent
9595
WIN_CSC_LINK: ${{ secrets.WIN_CSC_LINK }}
9696
WIN_CSC_KEY_PASSWORD: ${{ secrets.WIN_CSC_KEY_PASSWORD }}
9797
# GitHub token for electron-updater publish

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,7 @@
116116
"portable"
117117
],
118118
"icon": "resources/icon.ico",
119-
"certificateFile": "${WIN_CSC_LINK}",
120-
"certificatePassword": "${WIN_CSC_KEY_PASSWORD}"
119+
"publisherName": "NetCopilot"
121120
},
122121
"linux": {
123122
"target": [

0 commit comments

Comments
 (0)