Run workflow on pull requests & bump version (#33)

* Run workflow on pull requests & bump version

* Workflow should confirm formatting
* Apply code formatting

Author: AndreRenaud

.github/workflows/build_and_test.yml

@@ -1,13 +1,13 @@
 name: Build and Test
 
-on: [push]
+on: [push, pull_request]
 
 jobs:
   build:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v6
       - name: Build & Test
         run: make test
       - name: Fuzz
@@ -20,4 +20,6 @@ jobs:
       - name: Test no history
         run: |
           make clean
-          make CFLAGS="-DEMBEDDED_CLI_HISTORY_LEN=0 -I." test
+          make CFLAGS="-DEMBEDDED_CLI_HISTORY_LEN=0 -I." test
+      - name: Check code format
+        run: make format-check

Makefile

@@ -28,8 +28,11 @@ embedded_cli_fuzzer: embedded_cli.c tests/embedded_cli_fuzzer.c
 format:
 	$(CLANG_FORMAT) -i $(SOURCES)
 
+format-check:
+	$(CLANG_FORMAT) --Werror --dry-run $(SOURCES)
+
 clean:
 	rm -f *.o */*.o embedded_cli_test embedded_cli_fuzzer examples/posix_demo
 	rm -f timeout-* crash-*
 
-.PHONY: clean format test default fuzz
+.PHONY: clean format test default fuzz format-check

embedded_cli.c

@@ -60,7 +60,7 @@ void embedded_cli_init(struct embedded_cli *cli, const char *prompt,
 
 static void cli_ansi(struct embedded_cli *cli, size_t n, char code)
 {
-    char buffer[5] = {'\x1b', '[', (char) ('0' + (n % 10)), code, '\0'};
+    char buffer[5] = {'\x1b', '[', (char)('0' + (n % 10)), code, '\0'};
     cli_puts(cli, buffer);
 }
 
@@ -143,7 +143,7 @@ const char *embedded_cli_get_history(struct embedded_cli *cli,
 
     // Search back through the history buffer for `history_pos` entry
     for (int i = 0; i < history_pos; i++) {
-        int len = (int) strlen(&cli->history[pos]);
+        int len = (int)strlen(&cli->history[pos]);
         if (len == 0)
             return NULL;
         pos += len + 1;
@@ -205,7 +205,7 @@ bool embedded_cli_insert_char(struct embedded_cli *cli, char ch)
     // printf("Inserting char %d 0x%x '%c'\n", ch, ch, ch);
     if (cli->have_csi) {
         if (ch >= '0' && ch <= '9' && cli->counter < 100) {
-            cli->counter = (cli->counter * 10) + (size_t) (ch - '0');
+            cli->counter = (cli->counter * 10) + (size_t)(ch - '0');
             // printf("cli->counter -> %d\n", cli->counter);
         } else {
             if (cli->counter == 0)
@@ -374,7 +374,8 @@ bool embedded_cli_insert_char(struct embedded_cli *cli, char ch)
             break;
         case '\x15': // Ctrl-U
             // move back data after cursor, including last \0
-            memmove(cli->buffer, cli->buffer + cli->cursor, cli->len - cli->cursor + 1);
+            memmove(cli->buffer, cli->buffer + cli->cursor,
+                    cli->len - cli->cursor + 1);
             cli->len = cli->len - cli->cursor;
             // clear from beggining of buffer,
             // print buffer again and move back to start

examples/posix_demo.c

@@ -30,11 +30,11 @@ static char getch(void)
 
     // Do what cfmakeraw does (Using --std=c99 means that cfmakeraw isn't
     // available)
-    raw.c_iflag &=
-        (tcflag_t)~(IGNBRK | BRKINT | PARMRK | ISTRIP | INLCR | IGNCR | ICRNL | IXON);
+    raw.c_iflag &= (tcflag_t) ~(IGNBRK | BRKINT | PARMRK | ISTRIP | INLCR |
+                                IGNCR | ICRNL | IXON);
     raw.c_oflag &= (tcflag_t)~OPOST;
-    raw.c_lflag &= (tcflag_t)~(ECHO | ECHONL | ICANON | ISIG | IEXTEN);
-    raw.c_cflag &= (tcflag_t)~(CSIZE | PARENB);
+    raw.c_lflag &= (tcflag_t) ~(ECHO | ECHONL | ICANON | ISIG | IEXTEN);
+    raw.c_cflag &= (tcflag_t) ~(CSIZE | PARENB);
     raw.c_cflag |= CS8;
 
     raw.c_cc[VMIN] = 1;

tests/embedded_cli_test.c

@@ -148,7 +148,8 @@ static void output_putchar(void *data, char ch, bool is_last)
         // just ignore them
         if (ch >= 'A' && ch <= 'Z') {
             if (ch == 'K') // CLEAR_EOL
-                memset(&output[output_pos], 0, sizeof(output) - (size_t)output_pos);
+                memset(&output[output_pos], 0,
+                       sizeof(output) - (size_t)output_pos);
             have_csi = false;
         }
     } else {