Avoid wrapping size_t to -1 (#37)

AndreRenaud · web-flow · commit a591a473f4de · 2026-01-29T09:39:18.000+13:00
Avoids: embedded_cli.c:89:13: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'size_t' (aka 'unsigned long')
diff --git a/embedded_cli.c b/embedded_cli.c
@@ -85,9 +85,8 @@ static void term_cursor_fwd(struct embedded_cli *cli, size_t n)
 #if EMBEDDED_CLI_HISTORY_LEN
 static void term_backspace(struct embedded_cli *cli, size_t n)
 {
-    // printf("backspace %d ('%s': %d)\n", n, cli->buffer, cli->done);
-    while (n--)
-        cli_putchar(cli, '\b', n == 0);
+    for (; n > 0; n--)
+        cli_putchar(cli, '\b', n == 1);
 }
 
 static const char *embedded_cli_get_history_search(struct embedded_cli *cli)

Original file line number	Diff line number	Diff line change
`@@ -85,9 +85,8 @@ static void term_cursor_fwd(struct embedded_cli *cli, size_t n)`
`85`	`85`	`#if EMBEDDED_CLI_HISTORY_LEN`
`86`	`86`	`static void term_backspace(struct embedded_cli *cli, size_t n)`
`87`	`87`	`{`
`88`		`- // printf("backspace %d ('%s': %d)\n", n, cli->buffer, cli->done);`
`89`		`- while (n--)`
`90`		`- cli_putchar(cli, '\b', n == 0);`
	`88`	`+ for (; n > 0; n--)`
	`89`	`+ cli_putchar(cli, '\b', n == 1);`
`91`	`90`	`}`
`92`	`91`
`93`	`92`	`static const char embedded_cli_get_history_search(struct embedded_cli cli)`