Unit test updated for explainer

Author: avimallick

AntiPattern_Remediator/src/core/prompt/prompt_manager.py

@@ -41,34 +41,37 @@ def _load_all_prompts(self) -> None:
     def _load_prompt_from_yaml(self, filename: str, prompt_key: str) -> None:
         """Load a prompt configuration from a YAML file."""
         yaml_path = self.prompt_directory / filename
-        
+
         if not yaml_path.exists():
             print(f"Warning: Prompt file {yaml_path} not found")
             return
-        
+
         try:
             with open(yaml_path, 'r', encoding='utf-8') as file:
                 config = yaml.safe_load(file)
-            if prompt_key not in config:
+
+            if not config or prompt_key not in config:
                 print(f"Warning: Section '{prompt_key}' not found in {filename}")
                 return
-            
-            prompt_config = config[prompt_key]
 
-            # Build messages in (role, content) format
-            messages = []
-            if prompt_config.get("system"):
-                messages.append(("system", prompt_config["system"]))
-            if prompt_config.get("user"):
-                messages.append(("user", prompt_config["user"]))
-            messages.append(MessagesPlaceholder("msgs"))
+            prompt_config = config.get(prompt_key) or {}
+
+            # Always include System first (empty string if not provided) to satisfy tests
+            system_text = str(prompt_config.get("system", "") or "")
+            user_text   = str(prompt_config.get("user", "") or "")
+
+            messages = [
+                ("system", system_text),          # always present (possibly empty)
+                ("user", user_text),              # always present (possibly empty)
+                MessagesPlaceholder("msgs"),      # conversation history
+            ]
 
-            # Use the correct constructor
             self._prompt_cache[prompt_key] = ChatPromptTemplate.from_messages(messages)
             print(f"Loaded prompt '{prompt_key}' from {filename}")
-            
+
         except Exception as e:
             print(f"Error loading prompt from {filename}: {e}")
+
 
     def get_prompt(self, prompt_key: str) -> Optional[ChatPromptTemplate]:
         if prompt_key not in self._prompt_cache:

AntiPattern_Remediator/test/unit_test/prompt/test_prompt_manager.py

@@ -44,6 +44,7 @@ def __init__(self):
             self.REFACTOR_STRATEGIST = "refactor_strategist"
             self.CODE_TRANSFORMER = "code_transformer"
             self.CODE_REVIEWER = "code_reviewer"
+            self.EXPLAINER_AGENT = "explainer"
             self.prompt_directory = Path(__file__).parent
             self._prompt_cache = {}
             self._load_all_prompts()  # Call this to match real behavior
@@ -87,7 +88,8 @@ def _load_all_prompts(self):
                 self.ANTIPATTERN_SCANNER,
                 self.REFACTOR_STRATEGIST,
                 self.CODE_TRANSFORMER,
-                self.CODE_REVIEWER
+                self.CODE_REVIEWER,
+                self.EXPLAINER_AGENT,
             ]
 
             for prompt_key in prompt_constants:
@@ -155,6 +157,7 @@ def test_initialization_creates_correct_attributes(self):
             assert hasattr(manager, 'REFACTOR_STRATEGIST')
             assert hasattr(manager, 'CODE_TRANSFORMER')
             assert hasattr(manager, 'CODE_REVIEWER')
+            assert hasattr(manager, 'EXPLAINER_AGENT')
             assert hasattr(manager, 'prompt_directory')
             assert hasattr(manager, '_prompt_cache')
             assert isinstance(manager._prompt_cache, dict)
@@ -176,6 +179,7 @@ def test_prompt_constants_have_correct_values(self):
             assert manager.REFACTOR_STRATEGIST == "refactor_strategist"
             assert manager.CODE_TRANSFORMER == "code_transformer"
             assert manager.CODE_REVIEWER == "code_reviewer"
+            assert manager.EXPLAINER_AGENT == "explainer"
 
     def test_prompt_directory_is_set_correctly(self):
         """Test that prompt directory is assigned from settings."""
@@ -505,6 +509,7 @@ def test_initialization_with_missing_directory(self, capsys):
             manager.REFACTOR_STRATEGIST = "refactor_strategist" 
             manager.CODE_TRANSFORMER = "code_transformer"
             manager.CODE_REVIEWER = "code_reviewer"
+            manager.EXPLAINER_AGENT = "explainer"
             manager.prompt_directory = Path("/non/existent/path")
             manager._prompt_cache = {}
 
@@ -575,6 +580,12 @@ def temp_prompt_files(self):
                         'system': 'You are an expert code reviewer.',
                         'user': 'Review this code for quality and best practices: {code}'
                     }
+                },
+                'explainer.yaml': {
+                    'explainer': {
+                        'system': 'You are a senior software reviewer.',
+                        'user': 'Explain: {code}\nLang: {language}\nCtx: {context}'
+                    }
                 }
             }
 
@@ -593,22 +604,24 @@ def test_load_all_prompts_loads_all_available_files(self, temp_prompt_files, cap
             manager.REFACTOR_STRATEGIST = "refactor_strategist"
             manager.CODE_TRANSFORMER = "code_transformer"
             manager.CODE_REVIEWER = "code_reviewer"
+            manager.EXPLAINER_AGENT = "explainer"
             manager.prompt_directory = temp_prompt_files
             manager._prompt_cache = {}
 
             # Act: Load all prompts
             manager._load_all_prompts()
 
             # Assert: Verify all prompts were loaded
-            assert len(manager._prompt_cache) == 4
+            assert len(manager._prompt_cache) == 5
             assert "antipattern_scanner" in manager._prompt_cache
             assert "refactor_strategist" in manager._prompt_cache
             assert "code_transformer" in manager._prompt_cache
             assert "code_reviewer" in manager._prompt_cache
+            assert "explainer" in manager._prompt_cache
 
             # Verify success message
             captured = capsys.readouterr()
-            assert "Successfully loaded 4 prompts" in captured.out
+            assert "Successfully loaded 5 prompts" in captured.out
 
     def test_load_all_prompts_handles_partial_failures(self, capsys):
         """Test that _load_all_prompts continues loading even if some files are missing."""
@@ -633,6 +646,7 @@ def test_load_all_prompts_handles_partial_failures(self, capsys):
                 manager.REFACTOR_STRATEGIST = "refactor_strategist"
                 manager.CODE_TRANSFORMER = "code_transformer"
                 manager.CODE_REVIEWER = "code_reviewer"
+                manager.EXPLAINER_AGENT = "explainer"
                 manager.prompt_directory = temp_path
                 manager._prompt_cache = {}