Skip to content

Commit 94e5671

Browse files
AndrewLeedhamclaude
andcommitted
Fix build errors introduced by dependency updates
- Update JSX.IntrinsicElements -> React.JSX.IntrinsicElements in article code blocks (global JSX namespace removed in @types/react@19) - Remove standalone vite devDependency to fix type conflict with Astro's bundled vite@6 vs the explicit vite@7 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 49a96f1 commit 94e5671

3 files changed

Lines changed: 9 additions & 138 deletions

File tree

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
"@types/jest": "^30.0.0",
3838
"@types/node": "^25.0.3",
3939
"@types/react": "^19.2.7",
40-
"esbuild": "^0.27.2",
41-
"vite": "^7.3.1"
40+
"esbuild": "^0.27.2"
4241
}
4342
}

pnpm-lock.yaml

Lines changed: 5 additions & 133 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/content/articles/optimising-icon-loading-with-storybook-and-vite/index.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ For the purposes of this blog post the [Storybook](https://storybook.js.org/) in
2626
```tsx twoslash
2727
// @filename: IconBase.tsx
2828
import React from "react";
29-
export type IconProps = Omit<JSX.IntrinsicElements["svg"], "ref">;
29+
export type IconProps = Omit<React.JSX.IntrinsicElements["svg"], "ref">;
3030

3131
export default function IconBase(props: IconProps) {
3232
const { children, ...rest } = props;
@@ -79,7 +79,7 @@ For stories that have a control for the currently shown icon, we will dynamicall
7979
```tsx twoslash
8080
// @filename: IconBase.tsx
8181
import React from "react";
82-
export type IconProps = Omit<JSX.IntrinsicElements["svg"], "ref">;
82+
export type IconProps = Omit<React.JSX.IntrinsicElements["svg"], "ref">;
8383

8484
export default function IconBase(props: IconProps) {
8585
const { children, ...rest } = props;
@@ -120,7 +120,7 @@ This gives us a hook that returns a lazy component or undefined given an icon na
120120
```tsx twoslash
121121
// @filename: IconBase.tsx
122122
import React from "react";
123-
export type IconProps = Omit<JSX.IntrinsicElements["svg"], "ref">;
123+
export type IconProps = Omit<React.JSX.IntrinsicElements["svg"], "ref">;
124124

125125
export default function IconBase(props: IconProps) {
126126
const { children, ...rest } = props;

0 commit comments

Comments
 (0)