add formatOnSave setting#72
Draft
Andriamanitra wants to merge 3 commits into
Draft
Conversation
Open
cbc0edf to
b9b0380
Compare
Owner
Author
|
I tested this with pylsp and a 10k line file that required bunch of formatting and was not happy with the results. With a big file like that it takes multiple seconds to get back a response and handle it. In that time you may easily edit the document without realizing the formatting is not yet done, which leads to the document getting out of sync. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #71
TODO:
preSaveandformatActioncan usenullin json.lua should givejson.nullinstead ofnil#66 causes "[µlsp] No results" to be logged when saving a file that doesn't require any formatting, so that should be fixed before this can be mergedformatOnSavein config tofalse