feat: add strict tsconfig

Author: splincode

helpers/mocks/simple-mock.component.ts

@@ -5,7 +5,7 @@ import { TableRow } from '../../projects/table-builder/src/lib/table/interfaces/
 // noinspection AngularMissingOrInvalidDeclarationInModule
 @Component({
     selector: 'app',
-    template: ` <ngx-table-builder [source]="data" [buffer-amount]="5"></ngx-table-builder> `
+    template: ` <ngx-table-builder [source]="data"></ngx-table-builder> `
 })
 export class SimpleMockComponent {
     public data: TableRow[] = [

helpers/utils/mocks-generator.ts

@@ -1,4 +1,4 @@
-/* eslint-disable no-magic-numbers */
+/* eslint-disable no-magic-numbers,@typescript-eslint/no-magic-numbers */
 import { TableRow } from '../../projects/table-builder/src/lib/table/interfaces/table-builder.external';
 import { Any } from '../../projects/table-builder/src/lib/table/interfaces/table-builder.internal';
 import { WebWorkerThreadService } from '../../projects/table-builder/src/lib/table/worker/worker-thread.service';

package.json

@@ -16,6 +16,7 @@
         "@angular-devkit/build-angular": "0.803.26",
         "@angular-ru/eslint-config": "12.21.5",
         "@angular-ru/prettier-config": "12.19.1",
+        "@angular-ru/tsconfig": "12.21.5",
         "@angular/animations": "8.2.14",
         "@angular/cdk": "8.2.3",
         "@angular/cli": "8.3.26",
@@ -30,11 +31,10 @@
         "@angular/platform-browser-dynamic": "8.2.14",
         "@angular/router": "8.2.14",
         "@types/jest": "24.0.13",
-        "@types/node": "12.7.5",
+        "@types/node": "14.0.13",
         "acorn": "6.1.1",
         "colors": "1.3.3",
         "core-js": "2.6.9",
-        "eslint": "6.8.0",
         "hammerjs": "2.0.8",
         "husky": "3.0.5",
         "intersection-observer": "0.7.0",
@@ -49,7 +49,7 @@
         "ts-node": "7.0.0",
         "tsickle": "0.37.0",
         "tslib": "1.9.0",
-        "typescript": "3.5.1",
+        "typescript": "3.7.2",
         "zone.js": "0.10.2"
     }
 }

projects/table-builder/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@angular-ru/ng-table-builder",
-    "version": "2.2.0",
+    "version": "3.0.0",
     "license": "MIT",
     "bugs": {
         "url": "https://github.com/Angular-RU/ng-table-builder/issues"

projects/table-builder/src/lib/table-builder.module.ts

@@ -33,8 +33,8 @@ import { UtilsService } from './table/services/utils/utils.service';
 import { TableBuilderComponent } from './table/table-builder.component';
 import { WebWorkerThreadService } from './table/worker/worker-thread.service';
 
-if (window['Zone']) {
-    (window as Any)[window['Zone'].__symbol__('MutationObserver')] = MutationObserver;
+if ((window as Any)['Zone']) {
+    (window as Any)[(window as Any)['Zone'].__symbol__('MutationObserver')] = MutationObserver;
 }
 
 @NgModule({

projects/table-builder/src/lib/table/components/common/column-options.ts

@@ -13,12 +13,12 @@ export class ColumnOptions {
     @Input('overflow-tooltip') public overflowTooltip: boolean | null = null;
     @Input('filter-type') public filterType: TableFilterType | null = null;
     @Input() public nowrap: boolean | null = null;
-    @Input() public width: number = null;
+    @Input() public width: number | null = null;
     @Input('is-resizable') public isResizable: boolean | null = null;
     @Input('is-sortable') public isSortable: boolean | null = null;
     @Input('is-filterable') public isFilterable: boolean | null = null;
     @Input('is-draggable') public isDraggable: boolean | null = null;
-    @Input('css-class') public cssClass: string[];
-    @Input('css-style') public cssStyle: string[];
+    @Input('css-class') public cssClass: string[] = [];
+    @Input('css-style') public cssStyle: string[] = [];
     @Input() public stub: string | null = null;
 }

projects/table-builder/src/lib/table/components/common/modal-view-layer.ts

@@ -10,26 +10,27 @@ import { UtilsService } from '../../services/utils/utils.service';
 import { SCROLLBAR_WIDTH } from '../../symbols';
 
 export interface PositionState {
-    key: string;
-    opened: boolean;
+    key: string | null;
+    opened: boolean | null;
     position: MousePosition;
 }
 
+// eslint-disable-next-line
 export abstract class ModalViewLayer<T extends PositionState> implements OnDestroy {
-    public width: number = null;
-    public height: number = null;
+    public width: number | null = null;
+    public height: number | null = null;
     public isViewed: boolean = false;
     public isRendered: boolean = false;
-    public minHeight: number;
-    protected subscription: Subscription = null;
+    public minHeight: number | null = null;
+    protected subscription: Subscription | null = null;
     protected readonly app: ApplicationRef;
     protected readonly utils: UtilsService;
     protected readonly filterable: FilterableService;
     protected readonly ngZone: NgZone;
     protected readonly contextMenu: ContextMenuService;
 
     @ViewChild('menu', { static: false })
-    protected menu: ElementRef<HTMLDivElement>;
+    protected menu!: ElementRef<HTMLDivElement>;
 
     protected constructor(protected readonly cd: ChangeDetectorRef, injector: Injector) {
         this.app = injector.get<ApplicationRef>(ApplicationRef);
@@ -48,19 +49,19 @@ export abstract class ModalViewLayer<T extends PositionState> implements OnDestr
     }
 
     public get overflowX(): number {
-        const overflowX: number = this.width + this.left - this.utils.bodyRect.width;
+        const overflowX: number = this.width! + this.left - this.utils.bodyRect?.width!;
         return overflowX > 0 ? overflowX + SCROLLBAR_WIDTH : 0;
     }
 
     public get overflowY(): number {
-        const overflowY: number = this.calculatedHeight + this.top - this.utils.bodyRect.height;
+        const overflowY: number = this.calculatedHeight + this.top - this.utils.bodyRect?.height!;
         return overflowY > 0 ? overflowY + SCROLLBAR_WIDTH : 0;
     }
 
     public abstract get state(): Partial<T>;
 
     public get calculatedHeight(): number {
-        let height: number;
+        let height: number | null;
 
         try {
             if (this.height) {
@@ -75,7 +76,7 @@ export abstract class ModalViewLayer<T extends PositionState> implements OnDestr
             height = this.height;
         }
 
-        return height;
+        return height!;
     }
 
     public updateView(): void {
@@ -90,8 +91,8 @@ export abstract class ModalViewLayer<T extends PositionState> implements OnDestr
     }
 
     public ngOnDestroy(): void {
-        if (!this.subscription.closed) {
-            this.subscription.unsubscribe();
+        if (!this.subscription?.closed) {
+            this.subscription?.unsubscribe();
         }
     }
 
@@ -100,7 +101,7 @@ export abstract class ModalViewLayer<T extends PositionState> implements OnDestr
     protected update(): void {
         this.ngZone.runOutsideAngular((): void => {
             window.setTimeout((): void => {
-                this.isViewed = this.state.opened;
+                this.isViewed = !!this.state.opened;
                 this.updateView();
                 window.setTimeout((): void => this.updateView());
             });

projects/table-builder/src/lib/table/components/common/table-content.ts

@@ -4,8 +4,8 @@ import { TABLE_GLOBAL_OPTIONS } from '../../config/table-global-options';
 
 export class TableContent {
     @Input() public height: number = TABLE_GLOBAL_OPTIONS.ROW_HEIGHT;
-    @Input('content-cell') public contentCell: boolean = null;
-    @Input('align-center') public alignCenter: boolean = null;
-    @Input('css-class') public cssClasses: string[] = null;
-    @Input() public bold: boolean = null;
+    @Input('content-cell') public contentCell: boolean | null = null;
+    @Input('align-center') public alignCenter: boolean | null = null;
+    @Input('css-class') public cssClasses: string[] = [];
+    @Input() public bold: boolean | null = null;
 }

projects/table-builder/src/lib/table/components/ngx-column/ngx-column.component.ts

@@ -11,18 +11,18 @@ import { ColumnOptions } from '../common/column-options';
     encapsulation: ViewEncapsulation.None
 })
 export class NgxColumnComponent extends ColumnOptions {
-    @Input() public key: string = null;
+    @Input() public key: string | null = null;
     @Input() public stub: string = '-';
     @Input('sticky') public stickyLeft: boolean = false;
-    @Input('empty-head') public emptyHead: boolean = null;
-    @Input('head-title') public headTitle: string = null;
-    @Input('custom-key') public customKey: boolean = false;
+    @Input('empty-head') public emptyHead: boolean | null = null;
+    @Input('head-title') public headTitle: string | null = null;
+    @Input('custom-key') public customKey: boolean | string = false;
     @Input('sticky-end') public stickyRight: boolean = false;
     @Input('vertical-line') public verticalLine: boolean = false;
-    @Input('important-template') public importantTemplate: boolean = false;
+    @Input('important-template') public importantTemplate: boolean | string = false;
     @Input('overflow-tooltip') public overflowTooltip: boolean | null = null;
-    @ContentChild(TemplateHeadThDirective, { static: false }) public th: TemplateHeadThDirective;
-    @ContentChild(TemplateBodyTdDirective, { static: false }) public td: TemplateBodyTdDirective;
+    @ContentChild(TemplateHeadThDirective, { static: false }) public th!: TemplateHeadThDirective;
+    @ContentChild(TemplateBodyTdDirective, { static: false }) public td!: TemplateBodyTdDirective;
 
     public withKey(key: string): NgxColumnComponent {
         this.key = key;

projects/table-builder/src/lib/table/components/ngx-context-menu/ngx-context-menu-item/ngx-context-menu-item.component.ts

@@ -33,17 +33,17 @@ const MENU_WIDTH: number = 300;
 })
 export class NgxContextMenuItemComponent implements OnInit, OnDestroy {
     @Input() public visible: boolean = true;
-    @Input() public contextTitle: boolean = null;
+    @Input() public contextTitle: boolean | null = null;
     @Input() public disable: boolean = false;
     @Input() public divider: boolean = false;
     @Input('disable-sub-menu') public disableSubMenu: boolean = false;
     @Input('sub-menu-width') public subMenuWidth: number = MENU_WIDTH;
     @Output() public onClick: EventEmitter<ContextItemEvent> = new EventEmitter();
-    @ViewChild('item', { static: false }) public itemRef: ElementRef<HTMLDivElement>;
-    public offsetX: number = null;
-    public offsetY: number = null;
-    private subscription: Subscription;
-    private taskId: number;
+    @ViewChild('item', { static: false }) public itemRef: ElementRef<HTMLDivElement> | null = null;
+    public offsetX: number | null = null;
+    public offsetY: number | null = null;
+    private subscription: Subscription | null = null;
+    private taskId: number | null = null;
     private readonly contextMenu: ContextMenuService;
     private readonly utils: UtilsService;
     private readonly ngZone: NgZone;
@@ -87,21 +87,21 @@ export class NgxContextMenuItemComponent implements OnInit, OnDestroy {
     public calculateSubMenuPosition(ref: HTMLDivElement): void {
         const contentExist: boolean = ref.innerHTML.trim().length !== 0;
         if (contentExist) {
-            this.offsetX = this.clientRect.left + this.subMenuWidth - MIN_PADDING_CONTEXT_ITEM;
+            this.offsetX = this.clientRect.left! + this.subMenuWidth - MIN_PADDING_CONTEXT_ITEM;
             this.offsetX = this.offsetX - this.overflowX();
-            this.offsetY = this.clientRect.top - MIN_PADDING_CONTEXT_ITEM;
+            this.offsetY = this.clientRect.top! - MIN_PADDING_CONTEXT_ITEM;
             this.offsetY = this.offsetY - this.overflowY(ref);
             this.deferUpdateView();
         }
     }
 
     public overflowX(): number {
-        const overflowX: number = this.subMenuWidth + this.offsetX - this.utils.bodyRect.width;
+        const overflowX: number = this.subMenuWidth + this.offsetX! - this.utils.bodyRect?.width!;
         return overflowX > 0 ? overflowX + SCROLLBAR_WIDTH : 0;
     }
 
     public overflowY(ref: HTMLDivElement): number {
-        const overflowY: number = ref.offsetHeight + this.offsetY - this.utils.bodyRect.height;
+        const overflowY: number = ref.offsetHeight + this.offsetY! - this.utils.bodyRect?.height!;
         return overflowY > 0 ? overflowY + SCROLLBAR_WIDTH : 0;
     }
 
@@ -111,7 +111,7 @@ export class NgxContextMenuItemComponent implements OnInit, OnDestroy {
 
             this.onClick.emit({
                 preventDefault: (): void => {
-                    window.clearTimeout(this.taskId);
+                    window.clearTimeout(this.taskId!);
                 }
             });
 
@@ -127,7 +127,7 @@ export class NgxContextMenuItemComponent implements OnInit, OnDestroy {
 
     private deferUpdateView(): void {
         this.ngZone.runOutsideAngular((): void => {
-            window.clearInterval(this.taskId);
+            window.clearInterval(this.taskId!);
             this.taskId = window.setTimeout((): void => detectChanges(this.cd));
         });
     }