fix(ngxs): missing null check before accessing meta.version property#1539
Merged
splincode merged 2 commits intoAngular-RU:mainfrom Apr 2, 2026
Merged
Conversation
splincode
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix: Missing null check in versionIsInvalid
Problem
The
versionIsInvalidfunction indeserializeByStorageMetaaccessesmeta.versionwithout checking ifmetais null or undefined. If storage returns null/undefined data, this causes a runtime crash with 'Cannot read property 'version' of null/undefined'.Solution
Added a defensive null check at the beginning of
versionIsInvalidfunction that returnstrue(invalid) whenmetais null or undefined, preventing the runtime crash.Changes
versionIsInvalidfunction inlibs/ngxs/storage/utils/deserialize-by-storage-meta.tsif (!meta) { return true; }check before accessingmeta.versionTesting
This fix ensures that when storage returns null/undefined data, the function gracefully handles it by returning
true(version is invalid) instead of crashing.This PR was generated by PRJanitor — an automated tool that finds and fixes small bugs in open-source projects.
We respect your contribution guidelines — if your project doesn't accept bot PRs, we won't send more. You can also add a
.github/prjanitor.ymlfile withenabled: falseto opt out explicitly.