Merge pull request #296 from jurajmatus/minify-options

Configurable minification

Author: jayair

README.md

@@ -136,6 +136,8 @@ custom:
         - echo hello > test
     rawFileExtensions:              # An array of file extensions to import using the Webpack raw-loader.
       - csv                         # Defaults to ['pem', 'txt']
+    minifyOptions:                  # Options for ESBuildMinifyPlugin (https://esbuild.github.io/api/#simple-options)
+      - keepNames: true             # Disable symbol name mangling during minification
     experiments:                    # Give the ability to activate and try out experimental features of Webpack
 
 ```

src/config.js

@@ -29,6 +29,7 @@ module.exports = {
     externals: ["knex", "sharp"],
     // Set default file extensions to use the raw-loader with
     rawFileExtensions: ["pem", "txt"],
-    experiments: {}
+    minifyOptions: {},
+    experiments: {},
   },
 };

src/webpack.config.js

@@ -41,6 +41,7 @@ const ignorePackages = config.options.ignorePackages;
 const rawFileExtensions = config.options.rawFileExtensions;
 const fixPackages = convertListToObject(config.options.fixPackages);
 const tsConfigPath = path.resolve(servicePath, config.options.tsConfig);
+const minifyOptions = config.options.minifyOptions;
 
 const ENABLE_ESBUILD = config.options.esbuild;
 const ENABLE_STATS = config.options.stats;
@@ -299,7 +300,7 @@ function plugins() {
 
     if (ENABLE_LINTING) {
       if (parsedTsConfig.exclude) {
-        tsEslintConfig.ignorePatterns = parsedTsConfig.exclude
+        tsEslintConfig.ignorePatterns = parsedTsConfig.exclude;
       }
       forkTsCheckerWebpackOptions.eslint = {
         files: path.join(servicePath, "**/*.ts"),
@@ -475,6 +476,7 @@ module.exports = {
         minimizer: [
           new ESBuildMinifyPlugin({
             target: esbuildNodeVersion,
+            ...minifyOptions,
           }),
         ],
       },

tests/minify-options/.gitignore

@@ -0,0 +1,6 @@
+# package directories
+node_modules
+jspm_packages
+
+# Serverless directories
+.serverless

tests/minify-options/handler.js

@@ -0,0 +1,15 @@
+function namedFunction() {
+  return null;
+}
+
+class NamedClass {}
+
+export const hello = async () => {
+  return {
+    statusCode: 200,
+    body: JSON.stringify({
+      functionName: namedFunction.name,
+      className: NamedClass.name,
+    }),
+  };
+};

tests/minify-options/minify-options.test.js

@@ -0,0 +1,15 @@
+const { runSlsCommand, clearNpmCache, errorRegex } = require("../helpers");
+
+beforeEach(async () => {
+  await clearNpmCache(__dirname);
+});
+
+afterAll(async () => {
+  await clearNpmCache(__dirname);
+});
+
+test("minify-options", async () => {
+  const result = await runSlsCommand(__dirname);
+
+  expect(result).not.toMatch(errorRegex);
+});

tests/minify-options/package-lock.json

@@ -0,0 +1,17 @@
+{
+  "name": "esbuild",
+  "version": "1.0.0",
+  "description": "",
+  "main": "handler.js",
+  "scripts": {
+    "test": "echo \"Error: no test specified\" && exit 1"
+  },
+  "keywords": [],
+  "author": "",
+  "license": "ISC",
+  "devDependencies": {
+    "esbuild-loader": "^2.9.2",
+    "reflect-metadata": "^0.1.13"
+  },
+  "dependencies": {}
+}

tests/minify-options/package.json

@@ -0,0 +1,17 @@
+service: my-service
+
+plugins:
+  - '../../index'
+
+custom:
+  bundle:
+    minifyOptions:
+      keepNames: true
+
+provider:
+  name: aws
+  runtime: nodejs14.x
+
+functions:
+  hello:
+    handler: handler.hello