fixes bind problem and fixes CMakeLists compilation#26
Open
lattice0 wants to merge 1 commit into
Open
Conversation
Owner
|
Thank for your advice, I'll try the new jrtplib soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
On Android Studio with Android NDK 20, there's no gcc anymore, so it uses clang. On clang, file
rtpudpv4transmitter.cppgives error in thebindfunction because it thinks it should usestd::bind(because of using namespace std above). So doing::bindsolves the problem.I also enhanced CMakeLists integration, because Android NDK requires it.
ps: the newer JTRPLIB does not use
using namespace stdinrtpudpv4transmitter.cpp. Do you have plans to update to the newest JRTPLIB? It should be nice to have a more modern approach. I tried to update for you but it breaks the myRtpSession class because some of the properties used by it were made private in the newer version of JRTPLIB.About the other issue I opened here, about the regex error in my Vstarcam camera, I'm gonna see what's happening, thanks for testing yourself!