fixes #753

Author: jph00

fastcore/docments.py

@@ -356,7 +356,8 @@ def __str__(self):
                 curr.append(fmt)
                 if doc: lines.append(', '.join(curr) + ',' + comment); curr = []
             if curr: lines.append(', '.join(curr))
-            sig_str = f"def {get_name(self.obj)}(\n    {'\n    '.join(lines)}\n{self._ret_str}"
+            params = '\n    '.join(lines)
+            sig_str = f"def {get_name(self.obj)}(\n    {params}\n{self._ret_str}"
         docstr = f'    "{self.obj.__doc__}"' if self.docstring and self.obj.__doc__ else ''
         return f"{sig_str}\n{docstr}"
 

nbs/03_xtras.ipynb

@@ -1919,7 +1919,7 @@
        "```python\n",
        "\n",
        "def ReindexCollection(\n",
-       "    coll, idxs:NoneType=None, cache:NoneType=None, tfm:function=<function noop at 0x10c78a3e0>\n",
+       "    coll, idxs:NoneType=None, cache:NoneType=None, tfm:function=<function noop>\n",
        "):\n",
        "\n",
        "\n",
@@ -1931,7 +1931,7 @@
        "```python\n",
        "\n",
        "def ReindexCollection(\n",
-       "    coll, idxs:NoneType=None, cache:NoneType=None, tfm:function=<function noop at 0x10c78a3e0>\n",
+       "    coll, idxs:NoneType=None, cache:NoneType=None, tfm:function=<function noop>\n",
        "):\n",
        "\n",
        "\n",

nbs/04_docments.ipynb

@@ -1847,7 +1847,7 @@
        "| **Returns** | **int** |  |  |"
       ],
       "text/plain": [
-       "DocmentTbl(obj=<function _f at 0x135fa8c20>, dm={'a': {'docment': 'description of param a', 'anno': <class 'inspect._empty'>, 'default': <class 'inspect._empty'>}, 'b': {'docment': 'description of param b', 'anno': <class 'bool'>, 'default': True}, 'c': {'docment': <class 'inspect._empty'>, 'anno': <class 'str'>, 'default': None}, 'return': {'docment': <class 'inspect._empty'>, 'anno': <class 'int'>, 'default': <class 'inspect._empty'>}}, verbose=True, returns=True, params=['a', 'b', 'c'])"
+       "DocmentTbl(obj=<function _f>, dm={'a': {'docment': 'description of param a', 'anno': <class 'inspect._empty'>, 'default': <class 'inspect._empty'>}, 'b': {'docment': 'description of param b', 'anno': <class 'bool'>, 'default': True}, 'c': {'docment': <class 'inspect._empty'>, 'anno': <class 'str'>, 'default': None}, 'return': {'docment': <class 'inspect._empty'>, 'anno': <class 'int'>, 'default': <class 'inspect._empty'>}}, verbose=True, returns=True, params=['a', 'b', 'c'])"
       ]
      },
      "execution_count": null,
@@ -1925,7 +1925,7 @@
        "| **Returns** | **str** |  | **Result of doing it** |"
       ],
       "text/plain": [
-       "DocmentTbl(obj=<function _f at 0x136032840>, dm={'a': {'docment': <class 'inspect._empty'>, 'anno': <class 'inspect._empty'>, 'default': <class 'inspect._empty'>}, 'b': {'docment': 'param b', 'anno': <class 'int'>, 'default': <class 'inspect._empty'>}, 'c': {'docment': 'param c', 'anno': <class 'str'>, 'default': 'foo'}, 'return': {'docment': 'Result of doing it', 'anno': <class 'str'>, 'default': <class 'inspect._empty'>}}, verbose=True, returns=True, params=['a', 'b', 'c'])"
+       "DocmentTbl(obj=<function _f>, dm={'a': {'docment': <class 'inspect._empty'>, 'anno': <class 'inspect._empty'>, 'default': <class 'inspect._empty'>}, 'b': {'docment': 'param b', 'anno': <class 'int'>, 'default': <class 'inspect._empty'>}, 'c': {'docment': 'param c', 'anno': <class 'str'>, 'default': 'foo'}, 'return': {'docment': 'Result of doing it', 'anno': <class 'str'>, 'default': <class 'inspect._empty'>}}, verbose=True, returns=True, params=['a', 'b', 'c'])"
       ]
      },
      "execution_count": null,
@@ -2018,7 +2018,7 @@
        "| d | bool | True | description of param d |"
       ],
       "text/plain": [
-       "DocmentTbl(obj=<function _Test.foo at 0x135ffdbc0>, dm={'c': {'docment': 'description of param c', 'anno': <class 'int'>, 'default': <class 'inspect._empty'>}, 'd': {'docment': 'description of param d', 'anno': <class 'bool'>, 'default': True}, 'return': {'docment': <class 'inspect._empty'>, 'anno': <class 'inspect._empty'>, 'default': <class 'inspect._empty'>}}, verbose=True, returns=True, params=['self', 'c', 'd'])"
+       "DocmentTbl(obj=<function _Test.foo>, dm={'c': {'docment': 'description of param c', 'anno': <class 'int'>, 'default': <class 'inspect._empty'>}, 'd': {'docment': 'description of param d', 'anno': <class 'bool'>, 'default': True}, 'return': {'docment': <class 'inspect._empty'>, 'anno': <class 'inspect._empty'>, 'default': <class 'inspect._empty'>}}, verbose=True, returns=True, params=['self', 'c', 'd'])"
       ]
      },
      "execution_count": null,
@@ -2150,7 +2150,8 @@
     "                curr.append(fmt)\n",
     "                if doc: lines.append(', '.join(curr) + ',' + comment); curr = []\n",
     "            if curr: lines.append(', '.join(curr))\n",
-    "            sig_str = f\"def {get_name(self.obj)}(\\n    {'\\n    '.join(lines)}\\n{self._ret_str}\"\n",
+    "            params = '\\n    '.join(lines)\n",
+    "            sig_str = f\"def {get_name(self.obj)}(\\n    {params}\\n{self._ret_str}\"\n",
     "        docstr = f'    \"{self.obj.__doc__}\"' if self.docstring and self.obj.__doc__ else ''\n",
     "        return f\"{sig_str}\\n{docstr}\"\n",
     "    \n",