fixes #786

Author: jph00

fastcore/_modidx.py

@@ -702,6 +702,7 @@
                                 'fastcore.xtras.Path.delete': ('xtras.html#path.delete', 'fastcore/xtras.py'),
                                 'fastcore.xtras.Path.ls': ('xtras.html#path.ls', 'fastcore/xtras.py'),
                                 'fastcore.xtras.Path.mk_write': ('xtras.html#path.mk_write', 'fastcore/xtras.py'),
+                                'fastcore.xtras.Path.mkdir_perms': ('xtras.html#path.mkdir_perms', 'fastcore/xtras.py'),
                                 'fastcore.xtras.Path.normpath': ('xtras.html#path.normpath', 'fastcore/xtras.py'),
                                 'fastcore.xtras.Path.read_json': ('xtras.html#path.read_json', 'fastcore/xtras.py'),
                                 'fastcore.xtras.Path.readlines': ('xtras.html#path.readlines', 'fastcore/xtras.py'),

fastcore/xtras.py

@@ -384,12 +384,31 @@ def _expand_import(node, mod, existing):
             code = _replace_node(code, node, new_import)
     return code
 
+# %% ../nbs/03_xtras.ipynb #15c2b62c
+@patch
+def mkdir_perms(self:Path, mode=0o777, parents=False, exist_ok=False, uid=-1, gid=-1):
+    "Create directory like Path.mkdir but optionally set uid/gid on newly created dirs"
+    if self.exists() and not exist_ok: raise FileExistsError(self)
+    to_create = []
+    p = self
+    while not p.exists():
+        to_create.append(p)
+        if parents: p = p.parent
+        else: break
+    for d in reversed(to_create):
+        try: d.mkdir(mode=mode)
+        except FileExistsError:
+            if d==self and not exist_ok: raise
+            continue
+        if uid>-1 or gid>-1: os.chown(d, uid, gid)
+
 # %% ../nbs/03_xtras.ipynb #832397a3
 @contextmanager
 def atomic_save(fn, mode='wb', uid=-1, gid=-1, **kwargs):
     "Context manager for writing a file atomically via a temp file that is renamed on close"
     from tempfile import NamedTemporaryFile as ntf
     fn = Path(fn)
+    fn.parent.mkdir_perms(parents=True, exist_ok=True, uid=uid, gid=gid)
     with ntf(mode=mode, dir=fn.parent, delete=False, suffix=fn.suffix, **kwargs) as f:
         try: yield f
         except:

nbs/03_xtras.ipynb

@@ -1298,6 +1298,59 @@
     "test_eq(expand_wildcards(inp), exp)"
    ]
   },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "id": "15c2b62c",
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "#| export\n",
+    "@patch\n",
+    "def mkdir_perms(self:Path, mode=0o777, parents=False, exist_ok=False, uid=-1, gid=-1):\n",
+    "    \"Create directory like Path.mkdir but optionally set uid/gid on newly created dirs\"\n",
+    "    if self.exists() and not exist_ok: raise FileExistsError(self)\n",
+    "    to_create = []\n",
+    "    p = self\n",
+    "    while not p.exists():\n",
+    "        to_create.append(p)\n",
+    "        if parents: p = p.parent\n",
+    "        else: break\n",
+    "    for d in reversed(to_create):\n",
+    "        try: d.mkdir(mode=mode)\n",
+    "        except FileExistsError:\n",
+    "            if d==self and not exist_ok: raise\n",
+    "            continue\n",
+    "        if uid>-1 or gid>-1: os.chown(d, uid, gid)"
+   ]
+  },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "id": "5c6c3416",
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "import tempfile\n",
+    "from fastcore.test import test_fail\n",
+    "\n",
+    "with tempfile.TemporaryDirectory() as tmpdir:\n",
+    "    base = Path(tmpdir)\n",
+    "    p1 = base/'test1'\n",
+    "    p1.mkdir_perms()\n",
+    "    assert p1.exists() and p1.is_dir()\n",
+    "    \n",
+    "    p2 = base/'a'/'b'/'c'\n",
+    "    p2.mkdir_perms(parents=True)\n",
+    "    assert p2.exists() and (base/'a').exists()\n",
+    "    \n",
+    "    p1.mkdir_perms(exist_ok=True)\n",
+    "    assert p1.exists()\n",
+    "    \n",
+    "    test_fail(p1.mkdir_perms, exc=FileExistsError)\n",
+    "    test_fail((base/'missing'/'child').mkdir_perms, exc=FileNotFoundError)"
+   ]
+  },
   {
    "cell_type": "code",
    "execution_count": null,
@@ -1311,6 +1364,7 @@
     "    \"Context manager for writing a file atomically via a temp file that is renamed on close\"\n",
     "    from tempfile import NamedTemporaryFile as ntf\n",
     "    fn = Path(fn)\n",
+    "    fn.parent.mkdir_perms(parents=True, exist_ok=True, uid=uid, gid=gid)\n",
     "    with ntf(mode=mode, dir=fn.parent, delete=False, suffix=fn.suffix, **kwargs) as f:\n",
     "        try: yield f\n",
     "        except:\n",